this code give me the error " incorrect syntax near keyword 'where' how to slove it

Question

0.00/5 (No votes)

See more:

SQL

SqlCommand UpdateCommand = new SqlCommand("Update Stock Set ConfigID = @ConfigID , Quantity = @Quantity ,TotalPrice =@TotalPrice, StockDate =@StockDate ,Where StockID='" + txtStockID.Text + "'");
                UpdateCommand.Connection = con;
                UpdateCommand.Parameters.Add("@ConfigID",SqlDbType.Int).Value= txtConfigID.Text;
                UpdateCommand.Parameters.Add("@Quantity", SqlDbType.Int).Value = txtQty.Text;
                UpdateCommand.Parameters.Add("@TotalPrice", SqlDbType.Int).Value = txtTotalPrice.Text;
                UpdateCommand.Parameters.Add("@StockDate", SqlDbType.NVarChar, 50).Value = dtpStockDate.Value;
                con.Open();
                UpdateCommand.ExecuteNonQuery();
Con.Close();

Posted 31-Jul-14 23:08pm

Gold hugh

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Nirav Prabtani** · Accepted Answer · 2014-07-31T23:09:00

Solution 1

Remoce "," from query and try this.. :)

C#

SqlCommand UpdateCommand = new SqlCommand("Update Stock Set ConfigID = @ConfigID , Quantity = @Quantity ,TotalPrice =@TotalPrice, StockDate =@StockDate Where StockID='" + txtStockID.Text + "'");

Posted 31-Jul-14 23:09pm

Nirav Prabtani

v2

Wendelius · Accepted Answer · 2014-07-31T23:30:00

And to add to Nirav's answer, since you already use SqlParameters for the values, you should also use SqlParameter for the WHERE clause instead of concatenating txtStockID.Text directly to the string.

Direct concatenation leaves you open to SQL injections etc as you're already probably aware of :)