No output for own implementation of strcpy in c

Question

3.50/5 (2 votes)

See more:

Hi, guys trying to implement own strcpy function, but no output is being printed. Please help.

Objective-C

#include<stdio.h>
#include<string.h>

void strcpy_own(char dest[], char src[], int len);

int main()
{
    char src[15]="jeevan", dest[15];
    int length=0;
    length = strlen(src)+1;
    strcpy_own(dest,src,length);
    return 0;
}

void strcpy_own(char dest[], char src[], int len)
{
    int i=0;
    for(i=0;i<len;i++)
    {
        while(src[i]!='\0')
        dest[i]=src[i];

    }
    dest[strlen(dest)+1]='\0';
            printf("%s",dest);
            getchar();
}

Posted 19-Aug-14 21:22pm

Jeevan83

Updated 19-Aug-14 21:23pm

v3

Add a Solution

Comments

Sergey Alexandrovich Kryukov 20-Aug-14 3:57am

Such functions should not print anything. The calling code can print it...
—SA

Jeevan83 24-Aug-14 14:09pm

Gotcha!

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Fredrik Bornander · Answer 1 · 2014-08-19T21:38:00

Your inner while-loop does not increment i,

C#

for(i=0;i<len;i++)
{
    while(src[i]!='\0')
       dest[i]=src[i]; // i does not get updated here, the while will never exit

}

Change it to something like this;

C#

for(i=0;i<len;i++)
{
    dest[i]=src[i];
    if (src[i] =='\0')
        break;
}

Remember that you want to copy the last '\0' from src to dest or dest won't be properly zero-terminated.

Hope this helps,
Fredrik

OriginalGriff · Answer 2 · 2014-08-19T21:41:00

I'm not surprised.
If the first character in the source string isn't a null, this loop will never exit:

C#

while(src[i]!='\0')
dest[i]=src[i];

Try this:

C#

for(i=0;i<len;i++)
{
    dest[i]=src[i];
    if (src[i]=='\0') break;
}

And be careful with the line after the loop - if the source string is full then you could overrun the output array.

No output for own implementation of strcpy in c

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0