problem in calling function

Question

1.00/5 (3 votes)

See more:

#include<iostream.h>
#include<stdio.h>
#include<conio.h>
#include<stdlib.h>
#include<time.h>
class matrix
{
public:
int row,col,mat[100][100];
void spiraltraversal(int **,int,int);
void zigzagtraversal(int **,int,int);
};
void main()
{
matrix a;
clrscr();
printf("Enter the no. of rows=");
scanf("%d",&a.row);
printf("Enter the no. of columns=");
scanf("%d",&a.col);
printf("The order of matrix is %d*%d\n",a.row,a.col);
srand(time(NULL));
int i,j;
for(i=0;i<a.row;i++)>
 {
  for(j=0;j<a.col;j++)>
   {
    a.mat[i][j]=rand()%100+1;
    printf("%u\t",a.mat[i][j]);
   }
  printf("\n");
 }

 a.spiraltraversal(&&a.mat,a.row,a.col); //error :  expression syntax
 
getch();
}

void matrix::spiraltraversal(int **arr,int n,int m)
{

  int rs=0,cs=0;
  int re=n-1,ce=m-1;

  while(rs<=re && cs<=ce)
  {

    int i=rs,j=cs;

    for(j=cs;j<=ce;j++)
    printf(" %u ",arr[i][j]);

    for(j=rs+1,j--;i<=re;i++)
    printf(" %u  ",arr[i][j]);

    for(j=ce-1,i--;j>=cs;j--)
    printf(" %u ",arr[i][j]);

    for(i=re-1,j++;i>=rs+1;i--);
    printf(" %u ",arr[i][j]);

    rs++; cs++; re--; ce--;
   }
}

Posted 23-Aug-14 8:01am

Member 11018648

Updated 23-Aug-14 17:19pm

Sergey Alexandrovich Kryukov

v5

Add a Solution

Comments

[no name] 23-Aug-14 14:12pm

And what you expect us to do with this? Your code is not compilable, no description of a problem anywhere, no description of what your code is supposed to do, nothing about what your code is doing.

Member 11018648 23-Aug-14 14:35pm

sorry
In this program I want to print the matrix of random numbers and spiral traversing of matrix
But the problem is in calling function "spiraltraverse"

[no name] 23-Aug-14 16:17pm

http://www.eskimo.com/~scs/cclass/int/sx9a.html

Sergey Alexandrovich Kryukov 23-Aug-14 23:18pm

I fixed some formatting of the code for you, but it's still poor.
This is a code dump, not a question.
—SA

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nv3 · Answer 1 · 2014-08-24T12:00:00

You are asking the same question as a couple of days ago. In my answer to it:
How Do I Call This Function[^]
in solution 3, you will find the full story, why transferring the array by int** is no good idea.

Use a simple int* instead, or even better don't pass the array as parameter when you can access it as a member variable of class matrix, just like KarstenK suggested.

KarstenK · Answer 2 · 2014-08-24T06:53:00

Thats no real "OOP": dont make class members argument in functions of the object :doh:

and rewrite the call

C++

a.spiraltraversal();

the implementation should look like this

void matrix::spiraltraversal()
{
 
  int rs=0,cs=0;
  int re=row-1,ce=col-1;
 
  while(rs<=re && cs<=ce)
  {
 
    int i=rs,j=cs;
 
    for(j=cs;j<=ce;j++)
    printf(" %u ",mat[i][j]);
 
    for(j=rs+1,j--;i<=re;i++)
    printf(" %u  ",mat[i][j]);
 
    for(j=ce-1,i--;j>=cs;j--)
    printf(" %u ",mat[i][j]);
 
    for(i=re-1,j++;i>=rs+1;i--);
    printf(" %u ",mat[i][j]);
 
    rs++; cs++; re--; ce--;
   }
}

or similar ;-)

problem in calling function

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0