How Do I Solve The Error Index Was Outside The Bounds Of The Array.

Question

0.00/5 (No votes)

See more:

C#

public string UpdateUserID(string updateID)
    {
        UpdatedBy = System.Web.HttpContext.Current.Request.LogonUserIdentity.Name.Substring(12);

        string sql = "select Update_UserID from Cwipuser.CWIP_Variances  ";
        SqlCommand cmd = new SqlCommand(sql, MyCon);
        MyCon.Open();
        SqlDataReader rdr = cmd.ExecuteReader();

        while (rdr.Read())
        {
          if (!rdr.IsDBNull(1))
            {
                updateID = rdr.GetString(1);
            }
              updateID = UpdatedBy;
        }
        MyCon.Close();
        return updateID;
    }

Posted 27-Aug-14 1:12am

mampaf

Updated 27-Aug-14 1:19am

Thanks7872

v3

Add a Solution

Comments

[no name] 27-Aug-14 7:14am

You are only selecting 1 column and trying to access the 2nd element.

mampaf 27-Aug-14 7:17am

yes because i want to get the second value from the DB

[no name] 27-Aug-14 7:18am

You don't understand how arrays work do you?

ClimerChinna 27-Aug-14 7:19am

i think the result is having only one value, check it by debugging

mampaf 27-Aug-14 7:26am

ok thanks i will debug it,and if it stil doesnt work u will help me out right. . ?

mampaf 27-Aug-14 7:53am

ok i debugged and what happens is this.....it goes til while (rdr.Read())
then skips the if statement and goes out

Gihan Liyanage 27-Aug-14 7:20am

If you want to read second value, then why are you using loop ?

mampaf 27-Aug-14 7:25am

yes i dnt knw arrays and im new in C#, if i dont use loop wht should i use then?

Gihan Liyanage 27-Aug-14 7:34am

See, You are giving Update ID as input, and again returning Update ID, if you return updated parameter then you should use ref for the parameter. The first thing I have seen.

public string UpdateUserID(ref string updateID)
Then I assumed you want to get Updated user ID from Data base according to the user name that currently loggin to the system. Is it ?

mampaf 27-Aug-14 7:47am

yes i want UptID to be the person who loged in, so i should put the ref b4 string?

mampaf 28-Aug-14 2:46am

thnx i got it, hey is it posible to use a foreach row in datagrid.rows but only for one row?like it should not loop for the whole 5rows,it shud only loop once n stop

2 solutions

Solution 2

You're returning only one field Update_UserID from the query...therefore you have to access index 0 not 1.

That is updateID = rdr.GetString(0)

Same for IsNull function.

Alternatively, IndexOutOfRangeException could be thrown by Substring(12) if UserIdentity.Name is shorter then 13 characters (again, 0-based index means you're starting from 13th character)

Posted 27-Aug-14 1:15am

Sinisa Hajnal

Updated 27-Aug-14 1:19am

v2

Comments

mampaf 27-Aug-14 7:20am

at (0) there is something that i dont want thats y i am saying (1)

mampaf 27-Aug-14 7:30am

oooh ya i think it myt be the substring,so should i increase the 12 to 13 or what ?

mampaf 27-Aug-14 8:19am

doesnt work

Sinisa Hajnal 28-Aug-14 2:17am

Depends on why do you do it...If you're just trying to remove domain name or computer name from the username, better use split function. Otherwise, find (via breakpoint) what data comes there and either don't substring or find a function that fits (i.e. yourstring.substring(yourstring.length -3) will take only last 3 characters, yourstring.split("\")(1) will take domain\username and select only username etc...

Also, INCREASING from 12 to 13 cannot work, already 12 is too large and you get out of range exception, you should LOWER it (to 11 if you want to ignore first 11 characters and take 12th)

mampaf 28-Aug-14 2:45am

thnx i got it, hey is it posible to use a foreach row in datagrid.rows but only for one row?like it should not loop for the whole 5rows,it shud only loop once n stop

Sinisa Hajnal 28-Aug-14 3:18am

Sure, but you don't have to use for each (or any loop) for one row: simply take the row and process it. No need to loop unless you have to go through all of them to find which one you need to process.

Once you find it, process it and call break; to end the loop.

If you mean is it possible to apply the same function to every row without looping through, then the answer is no, but you can use DataGrid event DataRowBound (or something like that) to modify the row as it is bound.

mampaf 28-Aug-14 3:36am

i want to go through all of them to find the one i need to process.
process it and call break; to end the loop.

Sinisa Hajnal 28-Aug-14 7:36am

As ClimmerChinna explained, this is available in the table, but you're returning single parameter from the query and you should use index 0. This index from the reader refers to fields of the query not of the table.

mampaf 28-Aug-14 3:46am

pls bear with me i am new to this thing and rili nid help

look at my piece of code:

protected void BtnChanged_Click(object sender, EventArgs e)
{
ChangedBy = getInfo.ChangedByUser(ChangedBy);
DataTable dt = getInfo.ChangeAndConfirm(compileUserDI);

int rownumber = 0;

foreach (GridViewRow row in GridView1.Rows)
{
BusnesCase = GridView1.Rows[rownumber].Cells[0].Text;
coments = GridView1.Rows[rownumber].Cells[2].Text;
CheckBox cb = (CheckBox)row.FindControl("chkApprove");

if (cb.Checked) //If approved
{
try
{
changed = "YES";
getInfo.ChangedComents(BusnesCase, changed.ToString());
getInfo.updateChange(coments, changed, ChangedBy,ReviewID, BusnesCase);
getInfo.SendChangedEmail(ReviewID);
getInfo.UpdateChangedMail(compileUserDI);
}

catch (Exception ex)
{
//DatabaseError = true;
//Label2.Text = "Error: " + ex.Message;
}
}
else
{
changed = "NO";
getInfo.UnchangedComnts(BusnesCase, changed.ToString());
getInfo.updateChange(coments, changed, ChangedBy,ReviewID, BusnesCase);
getInfo.SendChangedEmail(ReviewID);
getInfo.UpdateChangedMail(compileUserDI);
}
//rownumber = rownumber + 1;
}
lblErrMsg.Visible = true;
lblErrMsg.Text = " Changed email has been Sent to the apropriate user !";
BtnChanged.Enabled = false;
}

Sinisa Hajnal 28-Aug-14 7:31am

Is there a question here? The code seems fine...assuming you're leting your users edit several rows and then clicking BtnChanged to commit the changes.

You have some code that is duplicated or unused. In particular, you don't use changed and rownumber variables and you have UpdateChange, SendChangedEmail and UpdateChangedEmail in both YES and NO branches...instead have if decide to call ChangedComments or UnchangedComments and call other three functions always...

Also, it would be nice if you accepted my solution :) We can keep commenting...

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ClimerChinna · Accepted Answer · 2014-08-27T01:15:00

Solution 1

try to give like below

SQL

while (rdr.Read())
{
if (!rdr.IsDBNull(0))
{
updateID = rdr.GetString(0);
}
updateID = UpdatedBy;
}

Posted 27-Aug-14 1:15am

ClimerChinna

Comments

mampaf 27-Aug-14 7:24am

that one is for "ID" and i want "updateID" which is at position1

ClimerChinna 27-Aug-14 7:27am

what is id and updateid here you are returning only updateuserid from the select query right then how will you get id

mampaf 27-Aug-14 7:32am

ID is just an auto generated pk frm the DB,UpdateID is the user ID of the Person who updated a coment on the web page.

ClimerChinna 27-Aug-14 7:36am

but in your select query you are returning only update_Userid right? then how will you get ID

mampaf 27-Aug-14 7:50am

i dont want ID but updatedID thats y m returning it, i wna take Update_UserID frm the DB and asign it updatedID and UpdatedBy on the web page acording to the person hu loged in

ClimerChinna 27-Aug-14 7:52am

then you need to give index number 0 only

you just use below code in the place of your while loop code,you will get the result

while (rdr.Read())
{
if (!rdr.IsDBNull(0))
{
updateID = rdr.GetString(0);
}
updateID = UpdatedBy;
}

mampaf 27-Aug-14 8:00am

this is what is in the DB
index 0 = ID PK Auto generated
index 1 = updateID
index 2 = confirmID
index 3 = reviewID
index 4 = updatedBy

ClimerChinna 27-Aug-14 8:02am

ofcourse this data is available in your database but the output of your select query is returning only updateid so only one index will be there

ClimerChinna 27-Aug-14 8:05am

do one thing copy your code with below code as it is it will work, accept solution if it works

public string UpdateUserID(string updateID)
{
UpdatedBy = System.Web.HttpContext.Current.Request.LogonUserIdentity.Name.Substring(12);

string sql = "select * from Cwipuser.CWIP_Variances ";
SqlCommand cmd = new SqlCommand(sql, MyCon);
MyCon.Open();
SqlDataReader rdr = cmd.ExecuteReader();

while (rdr.Read())
{
if (!rdr.IsDBNull(1))
{
updateID = rdr.GetString(1);
}
updateID = UpdatedBy;
}
MyCon.Close();
return updateID;
}

mampaf 27-Aug-14 8:15am

ok let me do dat n wil get bek to u,so i just change the select statement?

mampaf 28-Aug-14 2:42am

hi thanks it worked,u r a genius:-)

Sinisa Hajnal 28-Aug-14 7:35am

This is no good,first version is correct, the query returns single parameter and index 0 is correct. Returning * for longer list of fields is unnecessary if they are not used.

mampaf 28-Aug-14 2:46am

thnx i got it, hey is it posible to use a foreach row in datagrid.rows but only for one row?like it should not loop for the whole 5rows,it shud only loop once n stop