i can't loop through a 2d for-loop

Question

2.00/5 (1 vote)

See more:

I am having a trouble looping through a 2d array using a for-loop
my program breaks after doing first comparison and i can't figure out why.
here is my code

C++

    readData();
    sortData();
    
    cout << ID_EMEI[5][1] << endl;

    for (int r=0; r<20; r++)
    {
        if (ID_EMEI[r][0] == ID)
        {
            if(ID_EMEI[r][1] == EMEI)
            {
                 cout << ID_EMEI[index][0] << "-";
                 cout << "Customer found, you can give them their belongings"<<endl;
                 cout <<"please write a short report about the phone" <<endl;
                 cin >>report;
                 
                 Write(ID, EMEI, report);
            }
        }
    }

Posted 30-Aug-14 8:20am

Dirquez Marquez

Updated 30-Aug-14 8:33am

nv3

v2

Add a Solution

Comments

nv3 30-Aug-14 14:36pm

Hard to tell what is going wrong without seeing how the array is declared. So please show also the line, where your array is declared and defined.

Also: Why don't you step through your program in a debugger. That will pretty quickly show you what's going wrong.

Dirquez Marquez 30-Aug-14 14:48pm

array declaration:

int ID_EMEI[20][2];

//hre i am storing data to the array reading from a long string of elements separated by "-"
while(getline(breaker, temp_string, '-')){ ///this is a way for splitting

if(word1.length() < 1)
word1 = temp_string;

else if(word1.length() > 1)
word2 = temp_string;

istringstream(word1) >> ID_EMEI[index][0];
istringstream(word2) >> ID_EMEI[index][1];

index +=1;

}

Stefan_Lang 2-Sep-14 8:46am

Reading this, and combining it with the suggestion and question posed in solution 1:

the last statement here is index+=1
I don't see where index is being initialized or how it's controled to stay in range, but that last statement may well push the index beyond the range of the array, and in the code you posted above you use that index to access the array. Have you checked that code is actually correct? did you mean to use r instead? If not, have you verified index is less than 20?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nv3 · Answer 1 · 2014-08-30T09:07:00

Solution 1

The only line that catches my eye is

C++

cout << ID_EMEI[index][0] << "-";

Why are you using index here instead of r? index might in fact stand one beyond the array after your input loop (which is not shown in your code extract).

Posted 30-Aug-14 9:07am

nv3

v2