How Do I Remove Segmentation Error During Runtime

Question

0.00/5 (No votes)

See more:

I wrote a code to read multiple images at a time i,e p[1].....p[14] .No errors during compilation.
Error i got during run time is "segmentation fault".
code is:

C++

#include<stdio.h>
int main(void)
{
FILE *fp;
int i;
char ch;
for(i=1;i<15;i++)
{
char fn[100];
sprintf(fn,"p[%d].gif",i);
fp=fopen("p[i].gif","rb");
fread(&ch,sizeof(ch),1,fp);
}
}

Posted 1-Sep-14 19:11pm

Member 10952154

Updated 1-Sep-14 19:46pm

CPallini

v2

Add a Solution

Comments

[no name] 2-Sep-14 1:24am

Please explain in words what this code is meant to do because it makes no sense. Crazy code can be often compiled. Have you made any effort to debug this? The debugger will tell you immediately what is going on.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2014-09-01T19:44:00

The first thing to do is introduce some error checking.
Since you use the same file name for every file you read:

C++

fp=fopen("p[i].gif","rb");

And you don't close it, that's going to give an error at some point.
But...what happens if the file doesn't exist? fopen will return a null, you will pass it to fread and you will get a segmentation fault...

You can start by replacing the fixed file name with the result from the sprintf call and that will help - but you do need to check the return value from fopen or you will have more problems later. And close your damn files when you have finished with them!