Can I remove the "redundant initialization" suggested by Resharper in C#?

Question

0.00/5 (No votes)

See more:

.NET3.0

Hi,
Well I m new to Resharper tool, so just unaware how it derives upto certain suggestions.
So, for example, I declare a string variable and initialize it as :

C#

string str=string.empty;// here I get the "Remove redundant initializer

if (true)
{
str="True";
}
else
{
str="false";
}

The reason I m initializing

C#

str=string.empty;

is that because I don't want the compiler to assign any dummy/garbage values to the variable.

Please guide.
Thanks in advance

Now based on Abhinav's comment, I have improved the question with below:
But let us suppose, for instance,if I had only

C#

string str;
if (true)
{
}
else
{
str="false";
}

what value would then be in str??

Posted 6-Dec-14 0:10am

aryan_85

Updated 8-Feb-15 22:15pm

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Accepted Answer · 2014-12-06T00:34:00

Lets understand Redundant Initialization first.

EXPLANATION
This variable's initial value is not used. After initialization, the variable is either assigned another value or goes out of scope.
Example: The following code excerpt assigns to the variable r and then overwrites the value without using it.

int r = getNum();  //Redundant
r = getNewNum(buf);

In your case, after the code runs, the value of str will be either True or False.
So you don't need to worry about garbage values.

Just remove string str=string.empty; and make it string str;

CHill60 · Accepted Answer · 2015-02-08T23:28:00

To answer the 2nd part of your amended question, as TheRealSteveJudge has pointed out the value of str would be null.

More importantly if you then tried to use str after this point you would get an error

Quote:
Error 2 Use of unassigned local variable 'str'

and resharper would not be telling you that a string str = string.empty is redundant.
Basically you should EITHER ensure that str is initialised OR ensure that all the code paths result in a value being assigned to str

Both Visual Studio and Resharper are helping you to both remove code that isn't necessary, and also helping you to find potential errors BEFORE you try to run your program.

Can I remove the "redundant initialization" suggested by Resharper in C#?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0