{"Number of query values and destination fields are not the same."}

Question

0.00/5 (No votes)

See more:

C#

OleDbConnection con = new OleDbConnection(@"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=E:\Messdatabase.mdb");
st = "insert into Member_Datails(Name,Gender,Address,Contactno,Paid_Amount,Count_Remaining,Joining_date) values('" + name + "','" + gender + "','" + address + "','" + ContactNo + "','" + PaidAmount + "','" + SetThali + "','" + "','" + joiningdate + "')";
                    //SqlCommand cmd1 = new SqlCommand(st, con);
                    OleDbCommand cmd = new OleDbCommand(st, con);

                    cmd.ExecuteNonQuery();



want insert only selected field in access database

Posted 17-Jan-15 0:36am

Member 11381744

Add a Solution

3 solutions

Solution 3

use parameterized query, it is more safe and you can avoid issues like incorrect data formats etc..

C#

insert into Member_Datails(Name,Gender,Address,Contactno,Paid_Amount,Count_Remaining,Joining_date) values(?,?,?,?,?,?,?)

change the sql statement as above and set the parameter values as the sequence given in the insert statement

C#

OleDbCommand cmd = new OleDbCommand("insert into Member_Datails(Name,Gender,Address,Contactno,Paid_Amount,Count_Remaining,Joining_date) values(?,?,?,?,?,?,?)", con);
cmd.Parameters.AddWithValue("@Name", name);
cmd.Parameters.AddWithValue("@Gender", gender);
cmd.Parameters.AddWithValue("@Address", address);
cmd.Parameters.AddWithValue("@Contactno", ContactNo );
cmd.Parameters.AddWithValue("@PaidAmount", PaidAmount);
cmd.Parameters.AddWithValue("@Count_Remaining", CountRemaining);
cmd.Parameters.AddWithValue("@Joining_date", joiningdate);
con.Open();
cmd.ExecuteNonQuery();

Posted 17-Jan-15 0:47am

DamithSL

Updated 17-Jan-15 0:54am

v3

Comments

Zoltán Zörgő 17-Jan-15 6:55am

? and @...?

DamithSL 17-Jan-15 6:59am

yes, this is OleDbCommand, please check remarks section of http://msdn.microsoft.com/en-us/library/system.data.oledb.oledbcommand.parameters%28v=vs.110%29.aspx[^]
parameter name does not matter when set the parameter values, need to add parameters in same order in the sql statement

Zoltán Zörgő 17-Jan-15 8:01am

I don't really get the use of names in this case, but you'r right. I skipped OleDb :)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Zoltán Zörgő** · Accepted Answer · 2015-01-17T00:44:00

This is why you should use parametrized queries, and not concat string, which is an overhead in c#. Look here: "','" + "','". Do you see the problem? You have 7 parameters inside the parentheses, and 8 in the values section, because of this one.

Have a good look at this tutorial: https://derekreynolds.wordpress.com/2011/05/16/using-sqlcommand-and-addwithvalue-parameters-to-execute-sql-insert/[^], and rewrite your code before more you get more headacks...

OriginalGriff · Accepted Answer · 2015-01-17T00:45:00

Oh dear...

The error message is pretty explicit:

Number of query values and destination fields are not the same.

So the number of fields you list in teh columns:

SQL

INSERT INTO (col1, col2, col3) ...

Does not match teh number of values you are passing through:

SQL

... VALUES 1,2,3,4

And if you cut out the "packaging" from your query it's pretty obvious:

C#

st = "insert into Member_Datails(Name,Gender,Address,Contactno,Paid_Amount,Count_Remaining,Joining_date) values('name','gender','address','ContactNo','PaidAmount','SetThali','','joiningdate')";

You have 7 columns named, and 8 values.

But...don't do it like that! Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

{"Number of query values and destination fields are not the same."}

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0