error in switch case

Question

1.00/5 (2 votes)

See more:

hi when i write following command:

C#

switch (myparam)
			{
				
				case "p1":
					this.Close();
					break;
				case "p2":
					break;
				case "p3": 
					if (mytag)
					{
						return;
					}
					myprocc1();
					
                    
			}

this error be shown after compile
Error 5 Control cannot fall through from one case label ('case "p3":') to another

thanks

Posted 25-Jan-15 10:55am

armm1388

Updated 25-Jan-15 18:16pm

King Fisher

v2

Add a Solution

Comments

King Fisher 26-Jan-15 0:27am

Add break; for Case 3:

2 solutions

Solution 1

Dude, do you intend to read some book, take some tutorial, use intellisense, read the compiler messages... or something on your own? You are falling into basic syntactical errors... one after an other...

Stop posting on every little mistake you do, and use google at least!

Start HERE[^] for example, and don't you come back until you have finisged it...

Posted 25-Jan-15 11:06am

Zoltán Zörgő

Comments

jaket-cp 26-Jan-15 5:13am

Good advice, but is it a good read?
1000 odd pages to go through :)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2015-01-25T17:34:00

Solution 3

You have simply forgot to add the break into the end of the case "p3". Because of that the execution would fall the the next case. To correct the situation add the break. Like

C#

switch (myparam)
{
   case "p1":
      this.Close();
      break;
   case "p2":
      break;
   case "p3":
      if (mytag)
      {
         return;
      }
      myprocc1();
      break; 
}

But in overall, I agree that you should first check the documentation for the statements you have problem with. This way you get to know the language in overall :)

Posted 25-Jan-15 17:34pm

Wendelius

Comments

King Fisher 26-Jan-15 0:26am

5+ ;)

Wendelius 26-Jan-15 1:14am

Thanks :)

jaket-cp 26-Jan-15 5:12am

My 5 - learnt something new today :)
C# works differently than other language in switch-case fall through (interesting)

Wendelius 26-Jan-15 8:33am

Glad to be of service

BillWoodruff 27-Jan-15 3:38am

+5

Wendelius 5-Feb-15 0:30am

Thanks :)