Strings: PigLatin Program Problems. Help pls.

Question

0.00/5 (No votes)

See more:

#include<iostream>
#include<string>
#include<fstream>
#include<conio.h>
using namespace std;


 
int main(){
string sSentence;
ifstream myfile ("example.txt");
  if (myfile.is_open())
  {
    while ( getline (myfile,sSentence) )
    {
      cout << sSentence << '\n';
    }
    myfile.close();
  }
	else cout << "Unable to open file"; 

int iLen = sSentence.length();
int iBlank = sSentence.find(" ");

        int o=0;       
		string sSen = sSentence.substr(o,iBlank);          
		         
	for(;o<iLen;o++){
		
			if( isalpha(sSentence[o])){ 
			
				int iLength = sSen.length();
				int iVowel = sSen.find_first_of("aeiouAEIOU");
				string adSent = sSen.substr(o,iVowel);
				string addSent = sSen.substr(iVowel,iBlank);
				string pig = addSent+adSent;
				string latin = pig.insert(iBlank,"ay");
				cout << latin;
				
				}
		
			else{
				cout<< sSentence[o];
				}
				
			
				
	} 
	
	
return 0;
}

in this code. im suppose to translate a word to Piglatin.
inside the .txt file the message is:
"i love you"

the program is suppose to print
"iay ovelay ouyay"

so it finds the first vowel in the word then all the letters before the vowel will be transfered to the end of the word then add the letters "ay".

in my program the loop there works only for the first word that it can find.

my problem is i need to move my index to the last letter of the word. so that when I increment the index of the string array. i would get the space and print it. how can I assign o to the location of the last letter of the word?

there is an error if i put

o = iBlank-1;

at the end of the if condition. i need to jump to the next word and find the next blank space in the sentence.

pls help thank you :))

Posted 21-Feb-15 6:40am

Reuben Cabrera

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2015-02-21T07:21:00

It would be better to create a subroutine that accepts a string, converts it to its piglatin form, and return the converted string. Your main function then only needs to split the input string into tokens, and pass each token to the converter in turn. In this way the converter does not need to be concerned about the size of each word, or where it fits in the overall sentence. The key, as always, is to try to break your problem down into small easily managed components, rather than trying to do everything in one serial process.

CPallini · Answer 2 · 2015-02-21T08:06:00

Solution 2

You have three important indices for each word, namely

The starting letter, let's name it start.
The index of the vowel, let's name it vowel
The index of the blank (or of the pass-the-end of the string), let's call it end

Once you realize that the implementation is straightforward:

C++

void piglatin(const string & sSentence)
{
  size_t start, vowel, end;
  start = 0;
  do
  {
    end = sSentence.find(' ', start);
    vowel = sSentence.find_first_of("aeiouAEIOU", start);
    cout << sSentence.substr(vowel, end-vowel) << sSentence.substr(start, vowel-start) << "ay ";
    start = end + 1;
  } while (end != string::npos);
  cout << endl;
}

Posted 21-Feb-15 8:06am

CPallini

Comments

Reuben Cabrera 21-Feb-15 23:55pm

after printing the word i need to find the next word. so i can get the position of the next blank space. so i need to update the value of o so that i skip evaluating all the other letters of the word.

so your function does convert i --> iay but after the execution of the function . the loop must skip the rest of the letters and go directly to the position of blank space. so i can find the next word.

CPallini 22-Feb-15 6:49am

My function transforms 'i love you' into 'iay ovelay ouyay'. This is your requirement, isn't it?

Reuben Cabrera 22-Feb-15 9:56am

ah ok when I used it on my program it didnt change the rest of the word. maybe i place your algo in the wrong place. sorry bout that

Reuben Cabrera 22-Feb-15 9:56am

thanks btw. :)

Reuben Cabrera 22-Feb-15 10:04am

why does your function use const string & sSentence.
why use const string &??

CPallini 22-Feb-15 10:20am

Because is faster. Passing an object (like a std::string instance) by value (like you did) is slower than passing it by reference (using the '&' operator). Adding the 'const' specifier means you are not going to modify the passed object.
Please note the performance difference is irrelevant in such a simple case.

Reuben Cabrera 22-Feb-15 10:16am

what about special characters??? tried putting a ! in the end. maybe evaluating each character must be done first then if in the position it is not a character then print it immediately

CPallini 22-Feb-15 10:21am

My code doesn't handle edge conditions (for instance it fails if a word has no vowels). This is left to you as an exercise. :-)

Reuben Cabrera 22-Feb-15 11:37am

void piglatin(const string &sSentence)
{
size_t start, vowel, end;
start = 0;
do
{
end = sSentence.find(' ', start);
string word;
word = sSentence.substr(start,end);

if(word.find_first_of("aeiouAEIOU")!=string::npos){
vowel = sSentence.find_first_of("aeiouAEIOU", start);
cout << sSentence.substr(vowel, end-vowel) << sSentence.substr(start, vowel-start) << "ay ";
}

else{
cout << word <<"ay";
}
start = end + 1;

} while (end != string::npos);
cout << endl;
}

i tried to modify your algo but can you explain what is wrong in this code. why is it printing so many nonsense after detecting the word with no vowels.

the sentence is "i love by you"

Reuben Cabrera 22-Feb-15 11:38am

it prints
"iay ovelay ouby yay ouyay

Reuben Cabrera 22-Feb-15 11:39am

maybe it still detected a vowel within the string.

Reuben Cabrera 22-Feb-15 11:42am

i changed the sentence to by you.
byay ouyay is printed. it becomes correct???

Reuben Cabrera 22-Feb-15 12:25pm

try printing the end. it goes from 1 , 6 , then it goes 18446744073709551615

it still does change the letters though

Reuben Cabrera 22-Feb-15 12:34pm

void piglatin(const string & sSentence)
{
size_t start, vowel, end;
start = 0;
do
{
end = sSentence.find(' ', start);
vowel = sSentence.find_first_of("aeiouAEIOU", start);

if(vowel!=string::npos)
cout << sSentence.substr(vowel, end-vowel) << sSentence.substr(start, vowel-start) << "ay ";
else
cout<<sSentence.substr(end-1,end)<<sSentence.substr(start)<<"ay";

start = end + 1;
} while (end != string::npos);
cout << endl;
}

why is it extracting love y?
sentence is i love by you