Syntax error in UPDATE statement.visual basic 2008

Question

0.00/5 (No votes)

See more:

VB

connect.Open()
Dim cmd As OleDb.OleDbCommand = New OleDb.OleDbCommand("SELECT * FROM tbluser", connect)
sql = "UPDATE tbluser SET  Username='" & txtusername.Text & "', Password ='" & txtpassword.Text & "' where IDnumber ='" & txtidnumber.Text & "'"
cmd = New OleDb.OleDbCommand(sql, connect)
cmd.ExecuteNonQuery()
connect.Close()
MsgBox("Updated")

Posted 6-Mar-15 21:26pm

Member 11505382

Updated 6-Mar-15 22:18pm

Richard MacCutchan

v2

Add a Solution

Comments

Richard MacCutchan 7-Mar-15 4:20am

Your code is at risk of SQL injection, use proper parameterized queries. You should also check the types of your database fields. You should also never store passwords in clear text. I just hope this is not part of a commercial application.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2015-03-06T22:42:00

Oh dear... :sigh:

Where do I start?
With the SQL Injection? The text based passwords? The redundant code? The outdated functions? Or the implication that this is Web based and you are using message boxes?

They are all problems...and they don't include the problem you have found!

Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^] (It's in C#, but the pronciples are the same. You should also see here: Commitstrip[^] which might help to explain how such behaviour is considered by the real world.

Why do this:

VB

Dim cmd As OleDb.OleDbCommand = New OleDb.OleDbCommand("SELECT * FROM tbluser", connect)

If you are going to immediately do this:

VB

cmd = New OleDb.OleDbCommand(sql, connect)

Why not just create one command?

MsgBox was replaced in 2005 with the more up-to-date MessageBox class and it's Show method. You shouldn't be using the older functions in new code - compatibility only.

VB.NET is web based. Message Boxes are Forms based. If you use a Message Box in a web based system, the client will never see it because it is displayed at the server. It appears to work for development because the two computers are the same physical unit - but in production it fails badly - and convinces your users that your application is rubbish...

Fix that lot, and it's very, very likely that your other problems will just disappear on their own.
Don't fix them, and you are heading for a world of pain...:sigh: