Procedure or function 'Usp_UploadImage1' expects parameter '@Path', which was not supplied

Question

0.00/5 (No votes)

See more:

why path is not passed while variables have correct values stored in them?
how to solve it?

C#

string FilePath;
protected void BtnUpload_Click(object sender, EventArgs e)
        {
            if (FileUpload1.PostedFile != null)
            {
                File_Name = Path.GetFileName(FileUpload1.PostedFile.FileName);
                FileExt = System.IO.Path.GetExtension(FileUpload1.FileName);
                Response.Write(File_Name);
                ss = Server.MapPath("~/Images/");
                FilePath = ss + File_Name;
                
                

                if (FileExt.ToLower() == ".jpg" || FileExt.ToLower() == ".jpeg" || FileExt.ToLower() == ".png" || FileExt.ToLower() == ".gif")
                {
                    FileUpload1.SaveAs(ss + FileUpload1.FileName);
                    Image1.ImageUrl = "~/Images/"+ FileUpload1.FileName;
                }
                else
                {
                    Response.Write("Please Select an Image File..!");
                }
            }
protected void BtnSubmit_Click(object sender, EventArgs e)
        {
                SqlCommand cmd1 = new SqlCommand("Usp_UploadImage1", con);
                cmd1.CommandType = CommandType.StoredProcedure;
                cmd1.Parameters.Add(new SqlParameter("@User_Id", SqlDbType.VarChar, 100));
                cmd1.Parameters["@User_Id"].Value = id;
                cmd1.Parameters.Add(new SqlParameter("@Name", SqlDbType.VarChar, 100));
                cmd1.Parameters["@Name"].Value = TxtImageName.Text.Trim();
                cmd1.Parameters.Add(new SqlParameter("@Descrip", SqlDbType.VarChar, 100));
                cmd1.Parameters["@Descrip"].Value = TxtImageDescription.Text.Trim();
                cmd1.Parameters.Add(new SqlParameter("@Imagecategory_Id", SqlDbType.Int));
                cmd1.Parameters["@Imagecategory_Id"].Value = DrpImageCatagory.SelectedIndex;
                cmd1.Parameters.Add(new SqlParameter("@Date", SqlDbType.DateTime));
                cmd1.Parameters["@Date"].Value = System.DateTime.Now;
                cmd1.Parameters.Add(new SqlParameter("@Path", SqlDbType.VarChar,200));
                cmd1.Parameters["@Path"].Value = FilePath;
                cmd1.Parameters.Add(new SqlParameter("@Status", SqlDbType.Int));
                cmd1.Parameters["@Status"].Value = status;
                cmd1.Parameters.Add(new SqlParameter("@ImageType_Id", SqlDbType.Int));
                cmd1.Parameters["@ImageType_Id"].Value = RadioImageType.SelectedValue;

                int rowcount = cmd1.ExecuteNonQuery();
                con.Close();
                if (rowcount > 0)
                {
                LblStatus.Text = "Data Inserted Successful..!";
                }
       }

Database: (stored procedure)

SQL

Create proc Usp_UploadImage1(@User_Id varchar(100), @Name varchar(50), @Descrip varchar(100), @Imagecategory_Id int, @Date datetime, @Path varchar(max), @Status bit, @ImageType_Id int)
as begin
insert into ImageRepository values(@User_Id, @Name, @Descrip, @Imagecategory_Id, @Date, @Path, @Status, @ImageType_Id)
end

Every thing works fine. but execution gives stated error:
Procedure or function 'Usp_UploadImage1' expects parameter '@Path', which was not supplied

when i debug that, it shows that Filepath1 has correct path
but is was not passed..!! why? and how can i solve it?

Posted 7-Mar-15 1:59am

Satpal Lakhera

Updated 8-Mar-15 21:21pm

v5

Add a Solution

Comments

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Mar-15 8:47am

Can you simply try sending the parameter with some text, but not the file path?

Satpal Lakhera 8-Mar-15 3:45am

i tried with simple sql query, this works but stores only till folder path but not filename with extension.
as
d:\projects\images\
or
~/Images/

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 8-Mar-15 9:42am

That means the file path you are getting from code is not complete. Debug and see what is the file path it is showing in code.

Satpal Lakhera 8-Mar-15 12:56pm

as i told you, at debugging it shows correct value(c:\images\tech.jpg)
but not stored in database correctly. why?

Subramanyam Shankar 7-Mar-15 10:09am

I tried your code it did work fine. Please check once again.

Satpal Lakhera 8-Mar-15 3:49am

when i tried with simple sql query,
SqlCommand cmd = new SqlCommand("Insert into ImageRepository values('" + TxtImageName.Text + "','" + TxtImageDescription.Text + "'," + Image_Catagory + "," + Image_type + ",'" + path + "')", con); (similar).
this works but stores only till folder path
but not filename with extension.
as
d:\projects\images\
or
~/Images/

Satpal Lakhera 8-Mar-15 3:51am

but i want to work with stored procedure.
while working with stored procedure, it shows that parameter to path not supplied.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Modi Mayank · Answer 1 · 2015-03-07T18:25:00

Solution 1

I guess your code works fine as per your code. Now the second possibility is while inserting your data means insert query. Make sure your database schema has same fields in order i.e User_Id, Name, Descrip, Imagecategory_Id, Date, Path, Status, ImageType_Id (possibility of mismatching columns) else change your query by specifying table columns as follows:

SQL

insert into ImageRepository (User_Id, Name, Descrip, Imagecategory_Id, Date, Path, Status, ImageType_Id) values (@User_Id, @Name, @Descrip, @Imagecategory_Id, @Date, @Path, @Status, @ImageType_Id)

Posted 7-Mar-15 18:25pm

Modi Mayank

Updated 7-Mar-15 18:27pm

v2

Comments

Satpal Lakhera 8-Mar-15 3:23am

Error : "Path " variable have Invalid type [SQL SERVER 2012]

Modi Mayank 8-Mar-15 3:24am

can you post your table with schema here and update your question?

Satpal Lakhera 8-Mar-15 3:40am

Create table ImageRepository
(Id int Identity(1,1) primary key,
User_Id varchar(100) foreign key references UserDetails(EmailId),
Name varchar(50),
Descrip varchar(Max),
Imagecategory_Id int foreign key references Imagecategory(Id),
Date datetime,
Path varchar(max),
Status bit,
ImageType_Id int foreign key references ImageType(Id)
)

Modi Mayank 8-Mar-15 3:57am

Looks good, Did you debug code? Have you checked the what value comes in "Path"?

Modi Mayank 8-Mar-15 4:03am

It may be because you declared varchar(max) datatype to @path in your Store Procedure and Database Schema and in your code you had limited to varchar 200 in line cmd1.Parameters.Add(new SqlParameter("@Path", SqlDbType.VarChar,200));. You can give it try by changing this. It might solve your issue, not sure yet.

Satpal Lakhera 8-Mar-15 12:53pm

i debugged it , it stored correct value(full path as c:\images\tech.jpg).
but not passed why?
another thing, i changed path varchar 1000. but problem intact.
it is tedious.

Satpal Lakhera 9-Mar-15 3:09am

got the cause.!!
lolz, it was due scope problem.
we can assign a global variable in local scope (in a function).
but its value will remain only in local scope and will not be seen in global scope.
thats why filepath variable (btnupload_click) shows value at debugging, while its value vanish in database code while passing.

Modi Mayank 9-Mar-15 3:21am

As per your test, last thing comes in my mind is to pass the file path in single quotes as 'c:\images\tech.jpg' so may be as cmd1.Parameters["@Path"].Value = "' + FilePath2 + '";.

Satpal Lakhera 9-Mar-15 3:40am

nopes,
let me tell you that variable Filepath was declared globally.
it was assigned to to address of a uploaded file in local scope of function BtnUpload_Click.
hence its value was something "d:\images\tech.jpg" (something). in local scope of btnUpload_Click function.

when this function terminated. filepath variable value also terminated coz it was assaigned at local scope, so when this local scope is over, its value vanished.

so local scope value didn't appear in global scope.
now global scope has no value in filepath variable.
hence nothing passed at BtnSubmit_Click.

Modi Mayank 9-Mar-15 4:56am

OK, that's great you solved your issue.

Satpal Lakhera 9-Mar-15 5:07am

no, only cause to problem found, not solution !!

how to initialize a variable globally from a local scope?

Satpal Lakhera 9-Mar-15 5:23am

sample:
string path;
function first()
{
string loc = "drive d"; //(suppose this is obtained from user input or by other way)

path = loc; //here value in path is [drive d]
}
function second ()
{
print(path); // here value in path is null.
// i want "drive d" (path value) to appear here which was assigned at function first. how to do that?
}

Modi Mayank 9-Mar-15 5:59am

I think "BtnUpload_Click" event code is only used to validate the file extensions. So, I think there is not need to define that event separately. You can move your "BtnUpload_Click" code to "BtnSubmit_Click" and check it before calling the SP. Refer validating file extensions for more details.

Satpal Lakhera 9-Mar-15 6:44am

ok... thats eyesome..!!
but tell me what to do if i face similar problem as my above comment?

Modi Mayank 9-Mar-15 7:45am

OK, but generally in your case when you call click event it'll resets all the values due to postbacks. So, best think is to do it without postbacks in same event.

The other things you can do is to use ViewState or Session objects to keep values during postbacks. That's it!

Satpal Lakhera 9-Mar-15 8:49am

i reached to hiddenfield and session variables.
for this, viewstate and without postback are good to know about.
thanks a lot buddy.. thanks a lot for being with me till last.
post it as solution

Modi Mayank 9-Mar-15 10:39am

Glad I helped you to solve your problem.

If this answer solved your problem, mark it as answer so other can find out solution for their similar issues.

Satpal Lakhera · Answer 2 · 2015-03-09T05:23:00

Generally when you call click event, it'll resets all the values due to postbacks and thus such problem arise. So, try it without postbacks.

try storing and passing by use of following methods :

hiddenfields
session variable.
viewstate
or try without postback.

Solution using session variable -
in function hold path as:
Session["NewPath"] = Server.MapPath("~/images/") + fileupload1.filename;
Pass in database as:
FilePath = Session["NewPath"].toString(); then pass Filepath in Stored procedures.