getting different results from below two sql commands however output of 1171 rows required. Solution will be appreciated. Thanks in advance.

Question

0.00/5 (No votes)

See more:

SQL

declare @FromDate varchar(20)='01-02-2010',@ToDate varchar(20)='31-12-2012'
set dateformat dmy

1.
select * From View_getReportFullDataDump
where cast(cast(Convert(datetime,[Date of Intimation to Vigilance]) as float) as int) Between cast(Cast(CAST(@FromDate   as datetime) as float) as int) and  cast(Cast(CAST(  @ToDate   as datetime) as float) as int)
Order By CaseUIDNo

output - 1171 rows

2.
execute('select * From View_getReportFullDataDump' +
			' where cast(cast(Convert(datetime,[Date of Intimation to Vigilance]) as float) as int) Between cast(Cast(CAST(' + @FromDate + ' as datetime) as float) as int) and  cast(Cast(CAST(' + @ToDate + ' as datetime) as float) as int)' + 
			 ' Order By CaseUIDNo')

output - 0 rows

Posted 27-Mar-15 2:27am

Sneha Bhushan

Updated 27-Mar-15 2:47am

Herman<T>.Instance

v3

Add a Solution

Comments

Suvendu Shekhar Giri 27-Mar-15 8:46am

Just a suggestion: For parameterised sql queries it's recommended to use sp_executesql instead of execute

Richard Deeming 27-Mar-15 9:12am

Don't store date values as strings; use one of the date types[^] provided by SQL.

And, as the previous commenter said, don't use string concatenation to build a query. Use sp_executesql[^], and pass the parameters as parameters.

CHill60 27-Mar-15 9:13am

If you change that execute to Print you can examine the query that you are trying to run in section 2. Look at the dates - do they look alright to you?

John C Rayan 27-Mar-15 12:28pm

Clearly this query is different from the 1st one.
2.
execute('select * From View_getReportFullDataDump' +
' where cast(cast(Convert(datetime,[Date of Intimation to Vigilance]) as float) as int) Between cast(Cast(CAST(' + @FromDate + ' as datetime) as float) as int) and cast(Cast(CAST(' + @ToDate + ' as datetime) as float) as int)' +
' Order By CaseUIDNo')

@FromDate and @ToDate should be part of the SQL but you are concatenating the values of them rather than the variables as such. Hope you understand what I am saying. If not shout.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Stephen Hewison · Accepted Answer · 2015-03-27T06:58:00

Your concatenated execute doesn't have single quotes for your date strings.

Change

SQL

'cast(Cast(CAST(' + @FromDate + ' as datetime) as float) as int)'

To

SQL

'cast(Cast(CAST(''' + @FromDate + ''' as datetime) as float) as int)'

And repeat for to date

What you're currently trying to execute is:

SQL

cast(Cast(CAST(31-12-2012 as datetime) as float) as int)

I'm surprised you're not getting an error.

But this type of SQL execution is dangerous.

I could potentially use your application to submit this:

SQL

';DELETE FROM ReportData;'

The semi colon would terminate the first part of the statement, which would error, and then it would run my delete command.

This type of attack is known as an SQL Injection attack.

Using sp_ExecuteSQL would allow you to safely pass your parameters into your dynamic SQL.

Info on SQL Injections

https://www.owasp.org/index.php/SQL_Injection[^]

Info on sp_ExecuteSQL vs Execute and using parameters

Building Dynamic SQL In a Stored Procedure[^]