How to fill combobox defined on one page from another form

Question

0.00/5 (No votes)

See more:

Hi I am using singleton pattern (partially) I want to fill combo-box on one form from another form. I am using following code

C#

for (int i = 0; i < dt.Rows.Count; i++)
           {
               if ("cmb.Name" == "cmbServer1")
               {
                   GridWindow.Instance.cmbDatabase1.Items.Add(dt.Rows[i]["database_name"]);
               }

               else
               {
                   GridWindow.Instance.cmbDatabase2.Items.Add(dt.Rows[i]["database_name"]);
               }

But I am not able to fill the combobox,Kindly let me know if you have solution for this

Thanks in advance
Ramesh

Posted 28-Mar-15 5:21am

rameshKumar1717

Updated 28-Mar-15 5:22am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sascha Lefèvre · Answer 1 · 2015-03-28T05:55:00

You don't tell what exactly is going wrong there but I have some suggestions anyway:

Here you compare two constant strings, it will never be true:

C#

if ("cmb.Name" == "cmbServer1")

Probably you meant to do this:

C#

if (cmb.Name == "cmbServer1")

I would advise against hard-coded references to a Form from another Form. It will be no issue in a very small project but if you add more Forms to your project or stick to that "strategy" when doing bigger projects, it will eventually result in a maintenance nightmare. There was recently a new article on this topic published here, take a look: Many Questions Answered at Once — Collaboration between Windows Forms or WPF Windows[^]