Data wrong with not exists

Question

2.00/5 (1 vote)

See more:

SQL-Server-2008R2

hi,
I am trying to compare two tables, I want to select the smartcards that are not in another the other list of smartcards , but the number I get is extremely high , should be around 90 or 120 maximum , but brings me 248k , Table A has 312k records and table B has 478K records , the number of inconsistencies is usually not more than 120 and wanted to know if I'm doing something wrong with my query.

SQL

Select a.SMARTCARD,a.STB,a.AREA,a.ESTATE
From REPORT_CAS a
Where not exists(  select SMARTCARD From REPORT_IW b
                 Where a.smartcard = b.smartcard
                 And a.stb = b.stb)
And a.smartcard  between '1303379968' and '1303969791' 
and len(smartcard) = 10
and ltrim(rtrim(stb)) not in ('0')          
group by a.SMARTCARD,a.STB,a.AREA,a.ESTATE

Posted 17-Apr-15 12:58pm

Laxmax1

Updated 17-Apr-15 13:40pm

PIEBALDconsult

v2

Add a Solution

Comments

PIEBALDconsult 17-Apr-15 19:37pm

Dunno, but avoid subqueries and EXISTS/NOTEXISTS -- try a LEFT OUTER JOIN instead.

Maciej Los 19-Apr-15 14:57pm

Visual Representation of SQL Joins[^]

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Munavvar Husein · Answer 1 · 2015-04-17T20:53:00

Solution 1

You can directly use except clause.

Posted 17-Apr-15 20:53pm

Munavvar Husein

Maciej Los · Answer 2 · 2015-04-19T10:11:00

Solution 2

Please, read comments to the question and follow the link provided there.

Try this:

SQL

SELECT a.SMARTCARD,a.STB,a.AREA,a.ESTATE
FROM REPORT_CAS AS a LEFT OUTER JOIN (
    SELECT SMARTCARD
    FROM REPORT_IW
) AS b ON a.stb = b.stb AND a.smartcard = b.smartcard
WHERE a.smartcard BETWEEN 1303379968 AND 1303969791 AND b.stb IS NULL AND b.smartcard IS NULL

Posted 19-Apr-15 10:11am

Maciej Los

Comments

Laxmax1 20-Apr-15 10:10am

Hi Maciej, with your solucion i have 61k of registers, but still high :(

Maciej Los 20-Apr-15 10:42am

So, you need to check SQL server performance, remove unnecessary table indexes, etc.