How Do I Make The Variables Max And Min Continuously Recognize The Different Inputs Of Num. Instead Of Only Recognizing The Last Input.

Question

2.33/5 (2 votes)

See more:

C#

/**
 * Write a description of class MinimumMaximum here.
 *
 * @author (your name)
 * @version (a version number or a date)
 */
import java.util.Scanner;
public class MinimumMaximum
{

    public MinimumMaximum()
    {
        Scanner number = new Scanner(System.in);
        int min=0, max=0, lcv = 0, num, num1;
        String maxmin;

          while ((lcv < 10) && (lcv >= 0))
        {
            lcv++;
            System.out.print("Please enter a number: ");
            num = number.nextInt();
            max = max(max,num);
        min = min(min,num);
        }










        maxmin= maxmin(max,min);
        System.out.println(maxmin);


    }


    public int max(int max, int num)
    {


        max = 1;




            if (num > max)

            max = num;

           else

           max = max;




    return max;
}

 public int min(int min,int num)
    {



        min = 0;



            if (num < min)
            min = num;

           else if (min > num)
           min = min;

        return min;
    }










    public String maxmin(int max, int min) {
        String maxmin = "The greatest value is " + max + " and the lowest value is "  + min + ".";
        return maxmin;
}

}

Posted 22-Apr-15 7:34am

Member 11190214

Add a Solution

Comments

Member 11190214 22-Apr-15 13:35pm

I'm supposed to enter 10 numbers and then retrieve the largest and smallest numbers using methods. But every time I run the program only the last number entered is recognized as the largest number with no regards to the previous input.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

TorstenH. · Answer 1 · 2015-04-23T01:06:00

Check your variable naming. You messed up there, to much "max" and "min".

You can reference the class variable with "this.".

also you messed up with return values and references: You are passing the "max" by value and then you return that value.
That is too much. Pass back OR assign values:

Java

private void isMax(int num) // no return value
{
  if (num > this.max){
     this.max = num;
  }
}
 
public int min(int min,int num) // with return value
{
  if (num < min){
    return num;
  }
  return min; // default return
}

Please choose one version and rewrite the other.

EDIT:
Passing Information to a Method or a Constructor[^]