How do I find what datareader is open

Question

2.00/5 (1 vote)

See more:

Hi,
I am amending a somebodies code and get a datareader connection is already open error when I run it. There are sqldatareader all over this code. I think I have closed and disposed of all the reader but there is one still open and I cannot find it.
In VB how can I find what is open when I capture the error.

Help

Posted 30-Apr-15 5:57am

Central_IT

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2015-04-30T06:13:00

Solution 2

You can't. You're going to have to do a code review to find it. There is nothing that's going to tell you where in the code a DataReader is open at any point in time.

Posted 30-Apr-15 6:13am

Dave Kreskowiak

OriginalGriff · Answer 2 · 2015-04-30T06:13:00

Not sure you can - because the DataReader doesn't associate itself with any particular method name or even variable name I can't see a way you can "track back" from your code in potentially a different assembly to the actual SqlDataReader object.

However, it is on the same SqlConnection - or you wouldn't get the message - so you could just close the connection and reopen it, which would "kill" the datareader. If it's really being used, you should homefully notice that cause problems elsewhere in the code.

What you are saying implies that a connection is opened and left open for the life of your app, and that SqlCommand / SqlDataReader objects aren't being Disposed at all. That's poor design, and tends to give problems in production because they are scarce resources and shouldn't be held. I'd start by "wrapping" your existing DB code in using blocks to force the close and dispose you should have already. And if the code is that bad, I'd also start looking very closely at SqlCommand objects as well: chances are they are built by string concatenation, which is very, very dangerous!