Object reference not set to an instance of an object

Question

0.00/5 (No votes)

See more:

i have an error for Object reference not set to an instance of an object
the code are

C#

public class AccountController : Controller
{
    private IUserProfileService userProfileService;
    private UserManager<applicationuser> UserManager;

    public AccountController(IUserProfileService userProfileService, UserManager<applicationuser> userManager)
    {
        this.userProfileService = userProfileService;
        this.UserManager = userManager;
    }
    public AccountController()
    {

    }
    
    [AllowAnonymous]
    public ActionResult Register()
    {
        return View();
    }
    
    [HttpPost]
    [AllowAnonymous]
    [ValidateAntiForgeryToken]
    public async Task<actionresult> Register(RegisterViewModel model)
    {
        if (ModelState.IsValid)
        {
            
            var user = new ApplicationUser() { UserName = model.UserName };
            var result = await UserManager.CreateAsync(user, model.Password);

            if (result.Succeeded)
            {
                var userId = user.Id;
                var userName = user.UserName;
                userProfileService.CreateUserProfile(userId);
                //await SignInAsync(user, isPersistent: false);

                return RedirectToAction("Index", "Account");
            }
            else
            {
                AddErrors(result);
            }
        }

        return View(model);
    }

Posted 26-May-15 21:06pm

C. Nakul

Updated 26-May-15 21:35pm

Tomas Takac

v2

Add a Solution

2 solutions

Solution 1

We can't tell you how to fix this: we don;t have access to your code or data to run it in the same way as you do, so we can't look at what is happening while your code is executing.

So start with the debugger. Whichever method is throwing the exception, put a breakpoint at the top, and step through the code line by line, looking at the values of your variables as you go. For each line, before you execute it look at the code and variables carefully - you are looking for a variable which contains null and has a '.' to its right. When you find it, that's probably where the problem is showing up.

Why it's null is then down to you - generally these problems are as a result of a mistake you made earlier in your code which meant that no value was assigned to something. But we can't find it for you!

Posted 26-May-15 22:02pm

OriginalGriff

Comments

Abhipal Singh 27-May-15 4:19am

5ed! Agree

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhipal Singh · Accepted Answer · 2015-05-26T22:08:00

You need to tell us the description of the issue you are facing. You need to help us to help you out. Following is the reason I could figure out just by reading the code.

The code you gave will throw this error because the default constructor never initializes UserManager object. Also, it is possible that someone can assign null to your parameterized constructor.

I would suggest you to either initialize your UserManager in default constructor as:

C#

public AccountController()
{
  UserManager = new UserManager<applicationuser>();
}

Or add a null check:

C#

if(UserManager !=null)
{
  var result = await UserManager.CreateAsync(user, model.Password);

            if (result.Succeeded)
            {
                var userId = user.Id;
                var userName = user.UserName;
                userProfileService.CreateUserProfile(userId);
                //await SignInAsync(user, isPersistent: false);

                return RedirectToAction("Index", "Account");
            }
            else
            {
                AddErrors(result);
            }
}

Take the approach which suits your design.