Welcome to the Lounge

Brady Kelly wrote:

I prefer

if (something) DoAB();

for the latter. I never use it, but have recently come across it. It seems more readable to me.

if (something)
  DoA();
  DoB();

if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
    goto fail;
if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
    goto fail;
    goto fail;
if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
    goto fail;

if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
  goto fail;

if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
  goto fail;
  goto fail; // why the hell there's a line of code here? It is not important what it does, it looks wrong.

if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
  goto fail;

if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
{
  goto fail;
}

if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
{
  goto fail;
}
  goto fail; // Doesn't this look wrong?

if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
{
  goto fail;
}

if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
{
  goto fail;
}

if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
{
  goto fail;
} // Oh, it looks like an else is missing...
{
  goto fail;
}

if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
{
  goto fail;
}

// So the code gets corrected to...
if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
{
  goto fail;
}

if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
{
  goto fail;
}
else
{
  goto fail;
}

if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
{
  goto fail;
}

Paulo Zemek wrote:

I agree with you. And I am actually the kind of person that when has to modify something like:   C# if (something) { DoA(); DoB(); }   To only call a DoAB(), I will go there and kill the extra { and }. So, I have more work doing that, but I keep consistency.   So, it becomes: C# if (something) DoAB();

if (condition)
{
    this.DoThis();
}
else
{
    this.DoThat();
}

public class SanderRossel : Lazy<Person>
{
   public void DoWork()
   {
      throw new NotSupportedException();
   }
}

if 
(
  condition
)
{ 
  this
  .
  DoThis
  (
  )
  ;
}
else
{
  this
  .
  DoThat
  (
  )
  ;
}

if (condition) { this.DoThis(); } else { this.DoThat(); }

Ian Shlasko wrote:

It's not properly formatted until there's only one token per line in the entire application.

public class SanderRossel : Lazy<Person>
{
   public void DoWork()
   {
      throw new NotSupportedException();
   }
}

PIEBALDconsult wrote:

Quite. The maturity of a programming language may (in part) be calculated by how many newlines are required. A proper language requires none.