Re: A2WBSTR - C / C++ / MFC Discussion Boards

James R. Twine3-Apr-08 4:54

3-Apr-08 4:54

   Yes, AFAIK, BSTRs were (and are) always wide-character strings.

   Perhaps the reason they did this was to specify the encoding of the characters in the BSTR? Likely not, but just a guess.

   Of course, you could always just look at how those macros/functions are implemented to try and find differences! Smile | :)

Peace!

-=- James
Please rate this message - let me know if I helped or not!<hr></hr>If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
See DeleteFXPFiles

Re: A2WBSTR

George_George3-Apr-08 21:29

George_George

3-Apr-08 21:29

Thanks James,

I have found out and write my conclusions here, any comments?

http://www.codeproject.com/script/Forums/View.aspx?fid=1647&msg=2493091[^]

regards,
George

Re: A2WBSTR

CPallini3-Apr-08 5:47

CPallini

3-Apr-08 5:47

On my system, provided _ATL_EX_CONVERSION_MACROS_ONLY symbol is not defined, they are the same

#if defined(_UNICODE)
// in these cases the default (TCHAR) is the same as OLECHAR
	inline BSTR T2BSTR_EX(__in_opt LPCTSTR lp) {return ::SysAllocString(lp);}
	inline BSTR A2BSTR_EX(__in_opt LPCSTR lp) {return A2WBSTR(lp);}
	inline BSTR W2BSTR_EX(__in_opt LPCWSTR lp) {return ::SysAllocString(lp);}

#ifndef _ATL_EX_CONVERSION_MACROS_ONLY

	inline BSTR T2BSTR(__in_opt LPCTSTR lp) {return ::SysAllocString(lp);}
	inline BSTR A2BSTR(__in_opt LPCSTR lp) {return A2WBSTR(lp);}
	inline BSTR W2BSTR(__in_opt LPCWSTR lp) {return ::SysAllocString(lp);}
	
#endif	// _ATL_EX_CONVERSION_MACROS_ONLY

#else // !defined(_UNICODE)
	inline BSTR T2BSTR_EX(__in_opt LPCTSTR lp) {return A2WBSTR(lp);}
	inline BSTR A2BSTR_EX(__in_opt LPCSTR lp) {return A2WBSTR(lp);}
	inline BSTR W2BSTR_EX(__in_opt LPCWSTR lp) {return ::SysAllocString(lp);}
	
#ifndef _ATL_EX_CONVERSION_MACROS_ONLY

	inline BSTR T2BSTR(__in_opt LPCTSTR lp) {return A2WBSTR(lp);}
	inline BSTR A2BSTR(__in_opt LPCSTR lp) {return A2WBSTR(lp);}
	inline BSTR W2BSTR(__in_opt LPCWSTR lp) {return ::SysAllocString(lp);}

#endif	// _ATL_EX_CONVERSION_MACROS_ONLY

#endif // defined(_UNICODE)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

Re: A2WBSTR

George_George3-Apr-08 21:27

George_George

3-Apr-08 21:27

Hi CPallini,

After checking implementation in my system (MSVC 2008), my conclusion,

A2BSTR is for null terminated string input, and A2WBSTR can be non-null terminated and assign an additional length field.

Correct?

// atlconv.h

_Check_return_ inline BSTR A2WBSTR(_In_opt_ LPCSTR lp, int nLen = -1)
{
	if (lp == NULL || nLen == 0)
		return NULL;
	USES_CONVERSION_EX;
	BSTR str = NULL;
#pragma warning(push)
#pragma warning(disable: 6385)
	int nConvertedLen = MultiByteToWideChar(_acp_ex, 0, lp,
		nLen, NULL, NULL);
#pragma warning(pop)
	int nAllocLen = nConvertedLen;
	if (nLen == -1)
		nAllocLen -= 1;  // Don't allocate terminating '\0'
	str = ::SysAllocStringLen(NULL, nAllocLen);

	if (str != NULL)
	{
		int nResult;
		nResult = MultiByteToWideChar(_acp_ex, 0, lp, nLen, str, nConvertedLen);
		ATLASSERT(nResult == nConvertedLen);
		if(nResult != nConvertedLen)
		{
			SysFreeString(str);
			return NULL;
		}

	}
	return str;
}

regards,
George

Re: A2WBSTR

CPallini3-Apr-08 22:38

CPallini

3-Apr-08 22:38

I don't know, because you did not post the A2BSTR definition (in your MSSVC 2008).
Smile | :)

Re: A2WBSTR

George_George3-Apr-08 23:04

George_George

3-Apr-08 23:04

Here it is, CPallini.

Do you think my previous analysis is correct? Smile | :)

inline BSTR A2BSTR(_In_opt_ LPCSTR lp) {return A2WBSTR(lp);}

regards,
George

Re: A2WBSTR

CPallini3-Apr-08 23:15

CPallini

3-Apr-08 23:15

You analysis is wrong.
A2BSTR do no more and no less then calling A2WBSTR, i.e. their effect is identical (there is even no difference in involved stack levels, since A2BSTR it is declared inline).

BTW all BSTR must have a length field (this is the reason why you typically call SysAllocString to alloc a BSTR rather than doing it directly).
Smile | :)

Re: A2WBSTR

George_George3-Apr-08 23:18

George_George

3-Apr-08 23:18

Thanks CPallini,

CPallini wrote:
A2BSTR do no more and no less then calling A2WBSTR, i.e. their effect is identical

I do not agree with you. I think for A2WBSTR you can specify the 2nd argument, which is the length of the ANSI string input, but for A2BSTR, you can not, you can only use the implicit default parameter -1.

Agree? Any comments?

regards,
George

Re: A2WBSTR

CPallini3-Apr-08 23:29

CPallini

3-Apr-08 23:29

You're right (and I'm blind Blush | :O

).
A2WBSTR seems more flexible: you may convert only a chunk of the original ANSI string.
Smile | :)

Re: A2WBSTR

George_George3-Apr-08 23:32

George_George

3-Apr-08 23:32

Thanks CPallini,

Question answered.

regards,
George

esoteric use of the "new" keyword

Dave Calkins3-Apr-08 4:12

Dave Calkins

3-Apr-08 4:12

I came across this use of the "new" keyword in a library recently. I had to look it up to see what was going on. Apparently its valid, I've just never seen it before in any code examples, books, articles, etc.

If you write a custom new operator, you can write it to take an extra argument. When callers use the new keyword they supply an additional argument which gets passed to the new operator.

So you can call

MyClass* instance = new 128 MyClass;

This creates an instance of MyClass as expected but when invoking the custom new operator passes along the argument 128.

Anyway, I'm just curious if anyone else has seen or used this. It caught me off guard.

Re: esoteric use of the "new" keyword

James R. Twine3-Apr-08 4:51

James R. Twine

3-Apr-08 4:51

   Have not seen it done like that before, but I could see it being used for things like allocating additional memory at the end of the object. Remember how variable-length structures like DDEDATA, PDH_COUNTER_INFO and some device driver ones worked?

   Also for custom heap management - I want this object on this heap and that object created on on that heap, or created in a pre-reserved (shared?) block of memory.

   Peace!

Re: esoteric use of the "new" keyword

David Crow3-Apr-08 4:56

David Crow

3-Apr-08 4:56

Dave Calkins wrote:
Anyway, I'm just curious if anyone else has seen or used this. It caught me off guard.

Placement new, perhaps?

"Love people and use things, not love things and use people." - Unknown

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: esoteric use of the "new" keyword

James R. Twine3-Apr-08 5:05

James R. Twine

3-Apr-08 5:05

Placement new required the use of parenthesis:

new (value) Type

Although now that I think about it, you may be correct. I think that placement new is the only way to pass parameters to new...?

Peace!

Re: esoteric use of the "new" keyword

Cedric Moonen3-Apr-08 5:10

Cedric Moonen

3-Apr-08 5:10

James R. Twine wrote:
I think that placement new is the only way to pass parameters to new...?

AFAIK, you can override the new operator. I think that's what is done for the MFC: the file and line are passed to the new operator in order to track memory leaks easier.

Cédric Moonen
Software developer

Charting control [v1.3]

Re: esoteric use of the "new" keyword

James R. Twine3-Apr-08 5:41

James R. Twine

3-Apr-08 5:41

Yep - yer right...

Re: esoteric use of the "new" keyword

Mark Salsbery3-Apr-08 6:10

Mark Salsbery

3-Apr-08 6:10

Cedric Moonen wrote:
AFAIK, you can override the new operator. I think that's what is done for the MFC

GDI+ does it too Smile | :)

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

Re: esoteric use of the "new" keyword

Dave Calkins3-Apr-08 11:18

Dave Calkins

3-Apr-08 11:18

Correct. As I said, I had to look it up to see what was going on and discovered placement new in the docs. My point was just that I'd never seen this used in code before and was curious if anyone else had. It just seems a bit esoteric Smile | :)

RegCreateKeyEx failed in Vista

dharani3-Apr-08 2:52

dharani

3-Apr-08 2:52

Hi all
I am facing a strange issue. I call RegCreateKeyEx to create a key in the Vista registry , but it fails . Could any one please help me find out what I am missing ...?

HKEY hk=NULL;

char tmp_Path[256] = "Software\\Company\\PreferredNos\\no_device";

dwResult = RegCreateKeyEx(HKEY_LOCAL_MACHINE,
tmp_Path,
0,
NULL,
REG_OPTION_NON_VOLATILE,
KEY_ALL_ACCESS,
NULL,
&hk,
NULL) ;
if(hk!=NULL)
RegCloseKey(hk);
if ( dwResult != ERROR_SUCCESS )
{

SpiDebug ((DBG_INFO , _T("TSP"), _T(" RegCreateKeyExFAILED")))
}

redindian

Re: RegCreateKeyEx failed in Vista

Rajesh R Subramanian3-Apr-08 3:02

Rajesh R Subramanian

3-Apr-08 3:02

Did you check the return value?

Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->Rajesh<-·´¯`·.
Codeproject.com: Visual C++ MVP

Re: RegCreateKeyEx failed in Vista

Cedric Moonen3-Apr-08 3:14

Cedric Moonen

3-Apr-08 3:14

Do you have the correct access rights ?

Cédric Moonen
Software developer

Charting control [v1.3]

Re: RegCreateKeyEx failed in Vista

David Crow3-Apr-08 3:18

David Crow

3-Apr-08 3:18

dharani wrote:
I call RegCreateKeyEx to create a key in the Vista registry , but it fails .

Straight from the docs:

If the function fails, the return value is a nonzero error code defined in Winerror.h. You can use the FormatMessage function with the FORMAT_MESSAGE_FROM_SYSTEM flag to get a generic description of the error.

"Love people and use things, not love things and use people." - Unknown

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: RegCreateKeyEx failed in Vista

James R. Twine3-Apr-08 5:43

James R. Twine

3-Apr-08 5:43

dharani wrote:
KEY_ALL_ACCESS

Never do that - only request the access levels that you really need.

Peace!

Re: RegCreateKeyEx failed in Vista

Hamid_RT7-Apr-08 4:26

Hamid_RT

7-Apr-08 4:26

What was return value of dwResult ?

error C2664: '_access' : cannot convert parameter 1 from 'TCHAR [260]' to 'const char *'

neha.agarwal273-Apr-08 2:03

neha.agarwal27

3-Apr-08 2:03

Hi all,

Actually i want to find out that particular path exist or not, for that i am using _accessApi. like this

TCHAR CurrentPath [ MAX_PATH ] ;
GetTempPath(MAX_PATH, CurrentPath);
_tcscat(CurrentPath,_T("$insert\\new folder"));

_access(CurrentPath,NULL);

but compiler is giving this error

error C2664: '_access' : cannot convert parameter 1 from 'TCHAR [260]' to 'const char *'

how could i remove this

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.