.NET (Core and Framework)

Imports System.IO
Imports System.DirectoryServices
Imports System.Data


Module Module1

    Public dsCSIDir As New DataSet("CSIDIR")
    Public Users_Table As New DataTable
    Public drUser As DataRow

    Sub ImportUsers()
        Dim direntry As New DirectoryEntry("LDAP://OU=CSI Users, DC=csileasing, DC=com")
        Dim searcher As New DirectorySearcher(direntry)

        Dim i As Integer = 0
        Dim result As SearchResult
        Console.WriteLine("Started Data Import at :  " & TimeOfDay)
        Try
            searcher.Filter = "(&(objectClass=user)(samaccountname=*))"
            searcher.ClientTimeout = TimeSpan.FromSeconds(5)

            For Each result In searcher.FindAll
                If result.Properties("samaccountname")(0) = Nothing Then
                    Continue For
                End If

                drUser = Users_Table.NewRow

                drUser("index") = i

                If result.Properties.Contains("company") Then
                    drUser("Company") = result.GetDirectoryEntry.Properties("company").Value
                Else
                    Continue For
                End If

                drUser("LoginID") = result.GetDirectoryEntry.Properties("samaccountname").Value
                drUser("DisplayName") = result.GetDirectoryEntry.Properties("cn").Value

                If result.Properties.Contains("title") Then
                    drUser("Title") = result.GetDirectoryEntry.Properties("title").Value
                End If

                If result.Properties.Contains("telephoneNumber") Then
                    drUser("OfficePhone") = result.GetDirectoryEntry.Properties("telephoneNumber").Value
                End If

                If result.Properties.Contains("mobile") Then
                    drUser("CellPhone") = result.GetDirectoryEntry.Properties("mobile").Value
                End If

                If result.Properties.Contains("mail") Then
                    drUser("Email") = result.GetDirectoryEntry.Properties("mail").Value
                End If

                If result.Properties.Contains("streetAddress") Then
                    drUser("Street") = result.GetDirectoryEntry.Properties("streetAddress").Value
                End If

                If result.Properties.Contains("l") Then
                    drUser("City") = result.GetDirectoryEntry.Properties("l").Value
                End If

                If result.Properties.Contains("st") Then
                    drUser("State") = result.GetDirectoryEntry.Properties("st").Value
                End If

                If result.Properties.Contains("postalCode") Then
                    drUser("PostalCode") = result.GetDirectoryEntry.Properties("postalCode").Value
                End If

                If result.Properties.Contains("memberof") Then
                    Dim groups As DirectoryServices.ResultPropertyValueCollection = result.Properties.Item("MemberOf")
                    Dim groupslist As String = ""
                    Dim groupname As String = ""
                    For k As Int16 = 0 To groups.Count - 1
                        Dim fullname As String = result.Properties("memberof").Item(k).ToString
                        groupname = Left(Split(fullname, "=")(1), Len(Split(fullname, "=")(1)) - 3)
                        groupslist = groupslist & groupname & ","
                    Next
                    groupslist = Left(groupslist, Len(groupslist) - 1)
                    drUser("Groups") = groupslist
                End If

                If result.Properties.Contains("manager") Then
                    Dim managername As String() = Split(result.Properties("manager")(0), ",")
                    drUser("Manager") = Right(managername(0), Len(managername(0)) - 3)
                End If

                If result.Properties.Contains("sn") Then
                    drUser("FirstName") = result.GetDirectoryEntry.Properties("sn").Value
                End If

                If result.Properties.Contains("givenname") Then
                    drUser("LastName") = result.GetDirectoryEntry.Properties("givenname").Value
                End If

                If result.Properties.Contains("directReports") Then
                    Dim groups As DirectoryServices.ResultPropertyValueCollection = result.Properties.Item("directReports")
                    Dim groupslist As String = ""
                    Dim groupname As String = ""
                    For k As Int16 = 0 To groups.Count - 1
                        Dim fullname As String = result.Properties("directReports").Item(k).ToString
                        groupname = Left(Split(fullname, "=")(1), Len(Split(fullname, "=")(1)) - 3)
                        groupslist = groupslist & groupname & ","
                    Next
                    groupslist = Left(groupslist, Len(groupslist) - 1)
                    drUser("DirectReports") = groupslist
                End If

                If result.Properties.Contains("department") Then
                    drUser("Department") = result.GetDirectoryEntry.Properties("department").Value
                End If
                i += 1
                Users_Table.Rows.Add(drUser)
            Next
        Catch ex As Exception

        End Try
        Users_Table.AcceptChanges()
        dsCSIDir.Tables.Add(Users_Table)
    End Sub

    Public Sub CreateDataStructure()
        Users_Table.TableName = "Users"
        Console.WriteLine("Start of Create Columns at:  " & TimeOfDay)
        Users_Table.Columns.Add("index", GetType(Integer))
        Users_Table.Columns.Add("LoginID", GetType(String))
        Users_Table.Columns.Add("FirstName", GetType(String))
        Users_Table.Columns.Add("LastName", GetType(String))
        Users_Table.Columns.Add("DisplayName", GetType(String))
        Users_Table.Columns.Add("Title", GetType(String))
        Users_Table.Columns.Add("Company", GetType(String))
        Users_Table.Columns.Add("Email", GetType(String))
        Users_Table.Columns.Add("OfficePhone", GetType(String))
        Users_Table.Columns.Add("CellPhone", GetType(String))
        Users_Table.Columns.Add("Street", GetType(String))
        Users_Table.Columns.Add("City", GetType(String))
        Users_Table.Columns.Add("State", GetType(String))
        Users_Table.Columns.Add("PostalCode", GetType(String))
        Users_Table.Columns.Add("Manager", GetType(String))
        Users_Table.Columns.Add("Department", GetType(String))
        Users_Table.Columns.Add("Groups", GetType(String))
        Users_Table.Columns.Add("DirectReports", GetType(String))
        Console.WriteLine("End of Create Columns at:  " & TimeOfDay)
    End Sub

Ian McCaul wrote:

An array will work just fine for what youre trying to do. Datasets and Datatables will add a lot more overhead and processing then what is required for what you are trying to do. There isnt anything wrong with what you are trying to do but again datatables and especially datasets will take more resources.

glumlord wrote:

Processor - While storing to the Datatable the processor is at 15-30%

glumlord wrote:

Memory - Even after flushing the memory using a class I have my application is taking 6MB now instead of roughly 800k-1024k it was before.

Dave Kreskowiak wrote:

Memory as measured by what?? Please don't tell me you used TaskManager! It's kind of lying to you when it comes to .NET apps. You really have to understand what TaskManager is looking at. If you want more accurate numbers of what your APPLICATION is using, use Performance Monitor and the .NET Memory counters.

Public Class MemoryManagement<br />
<br />
    Private Declare Function SetProcessWorkingSetSize Lib "kernel32.dll" ( _<br />
      ByVal process As IntPtr, _<br />
      ByVal minimumWorkingSetSize As Integer, _<br />
      ByVal maximumWorkingSetSize As Integer) As Integer<br />
<br />
    Public Shared Sub FlushMemory()<br />
        GC.Collect()<br />
        GC.WaitForPendingFinalizers()<br />
        If (Environment.OSVersion.Platform = PlatformID.Win32NT) Then<br />
            SetProcessWorkingSetSize(Process.GetCurrentProcess().Handle, -1, -1)<br />
        End If<br />
    End Sub<br />
<br />
End Class

Dave Kreskowiak wrote:

glumlord wrote:
Processor - While storing to the Datatable the processor is at 15-30%

30%?? Who cares??

Dave Kreskowiak wrote:

The DataTable class has quite a large overhead compared to an Array. So, if an array works for you, great! If not, you may want to look into a Generic collection solution.

glumlord wrote:

I do use Task Manager and I added all the columns that refer to Memory. I compared that to the previous version of my application using Arrays. It may not be accurate completely but I would beg to differ if you think it's useless

Dave Kreskowiak wrote:

30%?? Who cares??

Luc Pattyn wrote:

it only took 2 seconds; so everything exceeding that needs scrutinized.

Dave Kreskowiak wrote:

I wonder about his users! If they're complaining that it takes 2 seconds longer to get a Desktop they can use, they really need professional mental help!

Where I work, it can take upwards of 10 minutes (worst case) to get into a machine on the first login! My laptop takes 5 minutes to get to the point where I can use it! 23 seconds is nothing...