Change the clicked button text to button clicked! With for loop

Question

0.00/5 (No votes)

See more:

I have 10 buttons. I want refer to it by TagName.
With getelementsByTagName, I have got a button collection. I go through with for loop and want that when I click on a button change the textContent to Button Clicked!

But the code changed only the last element to Button Clicked!

What I have tried:

HTML

<pre><!DOCTYPE html>
<html>
<head>
    <meta charset='utf-8'>
    <meta http-equiv='X-UA-Compatible' content='IE=edge'>
    <title>Page Title</title>
    <meta name='viewport' content='width=device-width, initial-scale=1'>
    <link rel='stylesheet' type='text/css' media='screen' href='main.css'>
    <script src='main.js'></script>
</head>
<body>
    <button class="gomb">1</button>
    <button class="gomb">2</button>
    <button class="gomb">3</button>
    <button class="gomb">4</button>
    <button class="gomb">5</button>
    <button class="gomb">6</button>
    <button class="gomb">7</button>
    <button class="gomb">8</button>
    <button class="gomb">9</button>
    <button class="gomb">10</button>

    <script>
        const gombok=document.getElementsByTagName('button')

        for(i=0;i<gombok.length;i++){
            x=gombok[i]
            x.onclick=function(){
                myFunction(x)
            }
        }
        function myFunction(btn){
            btn.textContent='Button Clicked!'
        }
    </script>
</body>
</html>

Posted 21-Jul-22 0:59am

folza

Updated 21-Jul-22 1:58am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mike Hankey · Accepted Answer · 2022-07-21T01:58:00

Solution 1

check out the addEventListener[^]

Posted 21-Jul-22 1:58am

Mike Hankey

Updated 21-Jul-22 2:34am

v2

Comments

folza 21-Jul-22 8:10am

Does not work Mike. How to modify the code to change the content of the clicked button?

Mike Hankey 21-Jul-22 8:22am

This worked for me just fine.

var btns = document.getElementsByTagName('button');
for (i = 0; i < btns.length; i++) {
btns[i].addEventListener('click', function () {
this.textContent='Clicked';
});
}

folza 21-Jul-22 8:37am

the solution is to declare x with const or let in the for loop