Problem with Date and Time as String

Question

0.00/5 (No votes)

See more:

Hi I have two MySql tables. The link to first table from next table is Date and time as string.

C#

//Compute date and time to store in database
string Datetime = DateTime.Now.Date.ToString("yyyyMMdd") +
                         DateTime.Now.Hour.ToString() +
                         DateTime.Now.Minute.ToString() +
                         DateTime.Now.Second.ToString();

While the button clicked the datetime is computed and stored as string.

The problem is sometimes
the datetime stored as

first table  - 2010-12-14 12:09:31 &
second table - 2010-12-14 12:9:31

ZERO before 9 is absent in the second table.

While comparing tables date and time it never be true.
I don't know why this problem happening.
Please help me to solve this.

Thanks in Advance,
Saranya1388

[edit]code blocks added, "Ignore HTML" option disabled - OriginalGriff[/edit]

Posted 3-Jan-11 23:00pm

SwaxRak

Updated 3-Jan-11 23:10pm

OriginalGriff

v2

Add a Solution

3 solutions

Solution 2

Rather convert the date as follow.

string strDateTime = DateTime.Now.ToString("yyyyMMddHHmmss");

Regards

Posted 3-Jan-11 23:06pm

Bardy85

Comments

Bardy85 4-Jan-11 5:18am

Then I would suggest you use JerryKid example ToString("yyyy-MM-dd HH:mm:ss"), as this will always be formatted the same.

Regards

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-01-03T23:08:00

Solution 3

Don't do it.
Store dates in the DB as DateTime, and use SQlCommand.Parameters.AddWithValue to add the DateTime.Now directly, rather than converting it to a string in the first place.

Additionally:
Don't do the convert like that anyway!
1) When dealing with DateTime.Now, get a single instance and work from that. Each time you get DateTime.Now, you get the current date and time - this can lead to odd bugs near midnight and especially near Jan 1st!

DateTime now = DateTime.Now;
string s = now.ToString("yyyyMMdd");
...

2) Don't do the conversion in multiple lines. If you use a single DateTime.ToString it will be more efficient, and work better as you will have better control over the string produced. There is a full list of ToString formats here: Formatting a DateTime for display - format string description[^] which should help.

If you change as suggested, your problem will disappear.

Posted 3-Jan-11 23:08pm

OriginalGriff

Comments

Bardy85 4-Jan-11 5:15am

Hi OriginalGriff,

I agree with your first part about rather using DateTime in Database, but I don't agree with your second suggestion. What odd bugs do you get around midnight or around Jan 1st?

Regards

jerrykid 4-Jan-11 5:19am

I agree with you, OriginalGriff,
And there is no need to create two line to store variable now & s

OriginalGriff 4-Jan-11 5:22am

Bardy85: Think about it. If you do DateTime.Now and use the date part, then DateTime.Now and use the time part, what happens if the two reads are in different days? :laugh:
Can create data bugs that very hard to work out!

Bardy85 4-Jan-11 5:28am

OriginalGriff: I see what you are worried about.
That nearly impossible though, cause that statement is excuted within a few nano seconds.
I think jerryKid conversion would be his best bet, if it's already in that format.

OriginalGriff 4-Jan-11 5:31am

Bardy85: "That nearly impossible" :laugh: that's why you should code to avoid it - it's a real pain to track down what happened when all you have is what looks like corrupt data. Debugging an intermittent fault like that can take forever!

Bardy85 4-Jan-11 5:43am

OriginalGriff: Now that I think about it, having multiple DateTime.Now wouldn't cause a problem at all. The worst case would be that your "second" would be off by one second from when the variable was actually created, and if he's using the same variable dateTime for both table's I don't see it causing a problem. I think we getting a bit off topic from what the actually problem was. :)

jerrykid 4-Jan-11 5:51am

Be cool, men :)

jerrykid · Accepted Answer · 2011-01-03T23:05:00

Solution 1

please try:

string Datetime = DateTime.Now.ToString("yyyy-MM-dd HH:mm:ss")

Posted 3-Jan-11 23:05pm

jerrykid