Problem in javascript

Question

0.00/5 (No votes)

See more:

Hi Experts

I had a javascript function. I am calling the function in a button click.
Its working fine. But the issue is i am getting the return value as false from the script. After getting false my button click event is getting firing. How to avoid this. Why it is happening.

Rgds
Jagadesh

Posted 13-Jun-13 22:10pm

Kumar from madras

Add a Solution

Comments

Prasad_Kulkarni 14-Jun-13 4:13am

Can you post your code snippets?

Kumar from madras 14-Jun-13 4:18am

Hi Prasad

Hope you understood my Question. I Pasted my Javascript.

<script src = 'Scripts/jquery-1.10.1.min.js' type ="text/javascript"></script>

<script type = "text/javascript">
function validatebutton1(txtusrname, txtpassword)

{
var txtusr = document.getElementById(txtusrname).value;
var txtpassw = document.getElementById(txtpassword).value;

if (txtusr == "") {
if (txtpassw == "") {

alert("Please Enter the userid and password");
document.getElementById(txtusrname).focus();
return false;
}

}
if (txtusr == "") {
if (txtpassw != null) {

alert("Please enter the USERID");
document.getElementById(txtusrname).focus();
return false;
}}
if (txtpassw == "") {
if (txtusr != null) {

alert("Please enter the Password");
document.getElementById(txtpassword).focus();
return false;
}
}

}

</script>

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 14-Jun-13 4:35am

Can you show the button aspx code?

Member 9773317 14-Jun-13 5:14am

what values are you passing in function validatebutton1(txtusrname, txtpassword)
If u are passing the values of username and password then there is no need for again fetching the values as :
var txtusr = document.getElementById(txtusrname).value;
var txtpassw = document.getElementById(txtpassword).value;

Kumar from madras 14-Jun-13 5:19am

I am passing my Control ids for this function.

Member 9773317 14-Jun-13 5:34am

Ok.. How you are calling the function Try like this:
<asp:Button ID="btnclick" Text="submit" runat="server" OnClientClick="return validatebutton1('txtusrname','txtpassword');"
OnClick="btnclick_Click" />

Kumar from madras 14-Jun-13 6:04am

HI Your reply

Done some click for me. Now its work for but i did'n call the javascript function on my hmtl page. I just used OnClick="btnclick_Click"

Thanks for your prompt help.

Rgds
Jagadesh

Member 9773317 14-Jun-13 6:11am

Ok.. weclome

Kumar from madras 14-Jun-13 4:41am

<asp:Button ID="btnLogin" runat="server" onclick="btnLogin_Click"
Text="LOGIN" BackColor="White" BorderStyle="None" Font-Bold="True"
Font-Names="Times New Roman" Font-Underline="True" ForeColor="#666666"/>

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 14-Jun-13 6:07am

So, how are you calling the javaScript function?

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

_Amy · Answer 1 · 2013-06-13T22:18:00

Write return statement while calling javascript. So, whenever javascript will return false Button1 will not allow to submit form.
Try this:
HTML:

ASP.NET

<asp:Button ID="Button1" runat="server" Text="My Button" OnClientClick="return MyFunction();" />

Javascript:

JavaScript

function MyFunction()
{
    return false;
}

[Edit 1]
Since you are passing the parameters in function, you can add the attributes to button from code behind from Page_Load event. Try this in your Page_Load event:
C#:

C#

Button1.Attributes.Add("onclick", "return validatebutton1('" + txtUserName.ClientID + "', '" + txtPassword.ClientID + "');")

Let you javascript be the same.
HTML:

ASP.NET

<asp:Button ID="Button1" runat="server" Text="My Button" />

--Amit

Zafar Sultan · Answer 2 · 2013-06-13T23:03:00

Solution 3

Try this:

JavaScript

<script type="text/javascript"> 
function validatebutton1() 
{ 
var txtusr = document.getElementById('yourUserTextBoxClientID').value; //replace
var txtpassw = document.getElementById('yourPasswordTextBoxClientID').value; //replace

if(txtusr == '' && txtpassw == '')
{
alert('Please enter user name and password.');
return false;
}

if(txtusr == '')
{
alert('Please enter user name.');
return false;
}

if(txtpassw == '')
{
alert('Please enter password.');
return false;
}
return true;
}
</script>

Posted 13-Jun-13 23:03pm

Zafar Sultan

Updated 13-Jun-13 23:22pm

v3

Comments

Kumar from madras 14-Jun-13 5:06am

Hi Zafar

Thanks for your comment

Even i tried with only 1 if condition. I had the same problem.

Rgds
Jagadesh

Zafar Sultan 14-Jun-13 5:20am

Do one thing. Add in your page load event:
btnLogin.Attributes.Add("onclick", "return validatebutton1();");

Run your page and view its source. Get the id's(from page source) of your textboxes and replace them in my updated solution. See if it works.

Thanks7872 · Answer 3 · 2013-06-13T23:14:00

As per as i understand your code,you are trying to check weather someone is trying to click button without providing username and password? If this is so,why dont you use requiredfield validator like this one.

C#

<asp:textbox id="TextBox1" runat="server" xmlns:asp="#unknown" />

<asp:requiredfieldvalidator id="RequiredFieldValidator2" controltovalidate="TextBox1" display="Static" errormessage="*" initialvalue="" runat="server" validationgroup="A" xmlns:asp="#unknown" /> 

<asp:button id="btn_submit" runat="server" text="Submit" onclick="btn_submit_Click" validationgroup="A" xmlns:asp="#unknown" />

If you implement this code,it shows errormessage(*) that says this field is mendatory.

Regards.. :laugh:

Amit Vasi · Answer 4 · 2013-06-13T23:33:00

Solution 6

Hi,

You must do return true in one condition in which your condition are true (i.e. your uname and pwd are filled.)

Hope by this way it will work.

Posted 13-Jun-13 23:33pm

Amit Vasi