code in javascript does not work

Question

0.00/5 (No votes)

See more:

i'm beginner in javascript
code turn on/off light bulb image.i need to know the rule of "bulbon".
i think its the problem.

HTML

<!DOCTYPE html>
<html>
<body>
<script>
function changeImage()
{
  element=document.getElementById('myimage') 
     if (element.src.match("bulbon"))
        {
          element.src="C:\Users\MOHAMED\Desktop\pic_bulboff.gif";
        }
     else
        {
          element.src="C:\Users\MOHAMED\Desktop\pic_bulbon.gif";
        }
}
</script>

<img id="myimage"  önclick="changeImage()"
src="C:\Users\MOHAMED\Desktop\pic_bulboff.gif" width="100" height="180">

<p>Click the light bulb to turn on/off the light</p>

</body>
</html>

Posted 2-Sep-13 23:14pm

mhassan083

Updated 2-Sep-13 23:46pm

Sudhakar Shinde

v3

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mahendran Murugesan · Answer 1 · 2013-09-02T23:54:00

XML

Hi,

Please use the virtual path instead of the physical path. Add the images to project folder and refer them. Also Use IndexOf instead of match.

code
<pre lang="Javascript"> <script type="text/javascript">
        function changeImage() {
            element = document.getElementById('myimage')
            if (element.src.indexOf("pic_bulboff") > 0) {
                element.src = "pic_bulbon.gif";
            }
            else {
                element.src = "pic_bulboff.gif";
            }
        }
</script>
 </pre>
Hope it helps...

Bala Selvanayagam · Answer 2 · 2013-09-03T00:03:00

Your question i need to know the rule of "bulbon".

"
When you click on the image, the javascript is invoked and the if condition is checking which image you have clicked on.

In other words if (element.src.match("bulbon")) condition checks whether the image you clicked got the name string "bulbob" on its name

"

This works for me

HTML

<html>
    <head>
        <title></title>
        <script>
            function changeImage() {
             
                element = document.getElementById('myimage')
                if (element.src.match("crm")) {
                   
                    element.src = "img/cal.png";
                }
                else {
                   
                    element.src = "img/crm.jpg";
                }
            }
</script>
    </head>
<body>
    
 
<img id="myimage"  önclick="changeImage();">
src="img/crm.jpg" height="100" width="100"/>
    
<p>Click the light bulb to turn on/off the light</p>
 
</img></body>
</html>

Jitendra Sabat · Answer 3 · 2013-09-03T02:51:00

There is nothing special in bulbon.All the magic,done over here is carried out by match() function of javascript.Refer detailed explanation of match() in below link

http://www.w3schools.com/jsref/jsref_match.asp[^]

Main concept over here is to find a match of particular word,given as an argument in match() method.In above example document.getElementById('myimage') gives you access of an HTML object pertaining to id 'myimage'.you have stored the object in a variable named 'element'.Now your next line of code says element.src.match("bulbon").It simply refers to the src attribute of img tag provided in your HTML markup.in your case element.src initially means "C:\Users\MOHAMED\Desktop\pic_bulboff.gif".To that string you are appending match('bulbon') method.This means to check whether your string contains a string 'bulbon' or not.If it contains, it returns true else it returns false.

i think there is some problem in your path of image file specified by you.Other things are logical and appropriate to the best of my knowledge.Please check it out.Hope this will help you.

Shobhana.n · Answer 4 · 2013-09-03T08:22:00

Try this..May be it wil solve your problem

function changeImage()
{

element=document.getElementById('myimage') ;
if (element.src.indexOf("bulbon")>0)
{
element.src="../Desktop/pic_bulboff.png";
}
else
{
element.src="../Desktop/pic_bulbon.png";
}
}

code in javascript does not work

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0