What is wrong with foreach inside for loop ?

Question

3.00/5 (1 vote)

See more:

Hello,
I am in a dilemma, as I am not able to understand what is wrong n this piece of code.

C#

int m = 0;
while(m < soitemfinalprice.Length)
{
    Double soamt = 0;
    foreach (var soitem in so)
    {
        foreach (var soitemprice in soitem.SODetails)
        {
            soamt = soamt + soitemprice.SO_Item_Final_Price;
        }
        soitemfinalprice[m] = soamt;
        m++;
    }
}

Here, soitemfinalprice is an array, say of size 3. "so" is a List of class objects, and each "so" contains another List of objects.

Suppose "so" contains 3 items, say 'A', 'B', 'C'.
'A' has two 'SODetails', which has SO_Item_Final_Price values 100 and 200.
'B' has one 'SODetails', which has SO_Item_Final_Price value 100.
'C' has three 'SODetails', which has SO_Item_Final_Price values 50, 100 and 200.

My requirement is that, I need to get the following values:
soitemfinalprice[1] = 300, soitemfinalprice[2] = 100, soitemfinalprice[3] = 350.

What happens now is, I am getting values as:
soitemfinalprice[1] = 750, soitemfinalprice[2] = 750, soitemfinalprice[3] = 750.

What is wrong in this Loop code ?

Posted 25-Jul-14 5:57am

Roshan Nubicus

Updated 25-Jul-14 6:13am

PIEBALDconsult

v2

Add a Solution

Comments

joshrduncan2012 25-Jul-14 12:04pm

Are you getting any errors or just incorrect output?

[no name] 25-Jul-14 12:11pm

Run it through the debugger and you will probably find the problem.

PIEBALDconsult 25-Jul-14 12:15pm

You might want to move Double soamt = 0;
inside the first foreach.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rob Philpott · Answer 1 · 2014-07-25T06:19:00

You've got your iterations wrong - your doing the same thing three times. Try this:

for (int m = 0; m < soitemfinalprice.Length; m++)
{
    int soamt = 0;
    foreach (var soitemprice in so[m].SODetails)
    {
        soamt = soamt + soitemprice.SO_Item_Final_Price;
    }
    soitemfinalprice[m] = soamt;
}

Although this will give you the answer in [0], [1] and [2], not 1,2.3

debashishPaul · Answer 2 · 2014-07-25T06:27:00

You are not resetting the value of soamt. The following code will fix it. Cheers :)

C#

int m = 0;
while(m < soitemfinalprice.Length)
{
    Double soamt;
    foreach (var soitem in so)
    {
        soamt = 0; //Reset soamt to 0
        foreach (var soitemprice in soitem.SODetails)
        {
            soamt = soamt + soitemprice.SO_Item_Final_Price;
        }
        soitemfinalprice[m] = soamt;
        m++;
    }
}

What is wrong with foreach inside for loop ?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0