threading is not working properly in password generation

Question

1.00/5 (1 vote)

See more:

Hello, I'm generate password by therading but I don't know why it is not working,If i run this code without threading it is working otherwise i use thread like below it is not working properly, please guide me how can i use thread in this code.....

Thread th;

  private static string MakePassword(int pl)
        {
pl=50;
            string possibles =
            "0123456789";
            char[] passwords = new char[50];
            Random rd = new Random();

            {
                for (int i = 0; i<50; i++)
                {
                    passwords[i] = possibles[rd.Next(0, possibles.Length)];
                }
            }
            return new string(passwords);
        }


        public void ch()
        {
            try
            {

                            
                string temp = "";
                listView2.View = View.Details;
                listView2.Items.Clear();
                for (int j = 0; j<50; j++)
                {
                    if (j == 0)
                    {
                        temp = MakePassword(6);

                        listView2.GridLines = true;
                        listView2.Items.Add(temp.ToString());
                    }
                    else
                    {

                    g:
                        string k = MakePassword(6);
                        ListViewItem obj = listView2.FindItemWithText(k);


                        if (obj != null)
                        {
                            Refresh();
                            goto g;

                        }
                        else
                        {
                            if (listView2.Items.Count<50)
                            {

                                listView2.Items.Add(k.ToString());
                            }


                        }

                    }
                }
            }
            catch (NullReferenceException)
            { }
        }
        


      

        private void button1_Click(object sender, EventArgs e)
        {
           CheckForIllegalCrossThreadCalls = false;
            th = new Thread(ch);
            th.Start();
           
        }
    }

Posted 23-Mar-11 1:17am

situ21

Updated 23-Mar-11 1:21am

Wendelius

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-03-23T01:56:00

Solution 1

Look, you aren't ready for threading yet: you don't understand enough about the normal code.
As JSOP and I explained yesterday, this is not suitable for threading.

Your new "threaded" version is particularly bad: you cannot access GUI objects from anywhere other than the thread than created them. So, you can't add items to a ListView from your thread without invoking them. I'll give you the code, but you won't understand it!

C#

private void AddNewString(string text)
    {
    if (InvokeRequired)
        {
        Invoke(new MethodInvoker(delegate { AddNewString(text); }));
        }
    else
        {
        myListView.Items.Add(text);
        }
    }

Posted 23-Mar-11 1:56am

OriginalGriff

Comments

situ21 23-Mar-11 8:30am

thanks sir

Sergey Alexandrovich Kryukov 23-Mar-11 17:46pm

Good explanation and sample, a 5.
--SA

situ21 24-Mar-11 0:08am

but sir it is not working,in my code

Sergey Alexandrovich Kryukov 24-Mar-11 0:12am

It's not working because it's bad. Stop using goto and misusing threads. You code should not be improved but re-written.
--SA

situ21 24-Mar-11 0:59am

how sir help me, I have to finish this today.

Sergey Alexandrovich Kryukov 24-Mar-11 2:05am

And I need to sleep. Today. Badly. And please, pay attention, this is not my Answer.
You should have been thinking in advance. What, are you a student who tries to learn 2-year calculus course during the night before the exam? This is same thing. If it was a quick fix I would think about it, but here...
Sorry,
--SA

situ21 24-Mar-11 0:08am

please explain me more , it is not working