How do I update a SQL server table in VBA ?

Question

0.00/5 (No votes)

See more:

I have code that seems to work, but something is awry ... If I execute the following VBA code it DOES update the Database, but them fails on the CLOSE statement saying Error 3704, the file is already Closed. So, the obvious thing is to just delete the CLOSE statement, but I have read that I don't need to OPEN the Table to do the Update, so should I be using a different option on the line that executes the SQL statement (I tried UPDATE but that didn't work) ?!?

VB

Sub UpdateDatabaseLeague(temp)

On Error GoTo 0

SQLstr = "UPDATE League SET SessionNo = " & myEmailSessionNo & " WHERE League.[ID] = " & temp

Set KA_RS_League = New ADODB.Recordset

If KA_RS_League.State = adStateOpen Then KA_RS_League.Close

KA_RS_League.Open SQLstr, KA_DB, adOpenDynamic, adLockOptimistic

KA_RS_League.Close

End Sub

What I have tried:

I tried using UPDATE instead of OPEN and I researched on line to find out that I don't need to Open the Table ...

VB

KA_RS_League.Update SQLstr, KA_DB, adOpenDynamic, adLockOptimistic

Posted 7-Mar-17 4:26am

Gary Heath

Updated 7-Mar-17 10:21am

Add a Solution

3 solutions

Solution 3

To help anybody else like myself who codes but doesn't understand all the intricacies and terminology, this code works for me :-)

VB

Option Explicit
Option Base 1
Option Compare Text

Sub UpdateDatabaseLeague(temp)

On Error GoTo 0

SQLstr = "UPDATE League SET SessionNo = " & myEmailSessionNo & " WHERE League.[ID] = " & temp

Set KA_RS_League = New ADODB.Recordset

If KA_RS_League.State = adStateOpen Then KA_RS_League.Close

Set KA_RS_League = KA_DB.Execute(SQLstr)

End Sub

Posted 7-Mar-17 10:21am

Gary Heath

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Accepted Answer · 2017-03-07T05:01:00

Solution 1

If you are doing something that doesn't need records as a result (ie update, insert or delete) then you can use the ADODB.Connection object instead and use its Execute method to execute your SQL.

Google "adodb.connection" or "adodb.connection execute" for sample code.

Posted 7-Mar-17 5:01am

F-ES Sitecore

Comments

Gary Heath 7-Mar-17 16:22pm

Thank you

Maciej Los · Accepted Answer · 2017-03-07T07:50:00

Solution 2

You have to use ADODB.Command[^] instead of ADODB.Recordset.

Posted 7-Mar-17 7:50am

Maciej Los

Comments

Gary Heath 7-Mar-17 16:22pm

Thank you

Maciej Los 8-Mar-17 13:26pm

You're very welcome.