String array to mysql using C#

Question

0.00/5 (No votes)

See more:

I want to add a total of 11 records in my SQL. the consist of 4 columns, so a total of 44 blocks.

so what I have is information in the form of

Name,IPAdress,Port,Tag

I am just trying to load in the Name column for a test and I keep getting "connection must be valid and open"

I have tested the MySQL connection string and the Query just by sending one down the pipe and it works, its when I try to use a for loop to send them one after another

below is my "on press" function of the forms

What I have tried:

C#

private void button1_Click(object sender, EventArgs e)
{
   Globals.camera1Name = cameraName1.Text; Globals.camera1IP = cameraIP1.Text;  
   Globals.camera1Port = cameraPort1.Text;
   Globals.camera2Name = cameraName2.Text; Globals.camera2IP = cameraIP2.Text;  
   Globals.camera2Port = cameraPort2.Text;
   Globals.camera3Name = cameraName3.Text; Globals.camera3IP = cameraIP3.Text;  
   Globals.camera3Port = cameraPort3.Text;
   Globals.camera4Name = cameraName4.Text; Globals.camera4IP = cameraIP4.Text; 
   Globals.camera4Port = cameraPort4.Text;

   Globals.userName = newUserName.Text; Globals.userPassword = newUserPassword.Text;

   Globals.wonderWareIP = wonderWareIP.Text; 
   Globals.wonderWarePort = wonderWarePort.Text; 
   Globals.wonderWareTag = wonderWareTag.Text;       

   //string command = "UPDATE `james_hardie`.`config` SET `system_name`='" +  Globals.printer1Name + "', `ip_address`='" + Globals.printer1IP + "', `port`='" + Globals.printer1print + "', `cartridges`='" + Globals.printer1Cart + "' WHERE `idconfig`='1';";

   //MySqlCommand excute = new MySqlCommand(command, Globals.hardie);
   MySqlDataReader myReader;

   try
   {
      Globals.hardie.Open();

      for (int x = 0; x < 11; x++)
      {
         string command = "UPDATE `james_hardie`.`config` SET `system_name`='" + Globals.printerNames[x] + "' WHERE `idconfig`='" + (x + 1) + "';";
         MySqlCommand excute = new MySqlCommand(command, Globals.hardie);
         myReader = excute.ExecuteReader();
         Globals.hardie.Close();
      }
   }
   catch (Exception ex)
   {
      MessageBox.Show(ex.Message);
   }
}
}

Posted 17-Mar-16 16:52pm

Cbrown330

Updated 17-Mar-16 18:51pm

VR Karthikeyan

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Manas_Kumar · Accepted Answer · 2016-03-17T18:51:00

You are closing the connection inside loop. It will for first time but next time Database connection is not opened so you are getting exception. Secondly use ExecuteNonQuery() instead of ExecuteReader(). Try with below code:

C#

try
{
  // Open connection
  Globals.hardie.Open();

  for (int x = 0; x < 11; x++)
  {
	 string command = "UPDATE `james_hardie`.`config` SET `system_name`='" + Globals.printerNames[x] + "' WHERE `idconfig`='" + (x + 1) + "';";
	 MySqlCommand excute = new MySqlCommand(command, Globals.hardie);
	 excute.ExecuteNonQuery();
  }
  
  // Close connection
  Globals.hardie.Close();
}
catch (Exception ex)
{
  MessageBox.Show(ex.Message);
}

Although above one resolve your problem stills it has SQL Injection problem, so always use parameterised query like below:

C#

MySqlCommand cmd1; 
cmd1 = new MySqlCommand("SELECT * FROM User_table WHERE User_ID = @UserID", Globals.hardie);
cmd1.Parameters.AddWithValue("@UserID", "yourValue"));
excute.ExecuteNonQuery();
cmd1.Parameters.Clear();