Not Receive Serial Port

Question

4.00/5 (2 votes)

See more:

I am develop serial port receive data software in window application.
My software working fine when i operate it manually but when i connect it with device.
I am using this code to receive data:

C#

void comPort_DataReceived(object sender, SerialDataReceivedEventArgs e)
       {

               if (comPort.IsOpen == true)
               {
                   //Thread.Sleep(150);
                   bytes = comPort.BytesToRead;
                   comBuffer = new byte[bytes];
                   comPort.Read(comBuffer, 0, bytes);
                   string mm = ByteArrayToHex(comBuffer);
               }
        }

I am using timer for other use and function and i set it to 1ms. But when i use Thread.Sleep(150); then it will work proper so it means i have to wait for some timer to read complete data. How i do it without using Thread.Sleep.

Posted 6-Feb-12 22:32pm

jaideepsinh

Updated 6-Feb-12 22:39pm

CPallini

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 7-Feb-12 4:35am

Not clear. It depends what's on the other side of your RS-232 cable. :-)
--SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-02-06T22:46:00

Solution 1

The problem is probably that you are assuming that when you get the DataReceived event all the data is ready for you - this is not necessarily true. You will typically get multiple DataReceived events - one for each character, as they take time to arrive as a bit stream. When the first character has completely arrived, you will get the first event. Adding Thread.Sleep allows the other chatracters time to arrive, and be available to read as a stream.

Instead of processing just the characters that arrive each time, you need to store them, and look at the complete stream, probably by looking for a terminator or bytes count of some kind - it depends on teh device at the other end of the wire, and how it talks to your PC.

[edit]Typos - OriginalGriff[/edit]

Posted 6-Feb-12 22:46pm

OriginalGriff

Updated 6-Feb-12 22:47pm

v2

Comments

jaideepsinh 7-Feb-12 5:18am

First Thank You for reply.
Can you explain with some code because first time i develop this type of application.

OriginalGriff 7-Feb-12 5:26am

:laugh:
Not really, no - I have no idea what device you are talking to, or what the data looks like!

glennPattonWork3 7-Feb-12 5:26am

Hmmm, have you attached comPort_DataRecieved event argument, simple I know but it stumped me the first time too.

jaideepsinh 7-Feb-12 5:29am

But if i wait for some ms then it completely receive.Is it right way to use Thread.sleep or other function work delay if i use Thread.sleep.

OriginalGriff 7-Feb-12 5:48am

No - it is nearly always a bad idea to use Thread.Sleep, and always bad on the default thread - every time you use Thread.Sleep you are preventing anything else (such as the user keyboard or mouse) from doing anything.

jaideepsinh 7-Feb-12 6:10am

I understand that but what i am doing now for solve this problem.