doubt on stored procedure

Question

0.00/5 (No votes)

See more:

Database table,

SQL

CREATE TABLE [dbo].[STS_ADDRESS_BOOK](
         [AB_ID] int NOT NULL IDENTITY(1,1) CONSTRAINT primarykey PRIMARY KEY,
         [AB_NAME] [varchar](100),
         [AB_EMAIL] [varchar](100),
         [AB_FAX] [varchar](100),
         [AB_ADDRESS][varchar](max),
         [AB_PHONE][varchar](16)
)

------------------------------------------------------
then sp,

SQL

GO
IF OBJECT_ID ('dbo.sortAddressBookInformation')IS NOT NULL
DROP PROC  sortAddressBookInformation
GO

CREATE PROC sortAddressBookInformation @columnvalue varchar(100)
AS

exec('SELECT * FROM STS_ADDRESS_BOOK ORDER BY' +@columnvalue)

this command executed successfully.but the execution of sp using ,

exec sortAddressBookInformation @columnvalue=[AB_NAME] give error as,

Incorrect syntax near 'BYAB_NAME'.

why?what is the mistake?

Posted 25-Sep-12 1:32am

hasbina

Updated 25-Sep-12 1:36am

VIPR@T

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhijit Parab · Accepted Answer · 2012-09-25T01:34:00

Solution 1

hi,
u were missing space after order by

exec('SELECT * FROM STS_ADDRESS_BOOK ORDER BY ' +@columnvalue)

Posted 25-Sep-12 1:34am

Abhijit Parab

Comments

Abhijit Parab 25-Sep-12 7:36am

pass @columnvalue as in varchar like @columnvalue='column name'

hasbina 25-Sep-12 7:41am

Thank you Abhijit..

Mazumder.Soumen · Accepted Answer · 2012-09-25T01:40:00

The SP has a problem you need to put a Space after the By

IF OBJECT_ID ('dbo.sortAddressBookInformation')IS NOT NULL
DROP PROC sortAddressBookInformation
GO

CREATE PROC sortAddressBookInformation @columnvalue varchar(100)
AS

exec('SELECT * FROM STS_ADDRESS_BOOK ORDER BY ' +@columnvalue)

Try executing this Store Procedure it will work.

'SELECT * FROM STS_ADDRESS_BOOK ORDER BY' +@columnvalue. You missed to put a space after the By clause.

thanks
Happy Coding.
Soumen