|
Yes, and the flags aren't changed anywhere inside the intervening 'logic'.
Not only does he compare a bool to true , he also compares it to the Windows-defined TRUE as well, which is not really the same thing.
Software Zen: delete this;
|
|
|
|
|
What if, 15 years down the line, someone inserts code between the two different checks that changes the value of TRUE?
You have to make absolutely sure that it is still true when the really important piece of code hits. I suggest you add a few inline ifs so that there will never be any doubt.
My plan is to live forever ... so far so good
|
|
|
|
|
To quote my "favorite comment":
#define TRUE FALSE
"Never attribute to malice that which can be explained by stupidity."
- Hanlon's Razor
|
|
|
|
|
|
Oh no, that can be not only valid, but also necessary...
Can you be sure that there's not some strange #define somewhere changing the meaning of TRUE or true ?
And when the flags array is a member of the class (instead of locally declared in a function), its values can be changed from where ever in a different thread.
Just make sure you cope with such threats.
Oh sanctissimi Wilhelmus, Theodorus, et Fredericus!
|
|
|
|
|
Bernhard Hiller wrote: #define somewhere changing the meaning of TRUE or true ? Even more reason to break out the flamethrower...
Software Zen: delete this;
|
|
|
|
|
Hey, I recently removed code toying with the global BoolStr variable because some table-internal-to-the-program had to use yes/no instead of true/false which as easily readable but doesn't require meddling with globals.
|
|
|
|
|
just add this code before the first if statement:
if (flags[0] == TRUE) flags[0] = true;
if (flags[1] == TRUE) flags[1] = true;
if (flags[0] == FALSE) flags[0] = false;
if (flags[1] == FALSE) flags[1] = false;
Then you can trust !(not), && and || for the rest of the checks.
Or better yet, with 2 Booleans, there are only four possible states, so normalize and then turn it into a switch statement with 0-3.
if (flags[0] == TRUE) flags[0] = true;
if (flags[1] == TRUE) flags[1] = true;
if (flags[0] == FALSE) flags[0] = false;
if (flags[1] == FALSE) flags[1] = false;
int state;
if (flags[0])
state = 1
else
state = 0;
if (flags[1]) state += 2;
switch (state) {case 0-3:...}
|
|
|
|
|
My gastrointestinal tract just inverted itself...
Software Zen: delete this;
|
|
|
|
|
Even worse:
If the //... code that initializes the flags array really assigns those values into it, then it looks like the original code does not even consider these cases:
x == true && y == TRUE.
2 variables with 4 possible values each means there should be 16 possible states.
Normalizing the values reduces it to 2 variables with 2 possible values which gives 4 states.
If true vs TRUE produce different outcomes, then God bless you and convert the "bools" into an enum.
Consider creating a multidimensional array where the indexes are your "flags" and you initialize each array element to be the correct answer for that combination of states.
|
|
|
|
|
Is it possible we're talking about Quantum bool ????
Paulo Gomes
Measuring programming progress by lines of code is like measuring aircraft building progress by weight.
—Bill Gates
Everything should be made as simple as possible, but not simpler.
—Albert Einstein
|
|
|
|
|
Only this[^] knows.
Software Zen: delete this;
|
|
|
|
|
Maybe it's an existential program looking for the meaning of truth and it couldn't get a hold of Stephen Colbert.
|
|
|
|
|
Both patterns are bad. On most platforms bool is an integer. Therefore flags[x] might get corrupted to equal, say 42. Code that didn't explicitly check consistently for "==true" would take the wrong path. if(flags[x]) would be true, if(flags[x]==true) would be false. Then you also get the VB true, which is -1!
|
|
|
|
|
what if var TRUE = false; hey!? I betcha didn't think of it, did ya?!
|
|
|
|
|
This is C++, fortunately.
Software Zen: delete this;
|
|
|
|
|
well, you know
#undef TRUE
#define TRUE 0
|
|
|
|
|
This could make sense in a multithreaded situation, but somehow I've a feeling that's not what you're dealing with...
#SupportHeForShe
Government can give you nothing but what it takes from somebody else. A government big enough to give you everything you want is big enough to take everything you've got, including your freedom.-Ezra Taft Benson
You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun
|
|
|
|
|
While this code was in fact multithreaded, that had nothing to do with the sloppy way the logic was coded. I've had very few cases where comparing a bool variable to a constant made more sense algorithmically than just using the variable as-is. The second part comparing the variable to the Windows DWORD constant TRUE is just plain stupid. It works, but that's no credit.
Software Zen: delete this;
|
|
|
|
|
Count me in the Spoiled Rotten Club: I just discovered that you can define all the string resources you want, and your XAML editor won't see them until you run them through the resource compiler.
I say that I am spoiled because I am accustomed to having new strings immediately visible in the C# code editor.
I'm in VS 2017, as opposed to Blend for VS.
BTW, the blog that was the most help is at The Weird and The Wonderful.
Go figure.
David A. Gray
Delivering Solutions for the Ages, One Problem at a Time
Interpreting the Fundamental Principle of Tabular Reporting
modified 7-May-19 15:23pm.
|
|
|
|
|
You are spoiled indeed!
Fortunately F6 to the rescue! F6! F6! F6! F6!
|
|
|
|
|
Indeed, but why must I?
BTW, for me, it's F7, because I use the old Visual Studio 6 key bindings.
David A. Gray
Delivering Solutions for the Ages, One Problem at a Time
Interpreting the Fundamental Principle of Tabular Reporting
|
|
|
|
|
SHR LSB(D)→ DF; 0→ MSB(D) F6 So, how exactly is this Shift Right instruction going to help?
I have lived with several Zen masters - all of them were cats.
His last invention was an evil Lasagna. It didn't kill anyone, and it actually tasted pretty good.
|
|
|
|
|
Which processor instruction set is that?
Software Zen: delete this;
|
|
|
|
|
One I know in and out since over 40 years now: Chip Hall of Fame: RCA CDP 1802 - IEEE Spectrum[^]
I have lived with several Zen masters - all of them were cats.
His last invention was an evil Lasagna. It didn't kill anyone, and it actually tasted pretty good.
|
|
|
|