C / C++ / MFC

6-Oct-06 1:13

Hello Comunity,
i have an litle trouble wit this data type! To add an new item in this object i use:

CMapStringToOb cMap;
CString csNewKey = "First";
CMyObject* myObject; // public CObject!
cMap.SetAt(csNewKey, new CMyObject());
// to add new items to my class CMyObject use:
cMap.Lookup(csNewKey, (CObject*&)myObject);
// now set data to myObject:
myObject->csName = "John";
// etc., this is only for example!

ok, works fine, but when i close my dialog, i recive memoryleaks!
And the debugger show in this line with -> cMap.SetAt(csNewKey, new CObject()); ?!
how to solve this, any sugestions?

regards
break;

prasad_som6-Oct-06 1:21

prasad_som

6-Oct-06 1:21

break; wrote:
cMap.SetAt(csNewKey, new CMyObject());// to add new items to my class CMyObject use:cMap.Lookup(csNewKey, (CObject*&)myObject);

You have used new CMyObject ,in SetAt.
Somewhere you need to delete it. You can do it before cMap goes out of scope, enumerating it.

Prasad
Notifier using ATL | Operator new[],delete[][^]

bosfan6-Oct-06 1:44

6-Oct-06 1:44

Hello,
i use other funktion to delete all objects befor closing dialog, looks something like this:

// before CDialog is closed!

POSITION pos = cMap.GetStartPosition();
CString csKey;
CMyObject* cMyObject;

while(NULL != pos)
{
   CMyObject* myOb;
   cMap.GetNextAssoc(pos, csKey, (CObject*&)cMyObject);
   
   delete cMyObject;
   cMap.RemoveKey(csKey);
}
// cMap is empty! 100%

i dont know what else to do! Frown | :(

Question is on witch place to set use "delete"? I need all data during program run, only solution is
before closing the dialog??

regards
break;

prasad_som6-Oct-06 3:52

prasad_som

6-Oct-06 3:52

I dont see any memory leak, if you are using above code.

break; wrote:
Question is on witch place to set use "delete"? I need all data during program run, only solution is
before closing the dialog??

Are you asking this ?
you can write it in DestroyWindow(). Provided cMap is dialog class member.

Prasad
Notifier using ATL | Operator new[],delete[][^]

benjymous6-Oct-06 1:22

benjymous

6-Oct-06 1:22

You're creating new objects when you add them to the map, but you're never deleting them

Either:

1) At the end, go though the elements of cMap, and delete everything
2) Use smart pointers, that'll delete the objects for you

--
Help me! I'm turning into a grapefruit!
Buzzwords!

bosfan6-Oct-06 1:46

6-Oct-06 1:46

Hi,
thanx for answer, please take a look to my answer by previous reply!

regards
break;

bosfan6-Oct-06 2:01

6-Oct-06 2:01

Hi,
smart pointer can be a good idea, how to use them in this case, any sample for smart pointer?

break;

benjymous6-Oct-06 4:42

benjymous

6-Oct-06 4:42

http://www.codeproject.com/vcpp/stl/boostsmartptr.asp[^]

--
Help me! I'm turning into a grapefruit!
Buzzwords!

bosfan6-Oct-06 7:38

6-Oct-06 7:38

Hello,
yes, i try this to solve my prob.!
thanx for help to all

regards
break

Sending Messages

baerten6-Oct-06 0:55

baerten

6-Oct-06 0:55

Hi everyone,

i had a component with diff PopUp Buttons, to catch the OnClick-Event i added a message-handler in the
Pane ( it herids from CWnd ) and a click on the different PopUp Buttons executes the code in the method On_xxxxxx_Click() in this Pane.

Now, i have created a modified the component and added a Click-Handle that determinates the Button of the component who's clicked.
Then i must send a message to the Pane to execute the On_xxxxxx_Click() ( The Pane doesn't change )

void MyTaskPanel::OnLButtonDown(UINT nFlags,CPoint point)<br />
{<br />
  // Determinates the button who's clicked<br />
  <br />
  TaskPanelGroup* Item;<br />
  <br />
  Item = HitTestGroup(point);<br />
  <br />
  UINT SelectedID;<br />
  if(Item) {<br />
    SelectedID = Item->GetID();                       // gets the correct ID of the Button<br />
    SendMessage(BN_CLICKED,(WPARAM)SelectedID,NULL);  // sends a message<br />
  } else {<br />
    // It wasn't a button<br />
  }<br />
}

In the pane i have this message-map :

BEGIN_MESSAGE_MAP(Home_Bht_Kunden_Side, CPaneView)<br />
	ON_BN_CLICKED(ID_OF_CLICKED_BUTTON,On_ID_OF_CLICKED_BUTTON_Click)<br />
        ...<br />
      END_MESSAGE_MAP()<br />
<br />
void ThePane::On_ID_OF_CLICKED_BUTTON_Click()<br />
{<br />
  int test = 9; // I never step here<br />
}<br />
<br />

The Question: If i send a message from out the component, where does the message arrives?
Can all Message-Maps receive this Message and trade it ( if it matches )

Big Thanks

ctodor6-Oct-06 1:33

ctodor

6-Oct-06 1:33

BN_CLICKED is not a message, it is notification code and should be sent through WM_COMMAND message.
e.g.

WPARAM wParam = (WPARAM)(((WORD)BN_CLICKED << 16) | ((WORD)GetDlgCtrlID()));
GetParent()->SendMessage(WM_COMMAND, wParam, (LPARAM)m_hWnd);
where m_hWnd is the HWND of the control and GetDlgCtrlID() returns the id of the control.

The message arrives to that CWnd you sent it. In your situation, you send the message to MyTaskPanel, so MyTaskPanel should process the message. If you want to send a message to other CWnd object , you should call SendMmessage fct. for that object : pMyView->SendMessage(...)

baerten6-Oct-06 2:44

baerten

6-Oct-06 2:44

Thanks for the answer

but i don't have a HWND. I will sent the Message from out the Component.
The component should send a message to the window where it's placed.
Because the components gets the universal click on the component
The OnClick-Function determinates which button is clicked and the component sends a new message
to the window by specifing which Button is clicked ( over the ID )

Thanks

krmed6-Oct-06 7:09

krmed

6-Oct-06 7:09

You will also find that your code may work in Debug build, but when you build a release version, it will crash.

The reason is that the SendMessage actually sends the command and a WPARAM and LPARAM. You must handle those in your message handler:

void ThePane::On_ID_OF_CLICKED_BUTTON_Click(WPARAM, LPARAM)<br />
{<br />
int test = 9; // I never step here<br />
}Karl - WK5M<br />
PP-ASEL-IA (N43CS)<br />
<kmedcalf@ev1.net><br />
PGP Key: 0xDB02E193<br />
PGP Key Fingerprint: 8F06 5A2E 2735 892B 821C 871A 0411 94EA DB02 E193