C / C++ / MFC

15-Feb-02 22:25

IDM prefix I would think would be the resource identifier thats associated with the about menu appended to your dialogs system menu. IDS prefix is for the string table reosurce.

"An expert is someone who has made all the mistakes in his or her field" - Niels Bohr

where is the problem?

15-Feb-02 19:59

void Investors:: addInvestor(Investor& in)
{
Investor* temp = new Investor[numOfInvestors+1]; //create a new investor array of size of prevArray+1
if (investorsList == NULL) //check if there is something in the array
{
investorsList = temp; //save temp in investorsList
investorsList[0] = in; //fill the first element with the investor that you want to add
} //to your list
else //else if the investorsList is not NULL
{
for (int i = 0; i< numOfInvestors; i++) //in this loop you start copying the elements of the prevlist in
{ //the new temp list
temp[i] = investorsList[i];
cout <

15-Feb-02 21:22

It doesn't seem to have pasted correctly down the bottom so I'm not sure exactly what's going on, some possibilities:
. you seem to be using investorsList after you've deleted it.
. investorsList=temp; //shouldn't this be done somewhere?
. numOfInvestors++ seems to be done twice
good luck

alex.barylski15-Feb-02 22:22

15-Feb-02 22:22

It's hard to read code that isn't formatted correctly also, so perhaps use the pre, tag. it preserves your orignal whitespace so tabs actually indent.

if(a==b)
AfxMessageBox("Example of pre tag");

is instead

if(a==b)
    AfxMessageBox("Example of pre tag");

Remember to close your tags too!

Cheers!

"An expert is someone who has made all the mistakes in his or her field" - Niels Bohr

16-Feb-02 1:34

void Investors:: addInvestor(Investor& in)
{ 
    Investor* temp = new Investor[numOfInvestors+1];  //create a new investor array of size of prevArray+1
	if (investorsList == NULL)                        //check if there is something in the array	
	{
		investorsList = temp;                         //save temp in investorsList
		investorsList[0] = in;                        //fill the first element with the investor that you want to add 
	}                                                 //to your list
	else                                              //else if the investorsList is not NULL
	{
		for (int i = 0; i< numOfInvestors; i++)       //in this loop you start copying the elements of the prevlist in
		{                                             //the new temp list
			temp[i] = investorsList[i];	
			cout <<investorslist[i]<<endl;
 }
="" temp[numofinvestors]="in;" copy="" the="" new="" element="" in="" last="" position
="" numofinvestors++;="" increment="" numofinvestors
="" delete="" []="" investorslist;="" old="" list
="" for(="" i="0;" i<numofinvestors;="" i++)
="" {
="" investorslist[i]="temp[i];" 
="" insertionsort(investorslist,="" numofinvestors);
="" investorslist[numofinvestors];="" numofinvestors++;
}="" 
<\pre="">

alex.barylski16-Feb-02 12:01

16-Feb-02 12:01

Your missing a few brackets and your syntax is a little off.

//Tip: class members should be prefixed with m_ so others can tell what non locals are.
//NumOfInvestors, investorList i'll assume are class members

void Investors::addInvestor(Investor& in)
{     
	Notice your new is created
	Investor* temp = new Investor[numOfInvestors+1];  
	
	//create a new investor array of size prevArray+1	
	if (investorsList == NULL) 
	{		
		investorsList = temp;                         
		
		//save temp in investorsList		
		investorsList[0] = in;                        
	}   
	else   
	{		
		for (int i = 0; i< numOfInvestors; i++)  //in this loop you start copying the elements of the prevlist in		
		{                                             
			//the new temp list			
			temp[i] = investorsList[i];				
			cout <<investorsList[i]<<endl;		
		}        
			temp[numOfInvestors] = in;  //copy the new element in the last position    	
			numOfInvestors++;           //increment the numOfInvestors    	
			
			Notice your new is deleted, but what happens if else isn't executed
			delete [] investorsList;    //delete old list    	
		
			//This isn't going to make sense to the compiler
			
			for(i = 0; i				//Your syntax here was off a little
			{
				investorsList[i] = temp[i]; 		
			}	
			
			insertionSort(investorsList, numOfInvestors);	
			
			investorsList[numOfInvestors];               	
			numOfInvestors++;
	} 
	delete should go here unless your if constructs return early
}

"An expert is someone who has made all the mistakes in his or her field" - Niels Bohr

16-Feb-02 12:21

for(i = 0; i //Your syntax here was off a little { investorsList[i] = temp[i]; }

I could not copy and paste the right code for some reason.
it kept truncating that part of the for statement that you are pointing it to reight above i will try to copy for the last time!
hope it works this time!

void Investors:: addInvestor(Investor& in)
{ 
    Investor* temp = new Investor[numOfInvestors+1];  //create a new investor array of size of prevArray+1
	if (investorsList == NULL)                        //check if there is something in the array	
	{
		investorsList = temp;                         //save temp in investorsList
		investorsList[0] = in;                        //fill the first element with the investor that you want to add 
	}                                                 //to your list
	else                                              //else if the investorsList is not NULL
	{
		for (int i = 0; i< numOfInvestors; i++)       //in this loop you start copying the elements of the prevlist in
		{                                             //the new temp list
			temp[i] = investorsList[i];	
			cout <<investorslist[i]<<endl;
 }
="" temp[numofinvestors]="in;" copy="" the="" new="" element="" in="" last="" position
="" numofinvestors++;="" increment="" numofinvestors
="" delete="" []="" investorslist;="" old="" list
="" for(="" i="0;" i<numofinvestors;="" i++)
="" {
="" investorslist[i]="temp[i];" 
="" insertionsort(investorslist,="" numofinvestors);
="" investorslist[numofinvestors];="" numofinvestors++;
}="" <\pre="">

this is the right code

16-Feb-02 12:26

void Investors:: addInvestor(Investor& in)
{ 
    Investor* temp = new Investor[numOfInvestors+1];  //create a new investor array of size of prevArray+1
	if (investorsList == NULL)                        //check if there is something in the array	
	{
		investorsList = temp;                         //save temp in investorsList
		investorsList[0] = in;                        //fill the first element with the investor that you want to add 
	}                                                 //to your list
	else                                              //else if the investorsList is not NULL
	{
		for (int i = 0; i< numOfInvestors; i++)       //in this loop you start copying the elements of the prevlist in
		{                                             //the new temp list
			temp[i] = investorsList[i];	
			cout <<investorslist[i]<<endl;
 }
="" temp[numofinvestors]="in;" copy="" the="" new="" element="" in="" last="" position
="" numofinvestors++;="" increment="" numofinvestors
="" delete="" []="" investorslist;="" old="" list
="" for(="" i="0;" i<="" numofinvestors;="" i++)
="" {
="" investorslist[i]="temp[i];" 
="" insertionsort(investorslist,="" numofinvestors);
="" investorslist[numofinvestors];="" numofinvestors++;
}="" <\pre="">

16-Feb-02 12:27

void Investors:: addInvestor(Investor& in)
{ 
    Investor* temp = new Investor[numOfInvestors+1];  //create a new investor array of size of prevArray+1
	if (investorsList == NULL)                        //check if there is something in the array	
	{
		investorsList = temp;                         //save temp in investorsList
		investorsList[0] = in;                        //fill the first element with the investor that you want to add 
	}                                                 //to your list
	else                                              //else if the investorsList is not NULL
	{
		for (int i = 0; i< numOfInvestors; i++)       //in this loop you start copying the elements of the prevlist in
		{                                             //the new temp list
			temp[i] = investorsList[i];	
			cout <<investorslist[i]<<endl;
 }
="" temp[numofinvestors]="in;" copy="" the="" new="" element="" in="" last="" position
="" numofinvestors++;="" increment="" numofinvestors
="" delete="" []="" investorslist;="" old="" list
="" for(="" i="0;" i<="" numofinvestors;="" i++)
="" {
="" investorslist[i]="temp[i];" 
="" insertionsort(investorslist,="" numofinvestors);
="" investorslist[numofinvestors];="" numofinvestors++;
}="" <\pre="">

alex.barylski16-Feb-02 13:31

16-Feb-02 13:31

Try this

//Construction
//Allocate array to hold n Number of elements

Investors::Investors(UINT nSize)
{
	investorsList = new Investor[nSize*sizeof(Investor)];
}


//Add investor item to array
void Investors::addInvestor(Investor& in)
{     
	investorsList[numOfInvestors] = in;     //Add newElement(in) to next available element of investor array

	insertionSort(investorsList, numOfInvestors);	
	
	numOfInvestors++;	//Increment number of available records
} 

//Destruction
Investors::~Investors()
{
	delete [] investorsList;
}

"An expert is someone who has made all the mistakes in his or her field" - Niels Bohr

16-Feb-02 14:02

hey HockeyDude;
first of all thank you for your explanations and efforts to solve my dilemma.
but may be i did not mention that I MUST start with an empty array and dynamically cnange its size as i'm adding elements to it!

alex.barylski16-Feb-02 15:34

16-Feb-02 15:34

Ah...well that adds another layer of difficulty.

Theres no way you can just declare a very large array at construction and fill it in as you go...?

Dynamic resizing isn't easy...I'm working on a class as we speak and i'm not sure i'd be able to fully explain.

First off i don't use new/delete, i use malloc/free.

you have to delete every new at the end of every code block otherwise you get memory leaks.

If you absolutely MUST dynamically resize your array I can only give you pointers...exact code I cannot.

basically use realloc/malloc/free

class CMyClass  
{
public:
  CMyClass() : m_nCount(0)
  { m_pBuff = malloc(sizeof(Investor)); }
  ~CMyClass(){ free(m_pBuff); }
  void AddInvestor(Investor& newItem)
  {
    //Add item to array
    *(m_pBuff+m_nCount) = newItem;   

    m_nCount++;  //Increment number of items in array

    //Reallocate room for another item
    m_pBuff = realloc(m_pBuff, sizeof(Investor)*(m_nCount+1)));

    
  }
private:
  UINT      m_nCount;  //Number of items in array
  Investor* m_pBuff;   //Pointer to buffer or list of investors
};

Note: I don't know for 100% sure the above code is complete, I'm typping from the top of my head. I will however give a starting point.

The code only allocates to a larger size it does NOT shrink itself as required...It assumes there will be NO removal of items once in the array...Also it allocates memory one element at a time...this will fragment your memory. You'd have to allocate large chunks at construction fill them in, then have code in your AddInvestor() reallocate another large chunk and proceed as normal...

All in all this is quite alot of work.

Can I ask what this is for...? Have you considered perhaps using one of MFC's helper classes like CArray...??

It does the Sizing and allocation and stuff for you...

Cheers!

"An expert is someone who has made all the mistakes in his or her field" - Niels Bohr

16-Feb-02 20:32

Man you've been working hard on this stuff man, i don't know how to say thank you.
but the problem is that i must follow the instructor's specification!!!!!
if it depended on me i would have used a linked list but the thing is that i have to use exactly what he said if i don't want to get a zero in my project.
our instructor is so picky!
and as you say "An expert is someone who has made all the mistakes in his or her field" - Niels Bohr
i think this is what he wants make us go thru all mistakes?? Dead | X|

well anyways here is my latest version of that stupid addInvestor(Investor in) method. see if you trace through it you probably won't find any problems
but the fact is that it adds the first element and crashes same as be4!!!

class Investors
{
// code........
int Investors::numOfInvestors = 0;
Investor* Investors:: investorsList = NULL;
// code........

void Investors:: addInvestor(Investor& in)
{ 
	cout<< in<< endl;
	cout<< "numOfInvestors at the beginning: "<< numOfInvestors<< endl;
	numOfInvestors++;
    Investor* temp = new Investor[numOfInvestors+1];  //create a new investor array of size of prevArray+1
	if (investorsList == NULL)                        //check if there is something in the array	
	{
		investorsList = temp;                         //save temp in investorsList
		investorsList[0] = in;                        //fill the first element with the investor that you want to add 
	}                                                 //to your list
	else                                              //else if the investorsList is not NULL
	{
		for (int i = 0; i < (numOfInvestors - 1); i++)//in this loop you start copying the elements of the prevlist in
		{                                             //the new temp list
			cout << "I am inside the first for loop and i = "<< i<< endl;
			temp[i] = investorsList[i];	
			cout<< temp[i]<< endl;
		}
        delete [] investorsList;
		investorsList = new Investor[numOfInvestors];
        temp[numOfInvestors - 1] = in;                     //copy the new element in the last position
    	for( i = 0; i < numOfInvestors; i++)
		{
    	   investorsList[i] = temp[i]; 
		}
		insertionSort(investorsList, numOfInvestors);
	}
	delete [] temp;
	cout<<"numOfInvestors at the end: "<< numOfInvestors<< endl;
 
} 
<\pre> 

AGAIN THANK YOU:rose: :rose: :rose: :rose: :rose: :rose:

alex.barylski16-Feb-02 21:54

16-Feb-02 21:54

Send me your cpp/h files unless theres more than one each in email.

It's hard for to lok at this code and guess whats really going on, unless I have the full thing.

Your code is really wide as well, so I keep having to scroll back and forth...It'll be much easier if I can code in my VC workspace.

So you MUST use new/delete for a dynamically growing array...you cannot use malloc and delete...?

That was the reason for the temp array creation...I see...

Yeah like i said..Actually....send me the entire project...that way theres no...missing links...

Cheers

"An expert is someone who has made all the mistakes in his or her field" - Niels Bohr

alex.barylski16-Feb-02 21:55