C / C++ / MFC

Re: Efficient way of converting an 8bit array of grayscale pixel data into 24bpp bitmap for GDI+?

31-Jul-15 21:40

Did you try the straightforward way (that is filling the ARGB memory area in a loop) and measured its performance?

Jochen Arndt31-Jul-15 21:51

Jochen Arndt

31-Jul-15 21:51

When the input data are 8 bit gray scale values just assign them to the R, G, and B values and set the aplha value to zero:

C++

// Assuming RGBA is an uint32_t / DWORD type and 
//  *in an unsigned char / uint8_t pointer.
RGBA *out = new RGBA[512 * 512];
for (unsigned i = 0; i < 512 * 512; i++)
{
    out[i] = (in[i] << 16) + (in[i] << 8) + in[i];
}

Passing an "array" in C

PIEBALDconsult31-Jul-15 7:41

31-Jul-15 7:41

Although I use C# most of the time, I try to use C for small exercises -- to keep my C sharp! Unsure | :~

Anyway... I don't recall having to pass arrays back when I was using C full-time (in the 90s), so I don't know which technique is preferred.
As I see it, there are two basic techniques as precedents in C:

0) Passing the length of the array with the array -- e.g. main ( int argc , char *argv[] )
1) Having a "special value" at the end of the array to indicate the end -- e.g. NULL-terminated strings.

So, if I want to pass an array of structs (four ints), which technique is preferred by the C/C++ community?

I'm actually considering door number...

2) Using a linked list instead. It just seems cleaner, though memory usage is actually increased by 25% in this case.

Again, this is just an exercise, but practicing poor technique can be worse than not practicing at all.

So, what say you? If you have to pick door 0 or door 1, which do you prefer?

k505431-Jul-15 7:55

k5054

31-Jul-15 7:55

Which method you use depends on what your data looks like. If you have an array of int, then there may not be a special value that can be the sentinel for the end of the array. On the other hand if you have an array of pointers to something, then maybe a NULL pointer is a good choice as a sentinel. Not always, though. If you had an sparse array of pointers, it would be conventional for the empty elements to be NULL, so you could not use that as the sentinel.

Advantages to passing the length are that you can work your way forwards or backwards through the array without having to count how many first, and you know the bounds, so you shouldn't have any Undefined Behaviour from trying to access outside the array.

PIEBALDconsult31-Jul-15 8:34

31-Jul-15 8:34

Thanks.

With these particular structs, there is a field in which a 0 (or anything less than 1) could easily be used to indicate that the item is the terminator.
And in this particular exercise, I need to visit each item once per call, so knowing the length would only keep me from going off the end, not aid in navigation.

I'll give door 1 a try. I think that will require only that I allocate one more item and make a small change to the for loop I would otherwise use.

camycentsolutions2-Aug-15 19:36

camycentsolutions

2-Aug-15 19:36

Unfortunately in C language there has not any concept of bounds checking.If we are inserting an array elements which exceeds size of an array automatically it is treated as garbage value.

Example:
#include<stdio.h>
#include<conio.h>

main()
{
int a[10];
a[3]=4;
a[11]=3;//does not give segmentation fault
a[25]=4;//does not give segmentation fault
a[20000]=3; //gives segmentation fault
getch();
}

C^hris L^osinger31-Jul-15 9:50

31-Jul-15 9:50

you can always do a 'container':

C++

typedef struct intArray_t
{
    int *pData;
    int len;
} intArray;

intArray newIntArray(int len)
{
   intArray ia;
   ia.pData = (int*)malloc(len * sizeof(int));
   ia.len = len;
   return ia;
}

intArray myData = newIntArray(10);

etc.

then you pass intArrays around

PIEBALDconsult31-Jul-15 10:48

31-Jul-15 10:48

Oh, of course. D'Oh! | :doh:

PIEBALDconsult31-Jul-15 14:17

31-Jul-15 14:17

And now I've learned that the version of MinGW GCC I have will allow typeof and the declaration of variables in for statements ( for ( int i ... ) provided I invoke -std=gnu99 . Jig | [Dance]

What a fun exercise for a rainy Friday afternoon.

modified 31-Jul-15 20:24pm.

PIEBALDconsult1-Aug-15 21:18

1-Aug-15 21:18

Wait a minute... isn't that code example missing some indirection?

C^hris L^osinger2-Aug-15 3:52

2-Aug-15 3:52

it's possible. where?

PIEBALDconsult2-Aug-15 6:36

2-Aug-15 6:36

Or maybe that's not C? Can you return a local variable like that in C? Even returning a pointer to a local variable is verboten isn't it?

Or is my C-fu still that rusty?

C^hris L^osinger2-Aug-15 7:06

2-Aug-15 7:06

sure, you can return locals - even if they're structs.

a pointer to a local would be a bad idea, because the local goes out of scope. but when you return a local, it makes a copy for the caller.

PIEBALDconsult2-Aug-15 7:17

2-Aug-15 7:17

Huh. I guess I thought C was dumber than that, one semester of C wasn't enough. That explains that small memory leak I wrote in 1994... I wonder whether or not that program is still in use... Unsure | :~

PIEBALDconsult4-Aug-15 15:06

4-Aug-15 15:06

I pulled out my old VAX C book for reference, and all I see is passing structs in as parameters, but it seems to say it's limited to 1020 bytes. If that's true, it must apply to return values as well -- they're still on the stack, yes?

C^hris L^osinger5-Aug-15 1:20

5-Aug-15 1:20

that's probably the VMS stack size.

i believe the struct returning behavior is compiler dependent (OS dependent?). some will return the struct in a register, if the struct is small enough, or on the stack. some compilers are smart enough to use the caller's struct directly so as to avoid making a copy.

that struct i showed is sizeof(int *) + sizeof(int). so, 8 or 12 bytes. nothing to worry about.

k50545-Aug-15 4:22

k5054

5-Aug-15 4:22

I believe that's implementation defined. With my linux box I can use ulimit to set the size of the stack. By default it seems to be 8MB, but I can modify that upwards more or less as needed (obviously within memory limits of the system).

I seem to recall that early C implementations were limited to returning basic types (e.g. int, double, char *, etc). gcc-5.2 still has a warning flag for aggregate returns - which suggests that other C compilers might still adhere to that.

CPallini31-Jul-15 21:32

31-Jul-15 21:32

Method 0 is the one I observe most of the time (and use myself more frequently). Even Windows API use it.
Sentinel method has its usages (k5054 already pointed out its drawbacks).
I won't use method 2, I mean I won't choose a linked list instead of an array just in order to avoid the extra parameter in my function.

PIEBALDconsult1-Aug-15 5:00

1-Aug-15 5:00

Thanks.

The sentinel method worked well in this case, but then Chris Losinger suggested method 3 -- using a container*. So I'm using that now. This technique has the added benefit that I can store the number of items allocated as well as the number of items in use -- sort of like how a List works in .net. I can add items up to the limit (I have no need to expand the array; I know how many items I need up front).

* Didn't we used to call that a Control Block? A simple way to avoid having bullions and bullions of function parameters?

CPallini1-Aug-15 5:13

1-Aug-15 5:13

Quote:
Didn't we used to call that a Control Block? A simple way to avoid having bullions and bullions of function parameters?

Of course I am aware of the general technique (pass a struct instead of tons of parameters, again Windows API docet), however it is the very first time I hear the term 'Control Block' used with such a meaning.

By the way, you are welcome.

PIEBALDconsult1-Aug-15 5:40

1-Aug-15 5:40

PIEBALD whips out his trusty "MS-DOS Programmer's Reference" (1993, "covers through version 6"!)... and it just says "structure", e.g. RWBLOCK structure.

And VMS uses "descriptors" which are similar.

"
The Descriptor

Classic C programming uses pointers to various structures, including null-terminated strings; ASCIZ strings. These are used within the OpenVMS standard C library, though most OpenVMS interfaces use descriptors. An OpenVMS construct that will be entirely new to even experienced C programmers is the string descriptor. This is typically a small data structure, containing the data length, data type, descriptor class, and data address for a chunk of data.
" -- http://labs.hoffmanlabs.com/node/273[^]

But I'm sure we used the term "Control Block" where I worked. Maybe it's from the UNIX culture? :shrug:

CPallini1-Aug-15 5:55