C / C++ / MFC

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow

<br />
XML Dev<br />
-------<br />
 <br />
Comments...<br />
 <br />
- make the DevNotice.txt file wrap to ~80 columns<br />
 <br />
[LoadDocument]<br />
<br />
- doesn't support the necessary character encodings:<br />
See http://www.w3.org/TR/2004/REC-xml-20040204/#charencoding for info<br />
 <br />
- doesn't detect the appropriate file encoding:<br />
http://www.w3.org/TR/2004/REC-xml-20040204/#sec-guessing-no-ext-info<br />
 <br />
- at a minimum, you should be able to load all of the sample files on<br />
this page:<br />
http://www.schaake.nu/index.php?page=/manuals/encoding.xml<br />
 <br />
- since you're trying to make this OS independant, you could use:<br />
http://www.unicode.org/Public/PROGRAMS/CVTUTF/ for your conversion code<br />
between utf-8/utf-16.<br />
 <br />
[Other Stuff]<br />
<br />
Bug: Failure to check for empty/all spaces/invalid tag/attribute names.<br />
It's a problem with SetAttribute, AddChild, etc. <br />
 <br />
i.e. pRoot->SetAttribute(_T(""), _T("a")); is allowed.<br />
pRoot->AddChild(_T(" ")) is allowed.<br />
 <br />
- how do you set the XML declaration? (i.e. <?xml version="1.0" encoding="utf-8"?> )<br />
 <br />
- I question the use of the text mappings. What's important is that you can<br />
handle reading Unicode files in an ANSI build, and vice versa. I would just<br />
store all the XML data using wchar_t/std::wstring. utf-8 files could be<br />
converted to ucs-2, and passed to the XML object. utf-16 files could be<br />
passed directly to the XML object.<br />
 <br />
- Usage seems fairly logical and simple from the stuff I tried<br />
 <br />
- Help file layout is very good. The only thing I don't like is lack of<br />
padding on the top and bottom of text in the gray boxes<br />
<br />

Pssst. You see that little light on your monitor? That's actually a government installed spy camera. Smile and wave to big brother!

void YourDialog::DoDataExchange(CDataExchange* pDX)
{
	CDialog::DoDataExchange(pDX);
	//{{AFX_DATA_MAP(YourDialog)
	DDX_Control(pDX, IDC_MYSCROLL, m_myScroll);
	//}}AFX_DATA_MAP
}