C / C++ / MFC Discussion Boards

KellyR5-Jun-07 5:29

5-Jun-07 5:29

Hi,

This program is a dialog-based MFC application.

My problem is that when I click the "X" in the top right corner of the program to close it, only the window closes, but the process remains running.

I'm not very familiar with MFC (I usually use standard Windows API) so I don't know how to catch the WM_SYSCOMMAND message to handle this. I've tried ON_WM_SYSCOMMAND() in the message map, but I get a compiler error since neither of my two classes are inherited from CWnd objects (one is CWinApp, the other is CDialog).

Does anyone know why my program isn't closing, or how could I catch the WM_SYSCOMMAND message so I could force it to close?

Thanks!

Re: Problem with closing program

David Crow5-Jun-07 5:38

David Crow

5-Jun-07 5:38

KellyR wrote:
...but the process remains running.

How are you verifying this? Have you created additional threads?

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: Problem with closing program [modified]

KellyR5-Jun-07 7:06

KellyR

5-Jun-07 7:06

The process is still visible in the task manager, and no I only have a single thread.

Re: Problem with closing program

Mark Salsbery5-Jun-07 7:21

Mark Salsbery

5-Jun-07 7:21

How and where is the main dialog created?

BTW, CDialog IS a CWnd Smile | :)

Mark

"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder

Re: Problem with closing program

KellyR5-Jun-07 7:29

KellyR

5-Jun-07 7:29

I thought so too but for some reason I still get a compiler error when I try to map ON_WM_SYSCOMMAND() in my dialog; I guess that's because the BEGIN_MESSAGE_MAP macro ties my class to CDialog and not CWnd? Sorry if I sound like an idiot, I'm just not that familiar with how MFC works. This is the first MFC application I've ever created from scratch so I'm still getting the hang of it.

The main dialog is created in the InitInstance() of the main application.

So something like this:

BOOL CTheApp::InitInstance()<br />
{<br />
  CWinApp::InitInstance();<br />
  m_MainDlg = new CMainAppDlg();<br />
  <br />
  if(!m_MainDlg->Create(IDD_MAIN_DIALOG))<br />
  {<br />
    AfxMessageBox(TEXT("Failed to initialize."), MB_OK, 0);<br />
    return FALSE;<br />
  }<br />
  m_MainDlg->SetWindowText(TEXT("Test Dialog"));<br />
  m_pMainWnd = m_MainDlg;<br />
<br />
  return TRUE;<br />
}

Re: Problem with closing program

Mark Salsbery5-Jun-07 7:43

Mark Salsbery

5-Jun-07 7:43

What's the compiler error when you add a ON_WM_SYSCOMMAND() entry to the dialog class'
message map?

Mark

"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder

Re: Problem with closing program

KellyR5-Jun-07 7:51

KellyR

5-Jun-07 7:51

The error is this:

error C2440: 'static_cast' : cannot convert from 'void (__thiscall CMainAppDlg::* )(void)' to 'void (__thiscall CWnd::* )(UINT,LPARAM)'

Re: Problem with closing program

Mark Salsbery5-Jun-07 7:57

Mark Salsbery

5-Jun-07 7:57

Your handler function needs to be declared as

afx_msg void OnSysCommand(UINT nID, LPARAM lParam);

From the error message it looks like you have void OnSysCommand();

"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder

Re: Problem with closing program

KellyR5-Jun-07 8:04

KellyR

5-Jun-07 8:04

Oh, duh.. thanks!

Re: Problem with closing program

Mark Salsbery5-Jun-07 8:21

Mark Salsbery

5-Jun-07 8:21

I'm still not sure why the app isn't shutting down - I thought CWnd::OnNcDestroy() took
care of that if the window is the app's main window (designated by setting m_pMainWnd in
InitInstance()). Maybe debugging a breakpoint there will explain it.

Mark

"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder

Re: Problem with closing program

David Crow5-Jun-07 10:08

David Crow

5-Jun-07 10:08

Is this a dialog-based application? If so, then why are you creating a modeless dialog?

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: Problem with closing program

Michael Dunn5-Jun-07 19:23

Michael Dunn

5-Jun-07 19:23

You don't handle the [X] button with WM_SYSCOMMAND, you handle WM_CLOSE. More commonly, in a dialog-based app, you don't handle WM_CLOSE, but instead WM_COMMAND with a command ID of IDCANCEL. That way, your app will properly implement the three ways of closing a dialog: a button whose ID is IDCANCEL, the [X] button, and the Esc key.

--Mike--
Visual C++ MVP Cool | :cool:

LINKS~! Ericahist | PimpFish | CP SearchBar v3.0 | C++ Forum FAQ

Dunder-Mifflin, this is Pam.

Heap error

simoncoul5-Jun-07 5:27

simoncoul

5-Jun-07 5:27

Hello, I'm trying to allocate some memory but for some reason it keeps giving me a heap error. If I just continue through it in debug mode the function will output the proper number, and any time after that it continues to output numbers without and error, untill I restart visual studio then I get the error again. The error always occurs with h=2, any info on where to get start or how to fix this would be great.

const Complex I(0.0L,1.0L); //imaginary numbers

double **I = (double**)malloc(sizeof(double*)*K);
for ( h =0; h < K; h++){
	I[h] = (double*) malloc(sizeof(double)*K);
}

Thanks

Re: Heap error

David Crow5-Jun-07 5:37

David Crow

5-Jun-07 5:37

Since Complex is a class, you should probably be using new (and delete).

simoncoul wrote:
const Complex I(0.0L,1.0L); //imaginary numbers
double **I = (double**)malloc(sizeof(double*)*K);

So what is I?

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: Heap error

simoncoul5-Jun-07 5:44

simoncoul

5-Jun-07 5:44

This code was produced by someone else, but from my taking on it, it's just a 2D array with 1000 positions. I don't believe that I needs to be complex either, since it is being cast as a double, and no calculations are done with that involve it needing to be complex.

Thank you

Re: Heap error

David Crow5-Jun-07 10:22

David Crow

5-Jun-07 10:22

But what is I? How is the compiler not complaining about a re-definition?

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: Heap error

Matthew Faithfull5-Jun-07 5:50

Matthew Faithfull

5-Jun-07 5:50

I can't tell you why you're getting an erro on h == 2 but I would try something like this instead.

<br />
double** I = new double*[K];<br />
for( int h = 0; h < K; h++ )<br />
{<br />
  I[h] = new double[K];<br />
}<br />

Obviously you'll need to do matching deletes, remember to use delete [], array delete in case you every want to compile this on a non Microsoft system.

Nothing is exactly what it seems but everything with seems can be unpicked.

Re: Heap error

simoncoul5-Jun-07 6:06

simoncoul

5-Jun-07 6:06

I have tried what u said using new instead of malloc, but still when h = 2 in the loop I get an error.

Windows has triggered a breakpoint in kpSim.exe.

This may be due to a corruption of the heap, and indicates a bug in kpSim.exe or any of the DLLs it has loaded.

The output window may have more diagnostic information

and it causes the break in the free.c file.

Thanks

Re: Heap error

Matthew Faithfull5-Jun-07 6:14

Matthew Faithfull

5-Jun-07 6:14

OK, the clue here is the break is in free.c. My guess from this is that code you posted or I posted is fine and the error is occuring in code I havn't seen yet. free.c is going to be doing a free, which needs changing to a delete, anyway. You need to track down what it is that's being freed and where this call originates from. If you can find the code with the free that is failing and changing it for a delete to match the new doesn't help, post it and I may be able to help. If I've left for the garage by then others will pick it up. Smile | :)

Nothing is exactly what it seems but everything with seems can be unpicked.

Re: Heap error

simoncoul5-Jun-07 6:33

simoncoul

5-Jun-07 6:33

Ok I have looked through the code and found that in some parts new was being used to allocate but free was being used instead of delete. I'm going to go though and fix that up and hopefully that will work. Thanks for the help, I will let you know the results.

Re: Heap error

simoncoul5-Jun-07 8:10

simoncoul

5-Jun-07 8:10

I am still getting an error when h = 2, I have absolutely no idea what is happen as I have fixed all the new/delete problems.

Like the program still functions if I just continue pass the heap error, and every time I run the program after that(until I close VS) I don't get it anymore.

When I trace through the code when the error occurs it happens in files that I have not touched that are part of VS librarys.

Re: Heap error

Matthew Faithfull5-Jun-07 8:55

Matthew Faithfull

5-Jun-07 8:55

This can happen if you have a memory overrun. If you allocate a buffer and then write beyond the end, or beginning, of it you can damage data belonging to the C Runtime. There used to be a classic example using stdio which blew up spectacularly. OMG | :OMG:

I would be interesting to know if it actually crashes in Release builds. If so you may just be damaging the gaurd bytes inserted between allocations in debug mode. This can happen with a very slight overrun, <= 4 bytes, and you'll get away with it often in debug except for the rude messages from the runtime. In Release it will very likely go bang.

Nothing is exactly what it seems but everything with seems can be unpicked.

Re: Heap error

simoncoul5-Jun-07 9:53

simoncoul

5-Jun-07 9:53

I tried it in the release mode and it is still giving me the error, this makes no sense cause the array is being initialized and allocated in that block of code that I posted earlier, that stuff isn't touched prior to that so I don't see why I'd be having so many problems allocating it. I have tried making using different loops and allocating the memory in different ways but it always messes up at h = 2. Thanks again for all the help.

Re: Heap error

simoncoul5-Jun-07 9:58

simoncoul

5-Jun-07 9:58

I'm very sorry, I just noticed this in the output

 HEAP[kpSim.exe]: Heap missing last entry in committed range near 4327310
Windows has triggered a breakpoint in kpSim.exe.

I hope this will help so we can figure out what is going on.

thanks

Re: Heap error

Matthew Faithfull5-Jun-07 10:28

Matthew Faithfull

5-Jun-07 10:28

Ok, that's wierd. I've never seen that error before. I take it you're not using some kind of alternative heap manager or managed C++? If it's not too long I suggest you post whole thing, or email it to me and I'll have a look. I'll also check the C Runtime sources to see if this is just an unusual error that's been lurking there all the time. Knowing which version of MSVC you're using would help as well Smile | :)

Nothing is exactly what it seems but everything with seems can be unpicked.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.