C / C++ / MFC

4-Oct-07 18:35

Ya. I have already read that. I understood nothing more... Frown | :(

That is why I posted this doubt.

- NS -

Ownerdraw Listbox

Hamed Musavi3-Oct-07 0:49

3-Oct-07 0:49

I am creating an ownerdraw listbox. In DrawItem function I want to draw text. There's a code snippet in MSDN that is a little bit strange:

It uses this code to retrieve the text of current item.

LPCTSTR lpszText = (LPCTSTR) lpDrawItemStruct->itemData;

I think it's wrong because a user might add custom data to items of the control and it's logical that itemData member refers to that data, anyway it doesn't work for me. I used this code which works just fine:

GetText(lpDrawItemStruct->itemID, str);

Is this ok?. If not, then is there any better way of finding text of current item in DrawItem?

// "Life is very short and is very fragile also." Yanni
while (I'm_alive)
{
cout<<"I love programming.";
}

Nishad S3-Oct-07 1:10

3-Oct-07 1:10

Reading the MSDN documention about the DRAWITEMSTRUCT will give you the information about itemData. Hope you will... Smile | :)

Anyway the second method you used is not wrong.

- NS -

Hamed Musavi3-Oct-07 1:16

3-Oct-07 1:16

NS17 wrote:
Reading the MSDN documention about the DRAWITEMSTRUCT will give you the information about itemData.

I did, and that's the reason of this question. It says something that seems to be wrong to me:

from MSDN:
itemData 
For a combo box or list box, this member contains the value that was passed to the list box by one of the following: 
CComboBox::AddString 
CComboBox::InsertString 
CListBox::AddString 
CListBox::InsertString

this description with the snippet try to prove the string added can be found in itemData variable. I'm wondering at the moment, whether it differs if a list box has HAS_STRING style or not. Mine has and the itemData has not the string.

I'm completely confused Confused | :confused:

// "Life is very short and is very fragile also." Yanni
while (I'm_alive)
{
cout<<"I love programming.";
}

Nishad S3-Oct-07 1:25

3-Oct-07 1:25

Hamed Mosavi wrote:
it differs if a list box has HAS_STRING

Yes.

- NS -

Hamid_RT3-Oct-07 2:00

3-Oct-07 2:00

A different question why you dont use of ListCtrl instead ListBox?

Nishad S3-Oct-07 2:14

3-Oct-07 2:14

I like listbox because of its simplicity. But could you please point out the advantage of listctrl that made you to ask so?

- NS -

Hamid_RT3-Oct-07 2:26

3-Oct-07 2:26

Instead my choice is Listctrl and ListBox is simple to use but its limited.

Nishad S3-Oct-07 2:35

3-Oct-07 2:35

Hamid. wrote:
but its limited.

That's true... Smile | :)

- NS -

Hamed Musavi3-Oct-07 2:45

3-Oct-07 2:45

Hamid. wrote:
why you dont use of ListCtrl

Because all I need is a list of names.

CListCtrl has been designed to do more, like icons, different views(like report), good in-place edit, etc. and more flexibility cause more complexity, so one should spend a lot more time and write more codes to do the same work that could be easily done by a ListBox.

Now that I don't need those features, why should I go the hard way?

// "Life is very short and is very fragile also." Yanni
while (I'm_alive)
{
cout<<"I love programming.";
}

David Crow3-Oct-07 3:29

David Crow

3-Oct-07 3:29

Hamed Mosavi wrote:
Now that I don't need those features, why should I go the hard way?

I agree. It was an odd suggestion.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Iain Clarke, Warrior Programmer

Iain Clarke, Warrior Programmer3-Oct-07 4:45

3-Oct-07 4:45

Your method seems fine to me - but have a look at LBS_HASTRINGS to be sure.

My suspicion is that the example snippet is just storing a pointer to some text in itemData in order to have something simple to draw. There's nothing to stop you have your code numbers in it, or neglecting it completely.

Iain.

Set background color to List control

Max++3-Oct-07 0:40

Max++

3-Oct-07 0:40

I try to subclass and use this code for change background color in list control

<br />
BOOL CSubListCtrl::OnEraseBkgnd(CDC* pDC) <br />
{<br />
   CRect rect;<br />
   GetClientRect(&rect);<br />
   pDC->FillSolidRect(0,0,rect.Width(),rect.Height(),RGB(100,200,0));<br />
   return TRUE;<br />
}

it work only when first time show.
but when I add item to it, that item will change to default color.

Please help me for solve this problem.

Re: Set background color to List control [modified]

Hamed Musavi3-Oct-07 0:53

3-Oct-07 0:53

I think you should override DrawItem which will be called when each item of the control is to be drawn. Then use the input parameter for that function(lpDrawItemStruct) like this:

CDC dc;
dc.Attach(lpDrawItemStruct->hDC);

dc.FillSolidRect(&lpDrawItemStruct->rcItem, RGB(100,200,0));

dc.Detach();

You should also manually draw text of each item, check to see if it is selected to highlight it and draw a border for active item.

By the way if your list control is inside a dialog, take a look at OnCtlColor of the dialog. It makes life times easier if you just need to change background or text color of a dialog control.

-- modified at 6:59 Wednesday 3rd October, 2007

// "Life is very short and is very fragile also." Yanni
while (I'm_alive)
{
cout<<"I love programming.";
}

Nishad S3-Oct-07 1:14

3-Oct-07 1:14

I wonder why you do such a thing when SetBkColor and SetTextBkColor are available for CListCtrl.

- NS -

Hamid_RT3-Oct-07 2:06

3-Oct-07 2:06

See an example Alternate Row Colors for the CListCtrl[^].

Nishad S3-Oct-07 2:17

3-Oct-07 2:17

But he needs a single bk color. So my suggestion is good, right?

- NS -

Hamid_RT3-Oct-07 2:26