C# Discussion Boards - CodeProject

Ismael_199929-Jul-20 5:32

29-Jul-20 5:32

Hi, Richard.
In my control I have these events:

public event EventHandler ClickNovo;
public event EventHandler ClickEditar;
public event EventHandler ClickApagar;
public event EventHandler ClickSalvar;
public event EventHandler ClickCancelar;

Do you sugest that I create another event? Could you give me an example?
Thanks.

Gerry Schmitz29-Jul-20 7:11

29-Jul-20 7:11

Some of this depends on your architecture, and whether it's Windows Forms or WPF / UWP; each use different patterns for validation.

If you only check validity on "save", you're doing "record-level" validation (easy) versus field-level validation (harder, due to cross-referencing and handling focus).

The "easy" way is to use a "data object" as the "view model" / transport between the "view" (form / window) and the "model" (data access layer / repository). This data object is used to pass data to the user control (to initialize the view / form / window) and to retrieve the "record" from the UC to be saved (add or update).

You may bind to the view model directly or copy the view data to it when saving. You then validate the data object and display the first error or save. If you have different "validation routines", you can pass a delegate (at initialize / load time) to the user control that accepts the data object and returns a status / error (if it's not feasible to have actually validation code in the user control.)

In the save "click" event, disable save (to avoid re-entrancy), copy the view / UC data to the view model (if not binding directly), validate, then save if OK or return an error. Reset buttons accordingly.

This pattern works for "Add" and "Update".

Deletes usually require some thinking about what to "display" after a delete and any further operations (like "add back in" or revert).

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

Ismael_199929-Jul-20 10:02

29-Jul-20 10:02

Hi, Gerry.

My idea was to create a validation function in the main program and when the user clicks on the Save buttons, before anything it calls that validation function. Do you know how to do this?
Thanks.

Gerry Schmitz30-Jul-20 0:10

30-Jul-20 0:10

"Save" is form-level function; primitive controls and UC's are bit players to the form. In the Save / button event (on the form), retrieve the "data object" (view model) which consolidates all the UI / form's input, validate it, then save the contents or display an error.

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

Ralf Meier30-Jul-20 0:43

30-Jul-20 0:43

When reading this discussion my actual question is :
why a UserControl ? For me a UC is an object which is used more than one time (in a different context).
Basicly (so my opinion) we have a Data-Input object (Form) - so when I see it in OOP-context the question (for me) must be : which is my main-object and which are the sub-objects with which functionality ?
This is also (or primary) a reply to the OP ...

Ismael_199930-Jul-20 4:09

30-Jul-20 4:09

Ralf.
I'm developing a system with many forms and many of them use these buttons. And these forms have different fields in different amouunts.

Gerry Schmitz30-Jul-20 7:21

30-Jul-20 7:21

Without seeing his "form", I can make few assumptions about the merits of his architecture.

I have a "user control" that presents "books", complete with tables of contents, incremental searching, etc. This UC itself contains more UC's: virtual keyboard controls (single and split), content sizing sliders, navigators, etc.

I'm trying to describe, in general terms, my "model" for "model <-> view"; UC's are fat controls.

In "data object" terms, I sometimes put a public interface on the UC, and pass the whole thing around. "Live" if you will. All depends on how you build it ... and I "love" code-behind. My apps are also in production.

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

modified 30-Jul-20 13:35pm.

Gerry Schmitz28-Jul-20 6:53

28-Jul-20 6:53

Adding to what Richard said:

Events - C# Programming Guide | Microsoft Docs

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

BillWoodruff28-Jul-20 16:55

BillWoodruff

28-Jul-20 16:55

I suggest you handle field validation inside the UserControl, and only enable the 'Save Button when all fields have appropriate values ... assuming the validation code can be located inside.

There are several strategies you can use including using the built-in validation facilities in WinForms [^], [^]. A valuable discussion here: [^].

A simple strategy is to define Event Handlers for all the input fields for 'Enter and 'Leave, and check for values. Use a boolean flag to keep track of whether all fields are valid.

For an example of a complex full-featured validator see CP article: [^]

«One day it will have to be officially admitted that what we have christened reality is an even greater illusion than the world of dreams.» Salvador Dali

modified 29-Jul-20 10:31am.

Ralf Meier28-Jul-20 21:04

28-Jul-20 21:04

I would do it like this :
Outside your UserControl you have to check if all fields are filled (and perhaps if all information is valid) - because the Information is outside the UserControl.
Your UserControl gets a Property which give this (boolean) Information to it.
This Check could be done each time one of those fields is changed ... or with an Event which comes from the UserControl. But I prefer the 1st ...

Ismael_199929-Jul-20 10:04

29-Jul-20 10:04

Hi, Ralf. What to do so when the user clicks on the Save buttons it first verify the fields? I mean: the verification must ocur just when the user clicks on the Save buttons. You know how to do this?
Thanks.

Ralf Meier29-Jul-20 20:30

29-Jul-20 20:30

Hi ...
in my opinion it would be not so good to generally allow the using of the Save-Button if the state of the data-field is not checked. In my applications I prefered allways the way of "check input when changes" and give a valid-information (and allow further action).
If you want to do it the other way round you should give an event to "outside" of your UserControl to do the check and the Check itself has to start (when all data is valid) perhaps a public method inside your UserControl which does the action (or raise another Event). What should happen if the Check isn't valid ? Who should give the Message to the User - the UserControl ? Or a Messagebox from the Ckeck-method ?
You see : there are serverall ways to do this ...

Ismael_199930-Jul-20 4:03

30-Jul-20 4:03

Hi, Ralf.
I used your idea and it's working fine. The only (minor) problem is that the system can't show the user a message to tell him what to correct. Anyway, as I said, is a minor problem. If you have any sugestion about this, please let me know. And thank you for your help.

Ralf Meier30-Jul-20 6:15

30-Jul-20 6:15

Perhaps I have ...
Give me some more details about your project ...
Basicly the Textbox (or whereever you do the input) "knows" what kind of data is required. Here you can decide directly what is wrong ...
But perhaps you write some more ...

Ismael_199931-Jul-20 6:47

31-Jul-20 6:47

Hi, Ralf.
My system has a main form which is used as an MDI Parent. From it the user can access many other screens to control the system. Some of these screens make the registration of clients, suppliers, banks and others. In these registration screens, there are fields connected to columns in tables. When fields are mandatory, the system must verify what was written there. That’s my problem. At this moment this verification is working well, but it does not warn the user about a wrong entry or an empty field which should be filled. My User Control now has the following code:
        private void SalvarButton_Click(object sender, EventArgs e)
        {
            if (PermSalvar)
            {
                ClickSalvar?.Invoke(this, e);
                EmEdicao = false;
            }
        }
I created a variable (PermSalvar) which indicates whether the data can be saved. In the main program there is a routine named ValidaCampos which is called in the leave moment of the fields of interest, as you can see below.
        private void ValidaCampos()
        {
            if (tb_Nome.Text == "")
                botoes1.PermSalvar = false;
            else
                botoes1.PermSalvar = true;


            if ((tb_Id.Text == "") || (!int.TryParse(tb_Id.Text, out int cp)))
                botoes1.PermSalvar = false;
            else
                botoes1.PermSalvar = true;
        }
        private void tb_Nome_Leave(object sender, EventArgs e)
        {
            ValidaCampos();
        }
        private void tb_Id_Leave(object sender, EventArgs e)
        {
            ValidaCampos();
        }
So, if you could give me any advice, it would be very welcome.
Thank you.

Gerry Schmitz31-Jul-20 7:48

31-Jul-20 7:48

I question the validity of logic that flags an error (and continues) and then turns it off under another condition further on.

"Initialize" once.

if (tb_Nome.Text == "")
    botoes1.PermSalvar = false;
else
    botoes1.PermSalvar = true;

if ((tb_Id.Text == "") || (!int.TryParse(tb_Id.Text, out int cp)))
    botoes1.PermSalvar = false;
else
    botoes1.PermSalvar = true;

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

Ismael_199931-Jul-20 10:36

31-Jul-20 10:36

I test al fields that must be filled. In one case in this form, the contents must be integer. If all fields are correct the variable PermSalvar receives a true value. If at least one of them is not correctly filled, that variable (which is inside the User Control and has false as its default value) remains false.
And the Save action only performs if the variable is true.
Do you have any sugestion? Plase tell me.
Thanks.

Ralf Meier31-Jul-20 8:22

31-Jul-20 8:22

Some time ago I created an application with a similar behaviour (normally I create HMI-applications for machines).
I found that the users sometimes entered senseless data into a Textbox. So I created (with the TextChanged-Event) a method to those Textboxes which data has a special format (for example : it must have a legal date or an Integer value or a Phone-number or ...) and give a User-message (MessageBox) to correct this. In the same time I disable the Save-Button.
Perhaps this approach helps you ...

Ismael_199931-Jul-20 10:39

31-Jul-20 10:39

I tried your suggestion some time ago. It worked fine, but I could not prevent the buttons to change their enable status. That’s why I’m trying something different.
I continue accepting suggestions and thanks.

Ralf Meier31-Jul-20 11:20

31-Jul-20 11:20

Why don't you can disable the Button ?
Please explain ...

Ismael_19991-Aug-20 1:57

1-Aug-20 1:57

Enable and disable the buttons depend on which buttons was pressed. When the user enters the screen, the Save and Cancel buttons are disabled. The other 3 are enabled. When user presses New or Edit buttons, the enable state changes. It's programmed in the User Control, which is generic.

Ralf Meier1-Aug-20 22:49