Managed C++/CLI Discussion Boards

Strings in C | The program gives wrong output on string composed of both Upper case and lower case (Logic : ASCII Comparision) Why?

Member 148492461-Jun-20 2:37

Member 14849246

1-Jun-20 2:37

//this program is to change the Upper case to lower and vice-versa
#include<stdio.h>
void main()
{char name[50];
int i;
gets(name);
for(i=0;name[i];i++)
{
if(65<=name[i]<=90)
name[i]=name[i]+32;
else if(97<=name[i]<122)
name[i]=name[i]-32;
}
puts(name);
}

Re: Strings in C | The program gives wrong output on string composed of both Upper case and lower case (Logic : ASCII Comparision) Why?

Richard MacCutchan1-Jun-20 3:15

Richard MacCutchan

1-Jun-20 3:15

Don't use decimal numbers to represent characters, it makes it more difficult to understand. Use hex numbers or, better still, proper character constants. Also you cannot use expressions like if(65<=name[i]<=90); that is not valid C.

C++

if(name[i] >= 'A' && name[i] <= 'Z')
    name[i] = name[i] + 0x20;
else if(name[i] >= 'a' && name[i] <= 'z')
    name[i] = name[i] - 0x20;
}

And finally, this is the Managed C++/CLI forum, the C/C++/MFC forum is at C / C++ / MFC Discussion Boards[^].

Re: Strings in C | The program gives wrong output on string composed of both Upper case and lower case (Logic : ASCII Comparision) Why?

k50541-Jun-20 4:22

k5054

1-Jun-20 4:22

Richard MacCutchan wrote:
... expressions like if(65<=name[i]<=90); that is not valid C

Strictly speaking, that is valid C, though it does not do what you might expect. In fact it will always return 1 (true), since it is equivalent to if ( (65 <= name[i]) <= 90). The expression (65 <= name[i]) evaluates to either true (1) or false (0), both of which are <= 90, so the expression will always be true.

Better than using "magic numbers", or even char constants, why not useisupper(), islower(), toupper() and tolower())?

C++

#include <ctype.h>

if( islower(name[i] )
   name[i] = toupper(name[i]);
else if ( isupper(name[i]) )
   name[i] = tolower(name[i]);

That's clear and concise, I think, and has the advantage that if you need to migrate to an non ASCII environment [e.g. EBCDIC, but not UTF-X (and really, who does, these days?)], it will still work without any code changes. It will also work for locales other that C/POSIX

For the advanced reader I offer, also

C++

name[i] = isupper(name[i]) ? tolower(name[i]) : toupper(name[i])

toupper() and tolower() only transform characters that evaluate true for isupper() and islower(), respectively, so non alphabetic chars are not changed by passing through them. The ternary ?: operator should be approached with caution though, as it often makes code harder to understand, particularly for users new to C

Keep Calm and Carry On

Re: Strings in C | The program gives wrong output on string composed of both Upper case and lower case (Logic : ASCII Comparision) Why?

Richard MacCutchan1-Jun-20 5:05

Richard MacCutchan

1-Jun-20 5:05

Yes that is all very well. But my reply was for someone who obviously only knows the very basics of C, and even that not very well. Trying to explain ternary operators to someone who does not really understand binary ones is not the best way forward.

Re: Strings in C | The program gives wrong output on string composed of both Upper case and lower case (Logic : ASCII Comparision) Why?

kalberts1-Jun-20 7:25

kalberts

1-Jun-20 7:25

Also, 7 bit ASCII is historical.

The very minimum requirement today is to handle ISO 8859-1 in the Western world (8859-x in other parts). But for software developed this millennium, the real minimum requirement is the Unicode Basic Multilingual Plane. (In fact, I do not know if there concept of upper/lower cases is relevant for any characters outside the BMP.)

Handling a-z only belongs back in the age of 80-column punched cards.

Re: Strings in C | The program gives wrong output on string composed of both Upper case and lower case (Logic : ASCII Comparision) Why?

Richard MacCutchan1-Jun-20 9:28

Richard MacCutchan

1-Jun-20 9:28

Look at the question. This is a basic classroom assignment for people with no programming background.

Run executable with arguments

Erich Ruth3-May-20 3:04

Erich Ruth

3-May-20 3:04

How can I run this command:

pdfcompress.exe "c:\currentfile.pdf" "c:\newfile.pdf"

I dont see how I can use ShellExecute to send these 2 arguments.
Is there some other command I can use along with these arguments
to execute this file? Please let me know.

Re: Run executable with arguments

Richard MacCutchan3-May-20 3:14

Richard MacCutchan

3-May-20 3:14

Use the _execl, _wexecl | Microsoft Docs[^] functions which are expressly designed for this.

Re: Run executable with arguments

Victor Nijegorodov3-May-20 4:50

Victor Nijegorodov

3-May-20 4:50

Erich Ruth wrote:
pdfcompress.exe "c:\currentfile.pdf" "c:\newfile.pdf"

I dont see how I can use ShellExecute to send these 2 arguments.

Have a look at the ShellExecuteA function (shellapi.h) - Win32 apps | Microsoft Docs :
its fourth parameter (LPCSTR lpParameters) is what you are looking for.

Visual C++/CLI

F_Square3-Apr-20 15:26

F_Square

3-Apr-20 15:26

Hello
I Am building a windows form application that accept an expression involving two variables and two numerical values for the variables through a text box.
the App is then suppose to display a functional value for the user.
I tried everything possible but keep getting error "input string was not in correct format"
Thanks in advance for your help (anyone).

Re: Visual C++/CLI

Richard MacCutchan3-Apr-20 22:00

Richard MacCutchan

3-Apr-20 22:00

F_Square wrote:
error "input string was not in correct format"

Most likely you are trying to convert some characters into a numeric, but it contains letters or special characters. However, since you have not shown us your code, or the data that it is trying to access, that is just a guess.

Re: Visual C++/CLI

F_Square7-Apr-20 18:05

F_Square

7-Apr-20 18:05

you're right
what I want the program to do is accept an expression involving two variables from the user together with values.
the program is then suppose to return a functional value as double

Re: Visual C++/CLI

Richard MacCutchan7-Apr-20 21:30

Richard MacCutchan

7-Apr-20 21:30

That sounds simple enough.

Debugging ... not able to hit breakpoint.

Member 1326109430-Mar-20 2:20

Member 13261094

30-Mar-20 2:20

Hi, 

Need technical help . I am debugging the code and getting this 

"Source information is missing from the debug information for this module" . while debuggin.

I am referring .dll in the code, that .dll is also build debug. and while debugging the code i have added (dll refered) project 
in my project. still it not loading to breakpoint.

Could you please guide me on this?

Re: Debugging ... not able to hit breakpoint.

Richard MacCutchan30-Mar-20 2:34

Richard MacCutchan

30-Mar-20 2:34

Check your project settings for the dll file to ensure that all the debugging information is being created when the file is built.

Re: Debugging ... not able to hit breakpoint.

Stefan_Lang30-Mar-20 6:17

Stefan_Lang

30-Mar-20 6:17

Whether that dll is built in debug mode doesn't matter for debugging, in spite of the name! What you need is the .pdb file for that DLL. The .pdb file contains all the references that link the compiled code segments to the original code statements. If you have the .pdb, make sure it's accessible, e. g. in the same directory as the .dll file, or in the directory of your application.

If you have that DLL in your solution, includ9ing the source code, you should check your build options and make sure a .pdb is actually built.

GOTOs are a bit like wire coat hangers: they tend to breed in the darkness, such that where there once were few, eventually there are many, and the program's architecture collapses beneath them. (Fran Poretto)

GetWindowRect wrong dimensions

lacir29-Mar-20 6:57

lacir

29-Mar-20 6:57

Hi there, I am having the big problem with getting the area of hwind with
routine GetWindowRect. Even Spy++ or his implementation returns rectangle, that is smaller than real
area. Its a some special kind of application, I am looking for some alternative to GetWindowRect,
or how can I get all the window area programmatically correct.

Re: GetWindowRect wrong dimensions

Richard MacCutchan29-Mar-20 7:23

Richard MacCutchan

29-Mar-20 7:23

The GetWindowRect function returns the correct size of any window. If your code is not working then you need to provide more details.

Re: GetWindowRect wrong dimensions

lacir29-Mar-20 7:28

lacir

29-Mar-20 7:28

Its casino application, I am using GetWindowRect standard way.

Re: GetWindowRect wrong dimensions

Richard MacCutchan29-Mar-20 20:48

Richard MacCutchan

29-Mar-20 20:48

Sorry, but that tells us nothing.

Re: GetWindowRect wrong dimensions

Victor Nijegorodov29-Mar-20 23:50

Victor Nijegorodov

29-Mar-20 23:50

Could you show your code?

Re: GetWindowRect wrong dimensions

lacir30-Mar-20 1:22

lacir

30-Mar-20 1:22

C++

HWND hwnd = FindWindow("HwndWrapper[PokerClient.exe;;518cf654-e6cb-47c5-9916-be16cbf1e961]", NULL);
GetWindowRect(hwnd, &wr);
AdjustWindowRect(&wr, WS_BORDER, true);

As I said its weird behaviour of GetWindowRect
Edited code, it was from the last operation when I was trying
get also parent window.

modified 30-Mar-20 7:59am.

Re: GetWindowRect wrong dimensions

Victor Nijegorodov30-Mar-20 1:42

Victor Nijegorodov

30-Mar-20 1:42

lacir wrote:

C++

HWND hwnd = FindWindow("HwndWrapper[PokerClient.exe;;518cf654-e6cb-47c5-9916-be16cbf1e961]", NULL);
GetWindowRect(parrent, &wr);
AdjustWindowRect(&wr, WS_BORDER, true);

You call FindWindow but then ignore the value it returns.
Then you are using some other value parrent as a windows handle to obtain the window rectangle for.

Is it what you want? Confused | :confused: