|
As a manager, I am forced to asked:
- Where are your rules of engagement (open communications among developers)?
- Where are your coding standards?
- When do you meet to do Code Reviews?
- What are considered Must and Optional points of contention in the code reviews?
In our environments, the group would start pointing out, upon reviewing his code changes,
that he is being over-zealous, and no longer adding value (Typically after asking WHY he made
those changes, and what was the loss of continuity to the other developers).
Whenever someone new joins the team, we have MORE code reviews. In fact, I usually setup DAILY
code reviews of their changes with the most Senior people, and they sit in on the Weekly code reviews
to comment and learn the process. It typically takes 2-4 weeks for someone to come up to speed. After
the first week, we do PRE-COMMIT code reviews... And when they go a decent period with out a "revert and
try again", then the leash is loosened even more, but they are encouraged to discuss best approaches with
others.
This creates a TEAM OWNERSHIP of source code environment, which helps reduce the ONE EGO knows best
Good luck with it.
PS: Since this is a lead, and it is already down this path, I would do a private meeting and simply explain the situation... "Hey, I love how committed your are to the code, but I think your overstepping a bit, which is
coming off as disrespectful to the other developers, myself included, and I fear that if it continues, the attitude will become to write LESS QUALITY code BECAUSE you are going to rewrite it after we commit it anyways. Before you got here, the team ownership felt different, and I think we would like to find some middle ground, if you are interested?"
Their response will tell you everything you need to know!
|
|
|
|
|
We do no code review...
We do kind of peer programming but we both (us 2 original developers) gave up on programming with him or asking him for any sort of improvement as it leads to nothing but you are wrong you will see...
|
|
|
|
|
The other programmer has good contact with the PM and will ask for a code review when she comes back....
|
|
|
|
|
Quote: PS: Since this is a lead, and it is already down this path, I would do a private meeting and simply explain the situation... "Hey, I love how committed your are to the code, but I think your overstepping a bit, which is
coming off as disrespectful to the other developers, myself included, and I fear that if it continues, the attitude will become to write LESS QUALITY code BECAUSE you are going to rewrite it after we commit it anyways. Before you got here, the team ownership felt different, and I think we would like to find some middle ground, if you are interested?"
Their response will tell you everything you need to know!
I will ponder those words! ...
|
|
|
|
|
People of the type "it's my way or the highway", especially when they love unnecessarily complex solutions, are always a burden for a team, I would look for a way to get rid of him, as it will always drag your team.
|
|
|
|
|
Yesterday i suddenly realized i have been thinking about a possibly dead cat in a box for 25 years now.
In my front yard i have a little pond with 2 fish in there.
But sometimes i don't see them at all for months, and sometimes i see only one.
It is just a tiny pond.
So maybe quantum mechanics isn't about cats but about fish.
Or are they just better at this?
|
|
|
|
|
Depends which fish they are.
Have you heard of Ghost Koi[^]?
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
Try putting a cat in the pond with them -- cats seem to have a good handle on this whole quantum mechanics thing.
I wanna be a eunuchs developer! Pass me a bread knife!
|
|
|
|
|
borchef wrote: But sometimes i don't see them at all for months Maybe sometimes you don't look at the pond for months?
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
|
|
|
|
|
The topic-title looked like you was still deciding for dinner
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
taking nature photos[^]
Once you lose your pride the rest is easy.
I would agree with you but then we both would be wrong.
The report of my death was an exaggeration - Mark Twain
Simply Elegant Designs JimmyRopes Designs
I'm on-line therefore I am.
JimmyRopes
|
|
|
|
|
"Behind you!"
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
Hey this photography business is dangerous stuff.
I've learned to cover my ass...literally.
You wouldn't believe what I've went through to get a shot!
If first you don't succeed, hide all evidence you ever tried!
|
|
|
|
|
|
|
A bar opened near a church. The church prayed daily against the business. Days later the bar was struck by lightning and burned to ashes. Bar owner sued the church's priests because he said the fire was the result of their prayers. The church denies all responsibilities.
So the judge commented : "It is difficult to decide the case because here we have a bar owner who believes in the power of prayer and an entire church that doesn't believe in it."
|
|
|
|
|
Not to get political, but...
Throughout history the church seldom practiced what it preached
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
|
|
|
|
|
Sander Rossel wrote: Throughout history the church people seldom practiced what they preached There, fixed it.
|
|
|
|
|
Yeah, but the church is supposed to be better than that
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
|
|
|
|
|
It's a joke, you know!
|
|
|
|
|
I know, mine wasn't
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
|
|
|
|
|
Watch a copy of this: The Man Who Sued God[^]
A lawyers boat is destroyed by lightning, and the insurance won;t pay up because it is "an act of God"...so he sues teh Church for the money.
Not the best movie in the world, but it's a good premise!
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
|
|
Do they have a Lumia version?! For better toughness, you see!
|
|
|
|