Welcome to the Lounge

Chris Maunder wrote:

since it's easy enough for us to avoid this with if statements

if (then) else

if @@error <> 0
    BEGIN
        Rollback Tran
        Return 1
    END
else
    BEGIN
        Commit Tran
        Return 0
    END

Who uses it?

DanielSheets wrote:

It can make for cleaner code if used correctly.

Bastard Programmer from Hell
If you can't read my code, try converting it here[^]

public static void SaveChartData(List<DataGridClass> dataList)
{
    int totalDelays = 0;
    int value = 0;
    string errorString = "";
    // Use a temporary file in case there are any parse errors.
    string tmpFilePath = applicationPath + "TmpChartData.csv";
    using (StreamWriter sw = new StreamWriter(tmpFilePath))
    {
        foreach (DataGridClass dgc in dataList)
        {
            if (!int.TryParse((dgc.MATL.Equals("") ? "0" : dgc.MATL), out value))
            {
                errorString = dgc.MATL;
                goto ParseError;
            }
            totalDelays += value;
            if (!int.TryParse((dgc.EQUIP.Equals("") ? "0" : dgc.EQUIP), out value))
            {
                errorString = dgc.EQUIP;
                goto ParseError;
            }
            totalDelays += value;
            if (!int.TryParse((dgc.People.Equals("") ? "0" : dgc.People), out value))
            {
                errorString = dgc.People;
                goto ParseError;
            }
            totalDelays += value;
            if (!int.TryParse((dgc.Defects.Equals("") ? "0" : dgc.Defects), out value))
            {
                errorString = dgc.Defects;
                goto ParseError;
            }
            totalDelays += value;
            if (!int.TryParse((dgc.Other.Equals("") ? "0" : dgc.Other), out value))
            {
                errorString = dgc.Other;
                goto ParseError;
            }
            totalDelays += value;
            sw.WriteLine("{0},{1},{2},{3},{4},{5},{6},{7},{8},{9},{10}",
                dgc.Year, dgc.Month, dgc.Goal, dgc.Completions, totalDelays, dgc.to,
                dgc.MATL, dgc.EQUIP, dgc.People, dgc.Defects, dgc.Other);

            totalDelays = 0;
            value = 0;
        }
    }
    // If we got this far then there were no parse errors.
    File.Copy(tmpFilePath, chartData, true);
    return;
ParseError:
    string msg = string.Format("Unable to parse data. Verify its entered correctly.\r\nValue = {0}", errorString);
    MessageBox.Show(msg, "App Name", MessageBoxButton.OK, MessageBoxImage.Error);
}

using (StreamWriter sw = new StreamWriter(tmpFilePath))
{
    foreach (DataGridClass dgc in dataList)
    {
        foreach (var thingToTest in ParsesClasses)
        {
             Results.Add( thingToTest (dgc) );
        }

Bastard Programmer from Hell
If you can't read my code, try converting it here[^]

break <label>;

dusty_dex wrote:

Exception handling will usually bog down the handled block of code.

DanielSheets wrote:

I'll be the first to admit that I dont have the experience or knowledge of 90% of the people here.

Bastard Programmer from Hell
If you can't read my code, try converting it here[^]

Eddy Vluggen wrote:

Readable code leads to maintainable projects. The better a project can be maintained, the more chances it will survive in the long run.

Kevin Marois wrote:

.... which is completely offset by his use of 'goto'.

int parseNumericValue(String text){
 int result;
 if(!int.TryParse(text == "" ? "0" : text, out result))
  throw new DataFormatException("Unable to parse data. Verify its entered correctly.\r\nValue = "+text);
 return result;
}