|
Adam Tibi wrote: It seems in the source control that you modified the source code
Indeed.
Adam Tibi wrote: It looks insulting for the other developer (the one who originally wrote the code)
Then they should have done it right the first time.
Seriously, if you're insulted because I tell you to format the code according to our agreed upon standards, then you're working in the wrong place.
|
|
|
|
|
What Karel said. Coding is, well, a love affair, and I expect code to be treated respectfully, and in part that means it should be visually pleasing, from 10 feet away, to look at.
Jeremy Falcon wrote: the coders that write messy code tend to also have messy cars and homes. It's gross.
Have you visited them???
But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience.
Marc
|
|
|
|
|
Marc Clifton wrote: Have you visited them??? Some I've hung out with over the years and some I just listened to them talk about their habits. It's amazing what you can learn if you really listen to the stuff people say.
Marc Clifton wrote: But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience. Agreed. It's just a lazy mentality. And if they're that lazy about formatting, chances are they're that lazy about learning and education.
Jeremy Falcon
|
|
|
|
|
Jeremy Falcon wrote: It's amazing what you can learn if you really listen to the stuff people say.
Aye, and listening is a skill I find very few people have. This guy[^] has some short TedTalks on the subject I found quite good, if you're interested.
Marc
|
|
|
|
|
I will check that out. Thanks.
Jeremy Falcon
|
|
|
|
|
Code that only a mother could love?
New version: WinHeist Version 2.1.0
My goal in life is to have a psychiatric disorder named after me.
I'm currently unsupervised, I know it freaks me out too but the possibilities are endless.
|
|
|
|
|
+5
Jeremy Falcon
|
|
|
|
|
How is it even possible to have badly formatted code in this day and age? You can just press ctrl+shift+alt+windows+1+F and have it automatically formatted.
|
|
|
|
|
Formatting is just one piece of the puzzle.
Jeremy Falcon
|
|
|
|
|
People can also make their bed, take out the trash, and do the dishes...but they don't.
|
|
|
|
|
|
Jeremy Falcon wrote: Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
I was going to point out the same fact, interestingly enough.
Edit: I am saying this is "fact" only because I have never seen otherwise. I am sure it really is not a fact.
|
|
|
|
|
We don't really have time for facts, we mostly go with assumptions instead.
|
|
|
|
|
I'll accept that as a fact.
Jeremy Falcon
|
|
|
|
|
You assume too much
|
|
|
|
|
It's so easy to format your code properly... Ctrl + K, Ctrl + D (in Visual Studio anyway). It doesn't delete white spaces, but it does quite a bit for you.
I'm amazed at how much badly formatted code I still see!
And in my experience if the code is poorly formatted it's poorly written.
Comments are as bad, or worse...
Person p = new Person(); NO, REALLY!? Arghhh! And I actually see those kinds of comments...
Another thing I can't stand is copy-paste programming. And much too often it's way too obvious.
The following is some production code I've had the 'pleasure' of working with (it was an obvious comment that was copy-pasted, but not edited with the code).
product.Save(); I looked at it and screamed in disgust "OH LORD, WHY DO YOU HATE ME SO!? "
My blog[ ^]
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
|
|
|
|
|
I always jokingly tease the developer who added the comment.
Make it simple, as simple as possible, but not simpler.
|
|
|
|
|
I'm with you on that code should be indented properly.
Couple of things I have to add the format of code.
Where people have excessive white space between code or methods and silly naming conventions that make code difficult to read
Every day, thousands of innocent plants are killed by vegetarians.
Help end the violence EAT BACON
|
|
|
|
|
"silly naming conventions"
like absurd Hungarian notation? There are only two variable naming conventions I prefer - the first is putting a "p" in front of a pointer:
int *pInt;
I know that's simple, but to just have it so obvious makes it easier for me to understand.
The second is adding lsbs to the variable name: "crankshaft_diameter_mm" but I'm losing my love for this. I do work in the embedded world, and all is wonderful as long as the next product version does not roll out. I'm dealing with this now - common code base, version one had 1mm lsb, next version is .1 mm. Sort of elephants the variable names.
Charlie Gilley
<italic>Stuck in a dysfunctional matrix from which I must escape...
"Where liberty dwells, there is my country." B. Franklin, 1783
“They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759
|
|
|
|
|
No I can deal with Hungarian notation as It was something that was considered good practice when I started with coding.
An example of what I meant about silly naming convetions was..
private ClientPropertyForm m_RW_CPForm = null;
it took me a while to see that this was a supposed to be a read write instance of the client property form.
Every day, thousands of innocent plants are killed by vegetarians.
Help end the violence EAT BACON
|
|
|
|
|
that's pretty gnarly, I agree. Another pet peeve I have - arbitrary abbreviations in a variable name. So, in your example:
m_RW_ClientPropertyForm becomes m_RW_ClntPrpFrm.
Charlie Gilley
<italic>Stuck in a dysfunctional matrix from which I must escape...
"Where liberty dwells, there is my country." B. Franklin, 1783
“They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759
|
|
|
|
|
ctrl e,d in xaml formats the code, I find I am doing that in all sorts of applications, word, excel, bloody annoying.
VS formats the layout for me so it is consistent and neat. Now old comments are another matter.
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
I would say that poorly formatted code makes it more difficult to maintain (depending on how badly formatted it is exactly), if it's not easy to spot a bug in the slop then it's harder to fix.
Of course, if you have something like ReSharper installed then CTRL+E+C at which point there's no excuse for sloppy code and the offender deserves a thorough booting!
Eagles may soar, but weasels don't get sucked into jet engines
|
|
|
|
|
I don't care overly much as long as it's readable and consistent.
And doesn't contain that abomination systems Hungarian, from the Redundancy Department of Redundancy.
That said, I prefer Allman style, but I'm not anal about it.
And about messy people.
I know a guy that owns a show car, and his cars and garage are in immaculate condition while his home is a complete dirty mess (unmarried).
It's what you care about. I can imagine the same to be true for coders.
|
|
|
|
|
Two things that really annoy me are sloppy formatting and leaving old commented code. One, formatting is just so easy in a number of environments. And two, if you need the old code, that is what the source control is for. Makes me wonder if a person bothers taking out the trash at home.
|
|
|
|