|
Been there, done that. Once I bought a book on how to improve your memory. I never read it and put it aside. About a year or so later I bought the same book and didn't realize it until I brought it home to put it with the rest of my books. Good times man... good times.
Jeremy Falcon
|
|
|
|
|
Yeah, that's why I got a vasectomy. Badaboom-badabing.
Marc
|
|
|
|
|
Or when you write a piece of code and it doesn't do what you intended and realize that you had wrote the same crap in the past?
New version: WinHeist Version 2.1.0
My goal in life is to have a psychiatric disorder named after me.
I'm currently unsupervised, I know it freaks me out too but the possibilities are endless.
|
|
|
|
|
Early onset of Alzheimer's, perhaps?
Seriously, yes I hate it when that happens, and I think most of us have been there once or twice.
|
|
|
|
|
I guess it really is time to reimplement tasks.
|
|
|
|
|
Reminds me of the Futurama episode where the professor decides to invent the Smelloscope, only to realize he invented one the previous year
|
|
|
|
|
And in a neater manner than the code you'd just written.
Don't you just hate this smartass - you from the past? I even had a case when I was not able to understand how my old code works.
There is only one Vera Farmiga and Salma Hayek is her prophet!
Advertise here – minimum three posts per day are guaranteed.
|
|
|
|
|
muahahahahahahahahaha
b
MCAD
---
|
|
|
|
|
I suggest early on Old-timers disease (Alzheimers)
Conveniently that now leads me to point you to an Insider News post from Kent (thanks kent, you provided some ammo to fire your boss's way - no bonus for you![^])
Prevent Alzheimer's Disease by drinking beer?[^]
Now Maunder, we all know your sorry arsed history of skipping out on beers - as an ex medical professional I'd hazard an assessment that should you not have skipped out on those beers you'd not be in the current be-codgered state you are.
i.e. its your own bloody fault coz you're a wowser
Bryce
MCAD
---
|
|
|
|
|
On the flip side, don't you love it when you get calls from support complaining that the product doesn't do something, and you get to tell them that it's been there right in front of them all along?
|
|
|
|
|
Literally just did exactly that - was so miffed with myself I came to CP to chill for a bit - saw this.
Ah well, at least I'm not alone!
PooperPig - Coming Soon
|
|
|
|
|
I am a big proponent for code reviews, prior to deployment. This is great if you work in a shop that has the people/resources to perform this and the time.
Questions
1. Who here does not believe/practice code review? If so, please explain.
2. Who here works solo and has no immediate resources to code review? If so, would you use a third party review system (community)?
Every great author has an editor, or should at least.
|
|
|
|
|
1) No code reviews. I used to, but the medication keeps the other personalities at bay...
2) I work solo, but I wouldn't want external code reviews - most of the stuff I do is proprietary or covered by NDA / corporate confidentiality agreements and I wouldn't let it into the public domain.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
|
|
|
|
|
OriginalGriff wrote: external code reviews Didn't think of that. I think external reviews are a no-no. If I were to go along with one, it would be internal only. Even without an NDA, people on the outside won't know the project. I mean sometimes, you just gotta do something stupid to pay the bills, etc.
Jeremy Falcon
|
|
|
|
|
OriginalGriff wrote: 1) No code reviews. I used to, but the medication keeps the other personalities at bay... You beat me to it. Only I was going to say that I had multiple personalities;
1) Coder guy
2) QA guy
3) Code review guy
4) Beast
New version: WinHeist Version 2.1.0
My goal in life is to have a psychiatric disorder named after me.
I'm currently unsupervised, I know it freaks me out too but the possibilities are endless.
|
|
|
|
|
I work solo and I tend to prefer it that way. I do think code reviews are great in theory, but I have yet to meet many programmers that are mature enough to think that their way isn't always the best way. A couple of remarkable devs come to mind, but sadly I don't work with them anymore. That being said, they have their place for helping to ensure standards. So, they aren't bad. I just apparently need to get out of the ghetto to meet better quality devs.
Jeremy Falcon
|
|
|
|
|
Jeremy Falcon wrote: I work solo and I tend to prefer it that way.
The internet has that effect...
|
|
|
|
|
You're not kidding. Sadly, that extends way further than programming this day in age.
Jeremy Falcon
|
|
|
|
|
1. Code reviews are good. Finding people who honestly want to do a good job with it makes them regularly useless. The best scenario is really using it to mentor folks who are trying to develop a particular skill set. I had code reviews where people argue about the correct approach to a problem... that should have been hashed out long before the code review.
2. Never... not worthwhile imo. A third party would not have the domain knowledge regarding the specific choices made for the coding effort. The only value you get is style issues... which don't matter so much with just a single coder.
|
|
|
|
|
Slacker007 wrote: Who here does not believe/practice code review? If so, please explain.
I'm not a fan of code reviews. Usually:
1. What Jeremy said. And I'll be blunt - there's very few people that I think are qualified to review my code. Sorry to sound arrogant, because I'm not actually, but it's simply been my experience that code reviews tend to digress into "what's an anonymous method?", or "what is closure?" or "gee, I didn't know that was in the .NET framework." Granted, I HAVE been myself on that side of the fence, but a lot of people never seem to find the gate to the greener pasture.
2. When I write code, I'm in two states: the part that is writing it, and the part that is critiquing it. So, I'm my own reviewer, and you'll find in my open source projects a lot of TODO comments as a result, where I make a note for my future self to clean something up. Again, very few people do this, but I think one should be one's own reviewer.
Slacker007 wrote: Who here works solo and has no immediate resources to code review?
Moi.
Slacker007 wrote: If so, would you use a third party review system (community)?
No. Again, what Jeremy said regarding proprietary stuff. That said, I have several open source projects and of course a ton of articles, and any of those are open for critique. If the community wants to give me some feedback, that would be great, I'm all for an open dialog.
Marc
|
|
|
|
|
Quote: So, I'm my own reviewer
That is by far your most important reviewer, but I must admit that I have learnt from a few constructive criticisms of the few articles I wrote here on CP!
|
|
|
|
|
Cornelius Henning wrote: but I must admit that I have learnt from a few constructive criticisms of the few articles I wrote here on CP!
I'm actually surprised how few critiques I see in general, other than when it's blatantly obvious. My most humbling experience was this[^]
Marc
|
|
|
|
|
Marc Clifton wrote: but a lot of people never seem to find the gate to the greener pasture. Interestingly enough man, I find this concept applies to so many aspects of life that extends way beyond the reach of just programming. It's like the more you know the more you accept the less you know, and are ok with that.
Marc Clifton wrote: When I write code, I'm in two states: the part that is writing it, and the part that is critiquing it. So, I'm my own reviewer, and you'll find in my open source projects a lot of TODO comments as a result, where I make a note for my future self to clean something up. Again, very few people do this, but I think one should be one's own reviewer. I do the same thing! Ha. My problem is though is getting back to those TODOs and making the changes.Marc Clifton wrote: If the community wants to give me some feedback, that would be great, I'm all for an open dialog. That's probably how I got my distaste for reviews. One of things that kept me from writing more articles on CP for instance is having to deal with the "expert kiddos" that try to sound smart critiquing your code. It's annoying arguing with them. Waste of my time actually. But, I'd want the mature peer reviews by other respectable programmers. Tough to have your cake and eat it too.
Jeremy Falcon
|
|
|
|
|
Marc Clifton wrote: What Jeremy said. And I'll be blunt - there's very few people that I think are qualified to review my code. Sorry to sound arrogant, because I'm not actually
What about as a tool to share experience; have other people look at your code as a learning and share expertise in your organization; if you are not able to explain your code to other people, then, maybe your code is not good enough to be maintained; and if, and it is possible, the person who's doing your code review is not at the same technical level as you are, then, tell the person who assigned the code review.
I'm not the best or brightest, and I like looking at other people's code, even if I need to review code that I'm not 100% at ease with.
I'd rather be phishing!
|
|
|
|
|
Maximilien wrote: What about as a tool to share experience; have other people look at your code as a learning and share expertise in your organization;
I'd be interested in that and have even contemplated the idea of putting a website together that would facilitate that exchange, both privately for proprietary code and publicly for open source reviews. Tying in with, say, GitHub, to then track changes to reviewed code, well, that could be a useful, maybe even revenue generating, tool.
Maximilien wrote: f you are not able to explain your code to other people, then, maybe your code is not good enough to be maintained;
Amen to that. One of the reasons I love writing documentation is that, in explaining what I'm doing, I often discover bugs and better ways to do it. Now, granted, some people simply struggle with communicating, but I would have to say, I have yet to see the person who, failing to communicate in English (or whatever their native tongue is) actually produce decent code.
Maximilien wrote: the person who's doing your code review is not at the same technical level as you are, then, tell the person who assigned the code review.
This involves too much of a "management" structure that, being a consultant, I happily avoid.
Maximilien wrote: I'm not the best or brightest, and I like looking at other people's code, even if I need to review code that I'm not 100% at ease with.
Same here. I have learned a lot from other people's code, here on CP and a lot on Stack Overflow and people's blogs.
Marc
|
|
|
|