The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.
Just ask him how long would it take to finish the migration of the 10,000 lines of code after his review to the Angular 4,then you can ask your friend in the business if that timeline is acceptable to him.
"Progress doesn't come from early risers – progress is made by lazy men looking for easier ways to do things." Lazarus Long
AngularJS, which contains crucial medical info & very delicate medical rules
That is huge flag that things are incorrect. AngularJS is technology for front-ends. It's really just VIEW code. But the developers have mixed in the business rules and business logic that should have been safely nestled away in the back-end with no worries about what was displaying (angularjs) the data.
That's quite terrible really. This is a big point because it proves the original devs had no idea what they were doing.
10,000 lines of code which was originally written in AngularJS
10,000 lines of code!!! Another flag that something is very likely wrong.
This is just the VIEW code and it is 10,000 lines long.
A little math puts it in context: 10,000 / 50 lines (8.5x11 - approximate) = 200 pages of code.
These are just indications that there were many bad ideas involved.
That is why devs are fleeing the project.
You should ask them:
1. Why was business logic and bus. rules mixed on the View?
2. Why did it take 10,000 lines of code?
3. Why wasn't there any oversight of the original dev?
Unless you actually want to get suckered into that project...I'd say run. Don't even offer any sort of advice, because if they're truly elephanted, they're going to see you as their savior, and next thing you know they'll be offering you what might appear at first like a big fat chunk of change but will turn out to be a living nightmare.
Of course I know nothing about the situation beyond what you've already written...but I'd be extra paranoid about this sort of thing. You've already raised the red flags yourself: Two developers have already taken a stab at it and quit...
I think the logical thing to do is to rebuild this, using Angular or React, from scratch. Probably Angular, but a NEW project that can willingly copy old code, but never accidentally inherits anything that's not been vetted
AngularJS is in maintenance, it should never have been used. they should never revert. There is no such thing as AngularJS code that can't be ported to Angular4 (although it's up to 7, why are they on 4?)
Have your friend walk away, sue the crap out of the software company to try and get funds back. Raddevus makes an excellent point - this project has been designed WRONG it is never going to come to fruition. Cut your losses and start again. The absolutely worst thing your friend can do is to invest another cent in anything but legal action against the software house.
There are many of us out there who work for small software houses or are single developers but your friend got a lousy one, next time he needs to do some due diligence on the quality of the software house.
Never underestimate the power of human stupidity -
I'm old. I know stuff - JSOP
Than any man could bear
Rescue me before I fall into despairrow...
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle