|
Visual Studio's "code suggestions" are atrocious. "Let me nag you to use all the latest language features and make actual stylecop rules get buried under spurious suggestions about not using explicit tuples"
Worse, they can change the semantics of the code.
And I'm a stickler about having *no* messages on a final build, so this stuff is just nuts. I don't want to turn it off - i just want it to be sane.
Look at this mess:
if (null == rule1) throw new ArgumentNullException("rule1");
if (null == rule2) throw new ArgumentNullException("rule2");
Kind = kind;
Rule1 = rule1;
Rule2 = rule2;
Symbol = symbol;
Kind = kind;
Rule1 = rule1 ?? throw new ArgumentNullException("rule1");
Rule2 = rule2 ?? throw new ArgumentNullException("rule2");
Symbol = symbol;
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
You can change it in Tools >> Options >> Text Editor >> C# >> Code Style under the null checking section.
I'm guessing they did this so that people would actually use the new language features they're adding to C#...
|
|
|
|
|
thanks.
if the language features are good why should they need to be nagware? 
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
Is that a constructor, or a method?
If it's a ctor, it's sort-of OK - if the ctor throws, then you'll only ever have access to the instance from the finalizer (if any), so you don't need to worry about partially-constructed objects.
If it's a method, then it's just plain wrong, and should be reported as a bug.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
in this case it's a constructor but it does it in ctors and methods both. it gives no care as to where it suggests the code change.
but yeah, i take your point that for ctors it doesn't matter (much) but in general changing the order of execution from what the developer wrote is a bad thing, if it changes the semantics.
I don't believe a lot of thought was put into all this even though i basically understand why they did it.
but to go and change the code semantics... anything else i could almost understand, but this could introduce some very nasty bugs.
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
Who mocks the mocker?
If I were ever to write that (I wouldn't), I'd put the tests for null in an #if DEBUG . 
|
|
|
|
|
for public facing APIs, when a lack of a null check will result in a hard to find error later, as is often the case with constructor assignments, in my experience, I like to put null checks in.
Otherwise I'm kind of a minimalist when it comes to throwing errors. I try to delegate that to the code i call where possible. Sometimes though, I need to intervene to throw an error that makes sense, and that's when I do so.
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
Gawd. The VS suggestion is taking a good idea (the ?? operator) and mangling it into an aesthetic and semantic mess. Not to mention also changing the behavior of the code, as you pointed out.
|
|
|
|
|
i sooo agree with this. I quite like the ?? operator when i remember to use it but in this case ugh. 
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
The same people who think "var" for everything is a good idea.
- I would love to change the world, but they won’t give me the source code.
|
|
|
|
|
guilty.
When I was growin' up, I was the smartest kid I knew. Maybe that was just because I didn't know that many kids. All I know is now I feel the opposite.
|
|
|
|
|
I've put in a ticket over this, because it clearly does not follow ms' current imperatives.
Obviously, you've only provided small snippets, but I still did not see a single emoji in any of the suggested text.
That is Not Good Enough.
I wanna be a eunuchs developer! Pass me a bread knife!
|
|
|
|
|
You can change the default "ruleset" I know I deactivated tons of warning at home... I do find so many of them moronic as well. And only a few can be interesting at best (i.e. NOT mandatory).
Not sure where exactly you change the default rule set..
But in a normal .NET Framework project, expand project References, right click on Analyzers, you can change which rule will be used.
Aside I quite like that new syntax 
|
|
|
|
|
Is Shoplifters Anonymous dedicated to helping people to help themselves?
Sent from my Amstrad PC 1640
Never throw anything away, Griff
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
So, you steal posting a loot of these puns !
| Ravings en masse^ |
|---|
| "The difference between genius and stupidity is that genius has its limits." - Albert Einstein | | "If you are searching for perfection in others, then you seek disappointment. If you are seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010 |
|
|
|
|
|
Yes, and the founder of group is Miss Demeanor, I hear she stole the idea.
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
|
|
|
|
|
FYI: there's a support groups for them if they want to reform, counselors 12 step program and so on.
... well used to be 12 steps, you know, relapses...
Message Signature
(Click to edit ->)
|
|
|
|
|
I used to suffer from Kleptomania - but I took something for it.
- I would love to change the world, but they won’t give me the source code.
|
|
|
|
|
Yeah, I heard there was a pilfer that.
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
|
|
|
|
|
That one gave me a lift!
Socialism is the Axe Body Spray of political ideologies: It never does what it claims to do, but people too young to know better keep buying it anyway. (Glenn Reynolds)
|
|
|
|
|
Never tell a joke to a kleptomaniac, they take everything literally.
|
|
|
|
|
Marketers consider kleptomaniacs to be a target demographic. Who else would buy booster shoes?
Freedom is the freedom to say that two plus two make four. If that is granted, all else follows.
-- 6079 Smith W.
|
|
|
|
|
I'm looking for a good level hardware site (mostly not the kind you find in a modern computer) to help me with an idea I have (searching the web left me with way to much options)...
Any suggestions?
"The only place where Success comes before Work is in the dictionary." Vidal Sassoon, 1928 - 2012
|
|
|
|
|
|
Not old. More like 'not common'...
"The only place where Success comes before Work is in the dictionary." Vidal Sassoon, 1928 - 2012
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
