|
"CODE REVIEW" - This is a phrase that my boss uses everyday. I am not sure what it exactly means. So everytime I make a work log, I put in "Code Review" against my spare time. Now I am 110% efficient and he likes that.
|
|
|
|
|
Here's a Wikipedia[^] definition.
Where I work, code reviews are done for every check-in (sometimes after the fact). Although the devs I work with are a bright and seasoned bunch, that doesn't exclude anyone from a code review. Our code reviews mainly focus on performance and security and serve as a "second pair of eyes" to help catch the odd bug. Reviewers rarely end up suggesting rewriting comments or renaming identifiers, because we have a set of guidelines already in place that addresses that sort of stuff. Our code reviews usually take no more than 10-15 minutes and are almost always limited to the developer and a single reviewer.
I've learned a lot from having my own code reviewed.
/ravi
|
|
|
|
|
Once we tried to do code review, but because of the nature of the code we have to gave up - it's mostly write-only code... 
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
Brrrr! :shudder:
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
Tell me about that... I live it every day...
All of our code base is in C# now (it's over 5 million lines of code), but when reading parts of it I still can smell COBOL from 20 years before...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
Could you show an example of that?
|
|
|
|
|
Do you know COBOL's STRING statement?
string Msg = FName + " " + LName + ", " + City;
is almost identical to
STRING FNAME SPACE LNAME ", " CITY DELIMITED BY SIZE INTO MSG.
We also have a lot of code using invalid value initialization for variables, like
int Msl = -1;
While in new code we use null...
In COBOL we used LOW-VALUE as no NULL was available...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
|
|
|
|
|
The code I have been reviewing since the past few days is a VBA application. The developers used a lot of xml files to store all the conditional statements and dynamic data.
The VB code contains subs like Call_ARF_something_something_something.
I mean the subs are sctually named like that. So if there is call statement, it looks like
Call Call_ARF_something.
Apart from that, based on actual selections,new xml nodes are formed(by concateneting underscore and selections) and then the dynamic data is recorded inside those nodes.
I found nodes like XML_Node_ARF_PFG_PFGOption_CFG_CFGOption_(......... and so on)
It's a nightmare for me since there is no documentation and I have to figure out the business logic from all of this.
|
|
|
|
|
Abhijit Ghosh (Subho) wrote: there is no documentation
Set pet peeve #1 here[^]. 
/ravi
|
|
|
|
|
At least it isn't APL!
On a side note, I know someone who can READ APL code!
No joke, he even demonstrated it with random code someone who was visiting from Germany came up with!
What do you get when you cross a joke with a rhetorical question?
|
|
|
|
|
APL is not that bad if you know it. That's like saying Hungarian is a bad language because not many people can understand it.
|
|
|
|
|
|
Facebook is that way =>
There are only 10 types of people in the world, those who understand binary and those who don't.
|
|
|
|
|
|
A masterpiece!
How they manage to incorporate the duck dance in such an amazing piece of music defies me...
“That which can be asserted without evidence, can be dismissed without evidence.”
― Christopher Hitchens
|
|
|
|
|
John was on his deathbed and gasped pitifully, "Give me one last request, dear," he said.
"Of course, John," his wife said softly.
"Six months after I die," John said, "I want you to marry Bob."
"But I thought you hated Bob," she said..
With his last breath John said, "I do!"
|
|
|
|
|
But then Bob gets the uber-Mustang.
You'll never get very far if all you do is follow instructions.
modified 26-Jul-14 22:18pm.
|
|
|
|
|
I think you are mistaken. Nobody hates ![Green Alien | [Alien]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/alien.gif) . 
Soren Madsen
"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty
|
|
|
|
|
Plot twist, the wife is a very nice lady, but she hates Johns guts!
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
|
|
|
|
|
In a train compartment, there are three men and a ravishing young girl. The four passengers join in
conversation, which very soon turns to the erotic.
Then, the young girl proposes, "If each of you will give me $1, I will show you my legs."
The men, charmed by this young girl, all pull a buck out of their wallet. And then the girl pulls us
her dress a bit to show her legs.
Then she says, "If each of you gentlemen will give me $10, I'll show you my thighs," and men being
what they are, they all pull out a ten dollar bill.
The girl pulls up her dress all the way to her undies.
Conversation continues, and the men, a bit excited, have all taken off their coats. Then the young girl
says, "If you will give me $100, I will show you where I was operated on for appendicitis."
Naturally, all three fork over the money, and then the girl turns to the window and points to a
hospital in the distance and says,
"Right over there!"
|
|
|
|
|
My family is doing a Garage sale today to get rid of a bunch of stuff we don't need. This is going to be fun, as the forecast for today is Rain with a chance of more Rain and some Thunderstorms. Figures.
What do you get when you cross a joke with a rhetorical question?
|
|
|
|
|
Well it's a good thing you have a garage to have your sale in.
|
|
|
|
|
Why are you selling your garage?
It sounds like you could use it to keep your stuff dry while you try to sell that.
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
|
 Yeah. It does sound like that.
And we have had no rain whatsoever today (i.e. after 8, when the sale started). Just about 90% humidity and high heat (at least it feels like this). Ugh.
What do you get when you cross a joke with a rhetorical question?
|
|
|
|
|
Likewise! About 30C here with no wind at all, and high humidity, so hot and sticky. Hard-to-sleep weather 
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
