Re: Handle Exception In Thread - C# Discussion Boards

Re: Scheduled Services Architecture

29-Mar-17 4:15

If I understand what you're saying.. it would mean creating the thread and error handling INSIDE the service classes, correct?

If so, it puts the responsibility on individual developers to follow the pattern to make it work.

Classes implementing IService only really need to have some basic info (Id, Name) and Start and Stop methods that the Windows Service can call into.

Am I understanding what you're saying here?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Kevin Marois29-Mar-17 4:19

Handle Exception In Thread

29-Mar-17 4:19

Can you provide a small example to illustrate what you're saying here?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Kevin Marois27-Mar-17 9:35

27-Mar-17 9:35

I'm creating a class instance using Activator.CreateInstance

var serviceClass = Activator.CreateInstance(type) as IInstrumentService;
_services.Add(serviceClass);

Then, later, I start each service. I want to catch any exceptions that occur in the service class. I was thinking about something like

private void StartAllServices()
{
    foreach (var service in _services)
    {
        Task.Factory.StartNew(() =>
        {
            service.Start();

        }).ContinueWith(task =>
        {
            if (task.Exception != null)
            {
                // Handle the exception here
            }
        });
    }
}

Any reason this would not work? Know of a better way to do this?

Thanks

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Rob Philpott28-Mar-17 0:01

Rob Philpott

28-Mar-17 0:01

Hi Kevin,

So does your service have a Stop() method as well? Normally a start method would be kind of asynchronous in nature, kicking off its own threads, opening network listeners and that sort of thing, so the test you have there looks like it would catch exceptions in just that part.

Or is it that Start() method is more of a Run()? By which I means it runs until completion, possibly days later?

A good catch all would be this (lifted from Visual Studio right in front of me):

// catch any unhandled exceptions
AppDomain.CurrentDomain.UnhandledException += CurrentDomainUnhandledException;

Regards,
Rob Philpott.

Kevin Marois28-Mar-17 5:55

28-Mar-17 5:55

Yes, the services have a Stop method. The services are independent of each other. They can each do entirely different things.

There will be a schedule in place that each services runs under. One may run only once, while another may run regularly at different days & times.

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Nathan Minier28-Mar-17 1:35

Nathan Minier

28-Mar-17 1:35

Just a quick note:

Passing a cancellation token to the Task.Factory.StartNew() will give you an external control for your child tasks.

Otherwise I've been playing with the same construct for a component host (except that I hydrate my components via a MEF ImportMany) and it works very well.

"There are three kinds of lies: lies, damned lies and statistics."
- Benjamin Disraeli

Richard Deeming28-Mar-17 1:43

Richard Deeming

28-Mar-17 1:43

The as operator can return null. If you're not sure whether the type implements the interface, you should check for null before you add the service to the list. If you are sure, or you want an exception if it doesn't, then switch to using a cast instead:

var serviceClass = Activator.CreateInstance(type) as IInstrumentService;
if (serviceClass != null) _services.Add(serviceClass);

// Or:
var serviceClass = (IInstrumentService)Activator.CreateInstance(type);
_services.Add(serviceClass);

You could pass TaskContinuationOptions.OnlyOnFaulted, which would remove the need to test whether the task has an exception.

.ContinueWith(task =>
{
    // Handle the exception here
}, TaskContinuationOptions.OnlyOnFaulted);

Also, Task.Run is generally preferred over Task.Factory.StartNew:
Task.Run vs Task.Factory.StartNew | Parallel Programming with .NET[^]

Task.Run(() => service.Start()).ContinueWith(...

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

C# Read random line

Pavlex426-Mar-17 10:00

26-Mar-17 10:00

How to read random line from text file that startswith * and lines below him that are related to him?

I have created to get random line with question using commands below, but after that it doesn't read lines below him that are related to him,instead of that he read lines from beggining!!!

var questions =
File.ReadLines(filePath)
.Where(line => line.StartsWith("*")).ToList();

var rng = new Random();
var myRandomQuestion = questions[rng.Next(questions.Count)].Substring(1);
label1.Text = myRandomQuestion;

My text file has 15000 lines.Lines with * character are questions and lines below them are terms relating to that question.

This is one part of file:

*Planete i njihovi sateliti
Zemlja=Mesec
Mars=Fobos
Jupiter=Io
Saturn=Titan
Uran=Titania
Neptun=Triton
Pluton=Haron
Merkur=Nema satelit

*Čuveni parovi iz umetnosti
Hamlet=Ofelija
Ruslan=Ljudmila
Zevs=Hera
Otelo=Dezdemona
Paris=Helena
Abelard=Eloiza
Paolo=Frančeska
Lanselot=Ginevra

*Latinski pojmovi
Kvalifikacija=Osposobljenost
Karantin=Izolacija
Radijacija=Zračenje
Ratifikacija=Potpisivanje
Racionalan=Razuman
Reakcija=Otpor
Realizacija=Ostvarenje
Rekapitulacija=Ponavljanje

*Poveži aktuelne predsednike sa državama u kojima vladaju.
Trajan Basesku=Rumunija
Karolos Papuljas=Grčka
Đorđo Napolitano=Italija
Tomas Hendrik Ilves=Estonija
Danilo Tirk=Slovenija
Dimitris Hristofias=Kipar
Tarja Halonen=Finska
Meri Mekelis=Irska

*Francuski gradovi
Bordeaux=Bordo
Auxerre=Okser
Toulouse=Tuluz
Nantes=Nant
Marseille=Marselj
Dijon=Dižon
Limoges=Limož
Chateauroux=Šatero

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
 
using System.Collections.Specialized;
using System.IO;
 
namespace Slagalica
{
    public partial class Spojnice : MetroFramework.Forms.MetroForm
    {
        public Spojnice()
        {
            InitializeComponent();
        }
 
        string igra;
        int j = 0;
        Button[] button;
        private void Spojnice_Load(object sender, EventArgs e)
        {
            Random r = new Random();
            int indeks;
            igra = "spojnice";
            StreamReader sr = new StreamReader(igra + ".txt");
            string[] niz1 = new string[8];
            string[] niz2 = new string[8];
 
            //label1.Text = sr.ReadLine();
 
            var questions = File.ReadLines(igra + ".txt").Where(line => line.StartsWith("*")).ToList();
            var myRandomQuestion = questions[r.Next(questions.Count)].Substring(1);
            label1.Text = myRandomQuestion;
 
            button = new Button[] { button1, button2, button3, button4, button5, button6, button7, button8
            ,button9, button10, button11, button12, button13, button14, button15, button16 };
            for (int i = 0; i < 8; i++)
            {
                string s = sr.ReadLine();
                niz1[i] = s.Substring(0, s.IndexOf('='));
                indeks = r.Next(1, 9);
                bool ind = true;
                while (ind)
                {
                    ind = false;
                    switch (indeks)
                    {
                        case 1:
                            if (button9.Text == "")
                                button9.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                        case 2:
                            if (button10.Text == "")
                                button10.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                        case 3:
                            if (button11.Text == "")
                                button11.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                        case 4:
                            if (button12.Text == "")
                                button12.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                        case 5:
                            if (button13.Text == "")
                                button13.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                        case 6:
                            if (button14.Text == "")
                                button14.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                        case 7:
                            if (button15.Text == "")
                                button15.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                        case 8:
                            if (button16.Text == "")
                                button16.Text = s.Substring(s.IndexOf('=') + 1);
                            else
                            {
                                indeks = r.Next(1, 9);
                                ind = true;
                            }
                            break;
                    }
                }
            }
           
            for (j = 0; j < 8; j++)
                button[j].Text = niz1[j];
            for (j = 0; j < 16; j++)
                button[j].BackColor = Color.DodgerBlue;
 
           label1.BackColor = Color.DodgerBlue;
            timer1.Enabled = true;
        }
 
        int ukupno = 0, pojam = 0;
 
        private void RacunajZaDugme(Button dugme1, Button dugme2, string igr)
        {
            string s1 = dugme1.Text + "=" + dugme2.Text;
            StreamReader sr = new StreamReader(igr + ".txt");
            string s2 = sr.ReadLine();
            while (!sr.EndOfStream)
            {
                s2 = sr.ReadLine();
                if (s1 == s2)
                {
                    ukupno += 4;
                    dugme1.BackColor = Color.Green;
                    dugme2.BackColor = Color.Green;
                    break;
                }
                if (s1 != s2)
                {
                    dugme1.BackColor = Color.Red;
                }
            }
            pojam++;
            if (pojam == 8)
            {
                KrajIgre();
                pojam = 0;
                ukupno = 0;
            }
        }
 
        private void KrajIgre()
        {
            timer1.Enabled = false;
 
            button = new Button[] { button1, button2, button3, button4, button5, button6, button7, button8
            ,button9, button10, button11, button12, button13, button14, button15, button16 };
            for (j = 0; j < 16; j++)
                button[j].BackColor = Color.White;
            for (j = 0; j < 16; j++)
                button[j].Text = "";
 
            MessageBox.Show("Osvojili ste " + ukupno + " poena ! ! !", "Kraj igre");
 
            label1.Text = "";
            label1.BackColor = Color.DarkBlue;
        }
 
        int i;
 
        private void button2_Click(object sender, EventArgs e)
        {
            i = 2;
        }
 
        private void button3_Click(object sender, EventArgs e)
        {
            i = 3;
        }
 
        private void button4_Click(object sender, EventArgs e)
        {
            i = 4;
        }
 
        private void button5_Click(object sender, EventArgs e)
        {
            i = 5;
        }
 
        private void button6_Click(object sender, EventArgs e)
        {
            i = 6;
        }
 
        private void button7_Click(object sender, EventArgs e)
        {
            i = 7;
        }
 
        private void button8_Click(object sender, EventArgs e)
        {
            i = 8;
        }
 
        private void button9_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button9, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button9, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button9, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button9, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button9, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button9, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button9, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button9, igra);
                    break;
            }
        }
 
        private void button10_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button10, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button10, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button10, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button10, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button10, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button10, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button10, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button10, igra);
                    break;
            }
        }
 
        private void button11_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button11, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button11, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button11, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button11, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button11, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button11, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button11, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button11, igra);
                    break;
            }
        }
 
        private void button12_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button12, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button12, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button12, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button12, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button12, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button12, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button12, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button12, igra);
                    break;
            }
        }
 
        private void button13_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button13, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button13, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button13, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button13, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button13, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button13, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button13, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button13, igra);
                    break;
            }
        }
 
        private void button14_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button14, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button14, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button14, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button14, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button14, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button14, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button14, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button14, igra);
                    break;
            }
        }
 
        private void button15_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button15, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button15, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button15, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button15, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button15, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button15, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button15, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button15, igra);
                    break;
            }
        }
 
        private void button16_Click(object sender, EventArgs e)
        {
            switch (i)
            {
                case 1:
                    RacunajZaDugme(button1, button16, igra);
                    break;
                case 2:
                    RacunajZaDugme(button2, button16, igra);
                    break;
                case 3:
                    RacunajZaDugme(button3, button16, igra);
                    break;
                case 4:
                    RacunajZaDugme(button4, button16, igra);
                    break;
                case 5:
                    RacunajZaDugme(button5, button16, igra);
                    break;
                case 6:
                    RacunajZaDugme(button6, button16, igra);
                    break;
                case 7:
                    RacunajZaDugme(button7, button16, igra);
                    break;
                case 8:
                    RacunajZaDugme(button8, button16, igra);
                    break;
            }
        }
 
        private void button1_Click(object sender, EventArgs e)
        {
            i = 1;
        }
    }
}

Dave Kreskowiak26-Mar-17 12:52

Dave Kreskowiak

26-Mar-17 12:52

I'm not reading that entire code dump. Most of is probably not related to the problem.

You can't randomly seek to a specific "line" in a text file. You have to read through it, looking for the lines that start with "*". You can do ignore a random number of them but you might want to initialize some structure with the data from the file, reading through the entire file looking for the "*" lines and recording which line you found it. You can then pick one at random, and get the line number to skip to. You have to go back re-read the file, counting lines until you get to the one you want.

When you get the line with the "*" in it, you start reading and recording the data from each line, these are your answers, until you get to another line with a "*" in it.

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

Garth J Lancaster26-Mar-17 13:50

Garth J Lancaster

26-Mar-17 13:50

I would have approached this issue 'a bit differently' - it depends if you want to have to whole file in memory, or what you wish to optimise ...

Assuming you dont want the whole file in memory, you read the file multiple times

In the OnLoad event for the WinForm, I would fire off a Background thread, to parse the file to extract all the questions, their start lines in the file, the number of answers, to a data structure - possible an array of struct(string question, int start line, int num answers) - this is your 'index'

once you have a random number, you get that element from the index and use the start line and num answers to locate the answers in the file

If you can keep the entire set of data in memory, then you parse the file to something like array of struct(string question, List<string> answers), which means once you have your random number, you can jump straight to the index and get the question and answers

OriginalGriff26-Mar-17 21:37

OriginalGriff

26-Mar-17 21:37

I would suggest that the best thing to do would be to change your file format.
If you used each line to hold a single question, together with it's possible answers, separated by '|' characters:

Planete i njihovi sateliti|Zemlja=Mesec|Mars=Fobos|Jupiter=Io|Saturn=Titan|Uran=Titania|Neptun=Triton|Pluton=Haron|Merkur=Nema satelit
Čuveni parovi iz umetnosti|Hamlet=Ofelija|Ruslan=Ljudmila|Zevs=Hera|Otelo=Dezdemona|Paris=Helena|Abelard=Eloiza|Paolo=Frančeska|Lanselot=Ginevra
...

Then the problem becomes trivial:
Use File.ReadAllLines to read the whole file into an array of strings: each element of the array is a question together with it's answers, so selecting a random question is a trivial use of the Random class.
Each question and answer can be easily split out into an array of strings using string.Split - the first element of the array is the question, the rest of them are possible answers.

But do yourself a favour: stop using Visual Studio default names for everything - you may remember that "TextBox8" is the mobile number today, but when you have to modify it in three weeks time, will you then? Use descriptive names - "tbMobileNo" for example - and your code becomes easier to read, more self documenting, easier to maintain - and surprisingly quicker to code because Intellisense can get to to "tbMobile" in three keystrokes, where "TextBox8" takes thinking about and 8 keystrokes...

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Pavlex426-Mar-17 21:52

26-Mar-17 21:52

How to change format?
My text file has 15000 lines!!!!

OriginalGriff26-Mar-17 22:12

OriginalGriff

26-Mar-17 22:12

Simple!
Write a quick app to do it for you. Something like this should do the donkey work:

private void ConvertFile(string inPath, string outPath)
    {
    string[] inData = File.ReadAllLines(inPath);
    List<string> outData = new List<string>();
    StringBuilder sb = new StringBuilder();
    foreach (string line in inData)
        {
        if (line.StartsWith("*"))
            {
            if (sb.Length > 0)
                {
                outData.Add(sb.ToString());
                sb.Clear();
                }
            sb.Append(line.Substring(1));
            }
        else
            {
            sb.Append("|");
            sb.Append(line);
            }
        }
    if (sb.Length > 0)
        {
        outData.Add(sb.ToString());
        }
    File.WriteAllLines(outPath, outData);
    }

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Pavlex426-Mar-17 23:41

26-Mar-17 23:41

I have added questions and answer to list!How to get random question with it's answers from the list?

string[] data = File.ReadAllLines("spojnice1.txt");
            List<string> questions = new List<string>();
            foreach (string line in data)
                questions.Add(line);

Pete O'Hanlon26-Mar-17 23:45

Pete O'Hanlon

26-Mar-17 23:45

You know the number of questions, so you should be easily able to use the Random class to pick the appropriate question. And I'm pretty sure that Griff recommended that you used a parent-child relationship so you added only the lines starting with * to the questions list, and then you would expose a list of answers as a child of the question.

This space for rent

Pavlex427-Mar-17 0:03

27-Mar-17 0:03

He told me to change to this format text file:

Planete i njihovi sateliti|Zemlja=Mesec|Mars=Fobos|Jupiter=Io|Saturn=Titan|Uran=Titania|Neptun=Triton|Pluton=Haron|Merkur=Nema satelit
Čuveni parovi iz umetnosti|Hamlet=Ofelija|Ruslan=Ljudmila|Zevs=Hera|Otelo=Dezdemona|Paris=Helena|Abelard=Eloiza|Paolo=Frančeska|Lanselot=Ginevra
...

When I change to that format I cannot add lines starting with * to list!!!

Pete O'Hanlon27-Mar-17 0:07

Pete O'Hanlon

27-Mar-17 0:07

Sigh. Let me simplify this for you.

Griff has suggested that you break your original list down (the ones that originally started with * being your question). These then have a number of answers stored as a series of pipe delimited fields. That's your parent/child relationship there.

The lines originally marked with * will now be the first entry in this pipe delimited list.

You know how many entries you have in this list, so you use this as the upper bound of the Random number.

That's it - the code is trivial. To make things more random, don't forget to seed the Random when you instantiate it. Read the documentation for details on how to do this.

This space for rent