|
|
I am trying to revive a program that I wrote in years 2001 to 2005 for my old Borland C++ 4.51 compiler. The library functions that its compiled programs called, always ran in the mode of a character = 8 bits, not 16 bits. As this program largely handles text, not numerical values, it will have to compile to run with char = 8 bytes everywhere. For example, in this section:
int rundialogbox(HWND wn, HINSTANCE I, char*name,
BOOL CALLBACK /*_export*/ proc(HWND db, UINT M, WPARAM S, LPARAM L)) {
DLGPROC dp = MakeProcInstance((DLGPROC)proc, I);
int i = DialogBox(I, name, wn, dp); FreeProcInstance(dp); return i;}
I had type mismatch error of the type char* :: WCHAR*, until in menu Project / Properties I set the character mode from Unicode to Not Set; then this section compiled OK.
Whereupon, the next section
void diprintf(HWND db,int c,char*fmt,...){
char C[256];
vsprintf(C,fmt,(&fmt)+1);
SetDlgItemText(db,c,C);
};
failed with this error:
1>faces.cpp(80): error C2664: 'int vsprintf(char *const ,const char *const ,va_list)': cannot convert argument 3 from 'char **' to 'va_list'
1> faces.cpp(80): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
I replaced `char C[256];` by `WCHAR C[256];`, and compilation error still happened.
Does my Visual C++ still have an 8-bit-char-mode set of library functions? If so, how to call them?
modified 15-Aug-18 7:28am.
|
|
|
|
|
Anthony Appleyard wrote: Does my Visual C++ still have an 8-bit-char-mode set of library functions? If so, how to call them?
The "Not Set" should allow the project to use the ANSI functions. You've already made the correct change.
Anthony Appleyard wrote:
void diprintf(HWND db,int c,char*fmt,...)
{
char C[256];
vsprintf(C,fmt,(&fmt)+1);
SetDlgItemText(db,c,C);
};
failed with this error:
1>faces.cpp(80): error C2664: 'int vsprintf(char *const ,const char const ,va_list)': cannot convert argument 3 from 'char *' to 'va_list'
1> faces.cpp(80): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
The debugger error tells you exactly what the problem is. The third argument needs to be a va_list. Those old unsafe typecasts are no longer legal.
You can probably fix it with something like:
void diprintf(HWND db,int c,char*fmt,...)
{
char C[256];
va_list arg_ptr;
va_start(arg_ptr, fmt);
vsprintf(C,fmt,arg_ptr);
SetDlgItemText(db,c,C);
};
The function looks unsafe. The function will overflow if the variable-argument list results in a string longer than 256 char. You should consider using the safer vsprintf_s.
vsprintf_s(C,256,fmt,arg_ptr);
Best Wishes,
-David Delaune
|
|
|
|
|
Thanks. It compiled OK. What should this become?
int discanf(HWND db, int c, char*fmt, ...) {
char C[256];
GetDlgItemText(db, c, C, 256);
C[255] = 0;
return vsscanf(C, fmt, (&fmt) + 1);
}
|
|
|
|
|
Anthony Appleyard wrote: What should this become?
Come on man, this is something that you can easily figure out. You've been a member here for over 10 years.
You know the old Chinese proverb?
If you give a man a fish he is hungry again in an hour. If you teach him how to catch a fish you feed him for his lifetime.
You've already had your daily fish. I highly encourage you to figure it out yourself. If you get stuck feel free to come back for more fish.
Best Wishes,
-大衛王
|
|
|
|
|
For a start having an int variable called c, and a char array called C is bad enough in the same module. But in the same function it is beyond ridiculous. Use proper meaningful unique names for all your variables.
|
|
|
|
|
Sorry. I started computer programming in the late 1960's, when computer storage was much smaller (80,000 words memory was big), under early compilers such as Atlas Autocode and Basic, and I got accustomed to one-letter and two-letter variable names.
Thanks for your help.
modified 15-Aug-18 12:02pm.
|
|
|
|
|
Anthony Appleyard wrote: I got accustomed to one-letter and two-letter variable names.
I confirmed that it compiles in Visual Studio 2017. I am calling it "C Notation" naming convention.
#define C 256
int Ƈ(HWND č, int c, char* Ç, ...)
{
char ₵[C];
va_list Ĉ;
va_start(Ĉ, Ç);
GetDlgItemText(č, c, ₵, C);
₵[C] = 0;
return vsscanf(₵, Ç, Ĉ);
}
If you use this... your coworkers will pick you up and throw you out of the office.
Best Wishes,
-David Delaune
|
|
|
|
|
There is something truly sublime about that code. 
|
|
|
|
|
I started in 1966 and the only time I used single letter names was when coding in Fortran IV.
|
|
|
|
|
Hi, I read a block of code, like:
class Graph
{
public:
int V; vector<int> *adj;
Graph(int V);
void addEdge(int x, int y);
bool isRoute(int x, int y);
};
Graph::Graph(int V)
{
this->V = V;
this->adj = new vector<int>[V];
}
void Graph::addEdge(int x, int y) {
adj[x].push_back(y);
}
int main() {
Graph g(6);
g.addEdge(5, 2);
g.addEdge(5, 0);
g.addEdge(4, 0);
g.addEdge(4, 1);
g.addEdge(2, 3);
g.addEdge(3, 1);
}
I wonder the adj is a pointer that points to a Vector object, and a vector object I think it's like an one-dimensional array, but the addEdge() operation, adj[x].push_back(y),it make another array[x,y].
in Main(), the structure of the vector object, seems like:
[5,2,0]
[4,0,1]
[2,3]
[3,1]
Then this is not an one-dimensional array.so this is a Vector object, or 4 vector objects?
Thanks
|
|
|
|
|
Not sure what any of that means. But why not use a POINT structure (or create your own), and then you can have a vector of points?
struct POINT
{
int x;
int y;
};
vector<POINT> pointList;
|
|
|
|
|
focusdoit wrote: I wonder the adj is a pointer that points to a Vector object
No, it's an array of vectors with V elements. So it's a two-dimensional data structure.
|
|
|
|
|
vector<int> *adj; //adjacency list
is it point to an Vector object?
|
|
|
|
|
Yes, it's a pointer to a vector, but you are trying to assign an array of vectors to it. Why not use the suggestion I offered above?
|
|
|
|
|
Thanks, I am reading the program.
Just try to understand why a pointer to an array, be used as an array of vectors.
|
|
|
|
|
It's not a pointer to an array, it's a pointer to a vector (singular). If you want a pointer to an array of vectors then you need something like:
vector<int> *varray[];
Then each element of varray will need to be a vector<int>*, that is, a pointer to a vector. A vector is an instance of the vector class so each pointer will point to a single vector.
|
|
|
|
|
is it similar to a pointer that points to an integer.
like:
int a = 0;
int *ip = &a;
then (ip+1) point to an integer too. but do we need to allocate memory space to it?
|
|
|
|
|
Yes, you must always allocate memory if you intend to read from or write to it. A pointer declaration does not allocate any memory, it is just a single variable that can be used to address individual items. But the memory space to hold the items must be allocated before you use the pointer.
|
|
|
|
|
Memory is allocated in the constructor:
this->adj = new vector<int>[V];
|
|
|
|
|
|
Hi. How can I retrieve the HWND of a control inside CDialog, and this control has the focus ? To get the next HWND control I can use GetNextWindow[^], but I can retrieve the HWND of the next or previous control that has the focus ...
In fact, I wish to use (while I am in CDialog):
HWND hWnd = ::FindWindow(NULL, _T("Some dialog"));
if(NULL != hWnd)
{
::SetWindowText(GetFocus()->GetSafeHwnd(), sText);
}
but without GetFocus ...
modified 10-Aug-18 9:32am.
|
|
|
|
|
_Flaviu wrote: How can I retrieve the HWND of a control inside CDialog, and this control has the focus ?
Does the control have a member variable associated with it?
_Flaviu wrote:
but without GetFocus ...
What is your aversion to using GetFocus()?
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
modified 10-Aug-18 10:00am.
|
|
|
|
|
No. In fact, it a CDialog which belong to another app.
|
|
|
|
|
"What is your aversion to using GetFocus()?"
Because this dialog is not belong to my app, and if there is another window in foreground, this GetFocus() will not work.
modified 13-Aug-18 7:58am.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
