Android login using PHP and mysql

Question

0.00/5 (No votes)

See more:

I am developing an android app using php and mysql. This login has a restriction where only active users can logged in. In mysql table column active is set to 1 or 0 for active and inactive, respectively. The problem here is when the value of active is set to 1, it displays not active. Here's my code below

What I have tried:

Android
Code inside volley response method

Java

String userId = jObj.getString("user_id");
String userType = jObj.getString("type");
String userActive = jObj.getString("active");

if (userId != "null") {

    switch (userType)
    {
    case "1":
        Toast.makeText(getApplicationContext(),"Access Denied", Toast.LENGTH_LONG).show();
        break;
    default:
        session.setLogin(true);
        session.setType(userType,userId);
        if(userActive=="1"){
            Intent dashB = new Intent(login_activity.this,MainDashBoard.class);
            startActivity(dashB);
            finish();
        }
        else{
            Toast.makeText(getApplicationContext(),"Not active", Toast.LENGTH_LONG).show();
        }
        break;
    }
} else {
    String errorMsg = jObj.getString("error_msg");
    Toast.makeText(login_activity.this,"Invalid Username or Password", Toast.LENGTH_LONG).show();

Posted 29-Jul-16 10:57am

Sac Yac

Updated 29-Jul-16 23:42pm

Richard MacCutchan

v2

Add a Solution

Comments

Afzaal Ahmad Zeeshan 30-Jul-16 6:16am

Apart from what Richard has said, would that return "null" or null? There is a difference.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2016-07-29T23:42:00

Solution 1

You should not use the == operator for strings, use String.equals[^].

Posted 29-Jul-16 23:42pm

Richard MacCutchan

Comments

Afzaal Ahmad Zeeshan 30-Jul-16 6:16am

5ed.

Sac Yac 30-Jul-16 12:15pm

Oh...ok thanks. But one big question now is why my volley response is empty whenever user provides an incorrect username and password? Heres the php code

if (isset($user)) {
// user found
$response["error"] = FALSE;
$response["user_id"] = $user["uid"];
$response["type"] = $user["type"];
$response["active"] = $user["active"];
echo json_encode($response);

} else {
// user not found
// echo json with error = 1
$response["error"] = TRUE;
$response["user_id"] = "null";
$response["error_msg"] = "Incorrect email or password!";
echo json_encode($response);

}
i have even log the output to a text file of what its json object would be...here's the json result below-

{"error":true,"user_id":"null","error_msg":"Incorrect email or password!"}

Richard MacCutchan 30-Jul-16 12:45pm

You will need to debug the PHP code to see why, and check where the values are not getting returned correctly.

Sac Yac 30-Jul-16 16:23pm

Thanks for the help. Actually the response was expecting some values. I did solved the problem.